> -Original Message-
> From: David Marchand
> Sent: Thursday 3 July 2025 15:10
>
> On Thu, Jun 26, 2025 at 11:53 AM Marat Khalili
> wrote:
> > > @@ -15,7 +15,7 @@ call_all_telemetry() {
> > > telemetry_script=$rootdir/usertools/dpdk-tele
> -Original Message-
> From: David Marchand
> Sent: Monday 23 June 2025 14:53
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Bruce Richardson ; Tyler
> Retzlaff ; Neil Horman
>
> Subject: [PATCH v2 07/10] tailq: fix cast macro for null pointer
>
> Doing arithmetics with the NULL pointer is un
t high)
> {
> do {
> - pl->map |= (1 << low++);
> + pl->map |= RTE_BIT32(low);
> + low++;
> } while (low <= high);
> }
Reviewed-by: Marat Khalili
> -Original Message-
> From: David Marchand
> Sent: Thursday 26 June 2025 09:33
>
> The problem lies in the use of subshell and pipes and that a failure
> is not propagated.
> Adding a test only the the telemetry script would not catch other
> errors (like for example, if the jq command s
Acked-by: Marat Khalili
NULL when stat->xstat_cntrs is zero.
Fixes: 070db97e017 ("graph: support node xstats")
Signed-off-by: Marat Khalili
---
Thanks to Jerin Jacob and David Marchand for the reviews.
v3:
* Addressing comments from David Marchand change to check the length
instead of the pointer, fix format
Thank you for doing this.
> +static bool
> +ends_with(const char *str, size_t str_len, const char *tail)
I too think we should have a general ends_with, I for one had to code one just
this week. However, I do not think it should support non-null-terminated
strings.
> +{
> + size_t tail_len
Reviewed-by: Marat Khalili
Just an idea, in case you have another iteration: could we maybe add a small
check that $telemetry_script actually exists and executable to avoid similar
situations in the future? Can be as simple as:
test -f "$telemetry_script"
test -x "$telemetry_
Looks good.
Reviewed-by: Marat Khalili
> -Original Message-
> From: David Marchand
> Sent: Monday 23 June 2025 13:08
>
> Could you spend some time on reviewing patches on the topic?
> Like for example:
> https://patchwork.dpdk.org/project/dpdk/list/?series=35509
Sure, will look!
> rte_malloc is not required.
> I have a fix i
allocations in a way that matches the
declaration. Would it be an ok solution?
> -Original Message-
> From: Marat Khalili
> Sent: Tuesday 17 June 2025 17:40
> To: Jerin Jacob
> Cc: Jerin Jacob ; Kiran Kumar K
> ; Nithin Dabilpuram
> ; Zhirun Yan ; Pavan
> Nikhilesh ; de
.
Signed-off-by: Marat Khalili
---
MAINTAINERS file does not list any maintainers for the Unit tests
framework, so addressing Bruce Richardson who maintains other build
tools. Apologies in advance, feel free to ignore or redirect.
buildtools/get-test-suites.py | 20 +++-
1 file
> -Original Message-
> From: Jerin Jacob
> Sent: Tuesday 17 June 2025 16:50
>
> > > > -struct __rte_cache_aligned rte_graph_cluster_node_stats {
> > > > +struct rte_graph_cluster_node_stats {
> > >
> > > This is a fastpath structure. No need to change the alignment here.
> >
> > rte_graph
> -Original Message-
> From: Jerin Jacob
> Sent: Tuesday 17 June 2025 16:28
>
> > -struct __rte_cache_aligned rte_graph_cluster_node_stats {
> > +struct rte_graph_cluster_node_stats {
>
> This is a fastpath structure. No need to change the alignment here.
rte_graph_cluster_stats include
raph: implement stats")
Signed-off-by: Marat Khalili
---
v2: Following the suggestions from Jerin Jacob changed the fix to simply
remove non-default alignment. Although there are many ways to make
alignment work, I personally agree that it is probably better to keep
the code simple as long as p
"graph: support node xstats")
Signed-off-by: Marat Khalili
---
v2: Following the suggestions from Jerin Jacob changed the Subject and
added Fixes line.
lib/graph/graph_stats.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/graph/graph_stats.c b/lib/graph/gra
27;, which requires 64 byte alignment
To fix the issue replace realloc calls with rte_malloc and rte_realloc
specifying correct alignment, use rte_free to free the result.
Signed-off-by: Marat Khalili
---
lib/graph/graph_stats.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff -
depending on stat->xstat_count being NULL.)
Sanitizer message:
lib/graph/graph_stats.c:473:2: runtime error: null pointer passed as
argument 1, which is declared to never be null
To fix the issue add a check that stat->xstat_count is not NULL before
the call.
Signed-off-by: Marat K
18 matches
Mail list logo
