Reviewed-by: Marat Khalili <marat.khal...@huawei.com>
Just an idea, in case you have another iteration: could we maybe add a small
check that $telemetry_script actually exists and executable to avoid similar
situations in the future? Can be as simple as:
test -f "$telemetry_script"
test -x "$telemetry_script"
Due to -e in the first line it should fail the script of any of these tests
fail.
> -----Original Message-----
> From: David Marchand <david.march...@redhat.com>
> Sent: Monday 23 June 2025 14:53
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Bruce Richardson <bruce.richard...@intel.com>
> Subject: [PATCH v2 02/10] test/telemetry: fix test calling all commands
>
> This test was doing nothing as it could not find the telemetry client
> script following the test suite rework.
>
> Caught while looking at UNH unit test logs:
>
> /root/workspace/Generic-Unit-Test-
> DPDK/dpdk/app/test/suites/test_telemetry.sh:
> 18: /root/workspace/Generic-Unit-Test-DPDK/dpdk/app/usertools/dpdk-
> telemetry.py:
> not found
>
> Fixes: 9da71dc4f96e ("test: add test case for scripted telemetry commands")
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Marchand <david.march...@redhat.com>
> Acked-by: Bruce Richardson <bruce.richard...@intel.com>
> ---
> app/test/suites/test_telemetry.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test/suites/test_telemetry.sh
> b/app/test/suites/test_telemetry.sh
> index ca6abe266e..20806b43e4 100755
> --- a/app/test/suites/test_telemetry.sh
> +++ b/app/test/suites/test_telemetry.sh
> @@ -7,7 +7,7 @@ which jq || {
> exit 77
> }
>
> -rootdir=$(readlink -f $(dirname $(readlink -f $0))/../..)
> +rootdir=$(readlink -f $(dirname $(readlink -f $0))/../../..)
> tmpoutput=$(mktemp -t dpdk.test_telemetry.XXXXXX)
> trap "cat $tmpoutput; rm -f $tmpoutput" EXIT
>
> --
> 2.49.0
