[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318914954 ## File path: be/src/olap/data_dir.cpp ## @@ -582,7 +576,9 @@ OLAPStatus DataDir::_convert_old_tablet()

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1722: Use int64 when converting TIME type value

chaoyli commented on a change in pull request #1722: Use int64 when converting TIME type value URL: https://github.com/apache/incubator-doris/pull/1722#discussion_r318919843 ## File path: be/src/runtime/memory_scratch_sink.cpp ## @@ -140,7 +140,7 @@ Status MemoryScratchSi

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318921870 ## File path: be/src/olap/rowset/segment_group.h ## @@ -248,7 +248,7 @@ class SegmentGroup { int

[GitHub] [incubator-doris] gaodayue commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

gaodayue commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526063742 @imay thanks for the comments. > If we support other type of index, for example B+Tree, do we need to store all in

[GitHub] [incubator-doris] imay commented on issue #1721: Make bitmap_union agg column support insert into

imay commented on issue #1721: Make bitmap_union agg column support insert into URL: https://github.com/apache/incubator-doris/pull/1721#issuecomment-526064274 @kangkaisen I have seen this PR. I think you should check source column is a valid bitmap in InsertStatement like HLL [here

[GitHub] [incubator-doris] imay commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

imay commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526075357 > @imay thanks for the comments. > > > If we support other type of index, for example B+Tree, do we need to store all

[GitHub] [incubator-doris] kangpinghuang commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

kangpinghuang commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526081460 > [Bitmap Index for Column 1] [Bitmap Index for Column 2] ... [Bitmap Index for Column n] [Footer

[GitHub] [incubator-doris] kangpinghuang edited a comment on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

kangpinghuang edited a comment on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526081460 > [Bitmap Index for Column 1] [Bitmap Index for Column 2] ... [Bitmap Index for Column n]

[GitHub] [incubator-doris] kangpinghuang edited a comment on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

kangpinghuang edited a comment on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526081460 ` [Bitmap Index for Column 1] [Bitmap Index for Column 2] ... [Bitmap Index for Column n] [Foot

[GitHub] [incubator-doris] kangpinghuang edited a comment on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

kangpinghuang edited a comment on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526081460 ` test test ` ` [Bitmap Index for Column 1] [Bitmap Index for Column 2] ... [Bitma

[GitHub] [incubator-doris] kangpinghuang commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

kangpinghuang commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526082595 > `test test` > > ` [Bitmap Index for Column 1] [Bitmap Index for Column 2] ... [Bitmap Index for Column n] [

[GitHub] [incubator-doris] kangpinghuang removed a comment on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

kangpinghuang removed a comment on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526082595 > `test test` > > ` [Bitmap Index for Column 1] [Bitmap Index for Column 2] ... [Bitmap Index for Col

[GitHub] [incubator-doris] kangpinghuang edited a comment on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

kangpinghuang edited a comment on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526081460 Can we write bitmap index of each column into a independent file, named with column_id in its name, eg: segme

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1695: Refactor alter job

yiguolei commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r318950070 ## File path: be/src/olap/schema_change.cpp ## @@ -1332,9 +1332,12 @@ OLAPStatus SchemaChangeHandler::_do_process_alter_t

[GitHub] [incubator-doris] kangpinghuang commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

kangpinghuang commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526087487 > Agree. In this way the I/O cost of adding a new index is minimum, but reader now needs to know what indexes are av

[GitHub] [incubator-doris] imay commented on a change in pull request #1716: Avoid consistency problem when has no more data

imay commented on a change in pull request #1716: Avoid consistency problem when has no more data URL: https://github.com/apache/incubator-doris/pull/1716#discussion_r318955067 ## File path: be/src/runtime/result_queue_mgr.cpp ## @@ -47,6 +47,10 @@ Status ResultQueueMgr::f

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1695: Refactor alter job

yiguolei commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r318961674 ## File path: fe/src/main/java/org/apache/doris/alter/RollupHandler.java ## @@ -270,93 +273,56 @@ private void processAddR

[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request #1721: Make bitmap_union agg column support insert into

HangyuanLiu commented on a change in pull request #1721: Make bitmap_union agg column support insert into URL: https://github.com/apache/incubator-doris/pull/1721#discussion_r318964623 ## File path: docs/documentation/cn/sql-reference/sql-statements/Data Definition/CREATE TABLE.md

[GitHub] [incubator-doris] kangkaisen commented on issue #1721: Make bitmap_union agg column support insert into

kangkaisen commented on issue #1721: Make bitmap_union agg column support insert into URL: https://github.com/apache/incubator-doris/pull/1721#issuecomment-526101291 > @kangkaisen > I have seen this PR. > I think you should check source column is a valid bitmap in InsertStatement lik

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1721: Make bitmap_union agg column support insert into

kangkaisen commented on a change in pull request #1721: Make bitmap_union agg column support insert into URL: https://github.com/apache/incubator-doris/pull/1721#discussion_r318968848 ## File path: docs/documentation/cn/sql-reference/sql-statements/Data Definition/CREATE TABLE.md

[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request #1721: Make bitmap_union agg column support insert into

HangyuanLiu commented on a change in pull request #1721: Make bitmap_union agg column support insert into URL: https://github.com/apache/incubator-doris/pull/1721#discussion_r318972876 ## File path: docs/documentation/cn/sql-reference/sql-statements/Data Definition/CREATE TABLE.md

[GitHub] [incubator-doris] morningman commented on a change in pull request #1722: Use double when converting TIME type value

morningman commented on a change in pull request #1722: Use double when converting TIME type value URL: https://github.com/apache/incubator-doris/pull/1722#discussion_r318975266 ## File path: be/src/runtime/memory_scratch_sink.cpp ## @@ -140,7 +140,7 @@ Status MemoryScrat

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1721: Make bitmap_union agg column support insert into

kangkaisen commented on a change in pull request #1721: Make bitmap_union agg column support insert into URL: https://github.com/apache/incubator-doris/pull/1721#discussion_r318979529 ## File path: docs/documentation/cn/sql-reference/sql-statements/Data Definition/CREATE TABLE.md

[GitHub] [incubator-doris] gaodayue commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

gaodayue commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526113327 @kangpinghuang > Can we write bitmap index of each column into a independent file, named with column_id in its na

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1695: Refactor alter job

yiguolei commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319004248 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java ## @@ -329,15 +328,20 @@ public voi

[GitHub] [incubator-doris] imay commented on a change in pull request #1721: Make bitmap_union agg column support insert into

imay commented on a change in pull request #1721: Make bitmap_union agg column support insert into URL: https://github.com/apache/incubator-doris/pull/1721#discussion_r319002033 ## File path: fe/src/main/java/org/apache/doris/analysis/InsertStmt.java ## @@ -478,6 +489,24 @

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1695: Refactor alter job

yiguolei commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319007129 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java ## @@ -778,8 +758,8 @@ public boole

[GitHub] [incubator-doris] morningman merged pull request #1716: Avoid consistency problem when has no more data

morningman merged pull request #1716: Avoid consistency problem when has no more data URL: https://github.com/apache/incubator-doris/pull/1716 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-doris] wuyunfeng commented on issue #1716: Avoid consistency problem when has no more data

wuyunfeng commented on issue #1716: Avoid consistency problem when has no more data URL: https://github.com/apache/incubator-doris/pull/1716#issuecomment-526136160 https://github.com/apache/incubator-doris/issues/1525 This is

[GitHub] [incubator-doris] imay closed issue #1648: optimize V2 BinaryPlainPage format

imay closed issue #1648: optimize V2 BinaryPlainPage format URL: https://github.com/apache/incubator-doris/issues/1648 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-doris] imay closed issue #1651: Support checksum in BetaRowset

imay closed issue #1651: Support checksum in BetaRowset URL: https://github.com/apache/incubator-doris/issues/1651 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1721: Make bitmap_union agg column support insert into and broker load

kangkaisen commented on a change in pull request #1721: Make bitmap_union agg column support insert into and broker load URL: https://github.com/apache/incubator-doris/pull/1721#discussion_r319023099 ## File path: fe/src/main/java/org/apache/doris/analysis/InsertStmt.java #

[GitHub] [incubator-doris] morningman opened a new issue #1723: 元数据支持存储计算分离

morningman opened a new issue #1723: 元数据支持存储计算分离 URL: https://github.com/apache/incubator-doris/issues/1723 在存储计算架构中，数据可能存储在本地、远端，或同时存储在本地和远端。当数据存储在远端时，本地存储将作为一个全量Cache存在。在这种架构，现有的以下流程需求进行重新设计： * Backend 的元数据管理 * 建表或创建分区时数据分片的分布管理 * 数据副本的修改，数据分片的修复和均衡 * 数据导入控制 * StorageMe

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1695: Refactor alter job

yiguolei commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319025624 ## File path: fe/src/main/java/org/apache/doris/alter/RollupJobV2.java ## @@ -0,0 +1,744 @@ +// Licensed to the Apache Sof

[GitHub] [incubator-doris] imay commented on a change in pull request #1721: Make bitmap_union agg column support insert into and broker load

imay commented on a change in pull request #1721: Make bitmap_union agg column support insert into and broker load URL: https://github.com/apache/incubator-doris/pull/1721#discussion_r319030547 ## File path: fe/src/main/java/org/apache/doris/planner/ScanNode.java ## @@ -37

[GitHub] [incubator-doris] imay commented on issue #1723: 元数据支持存储计算分离

imay commented on issue #1723: 元数据支持存储计算分离 URL: https://github.com/apache/incubator-doris/issues/1723#issuecomment-526166188 @morningman 我觉得我们应该还是保留Backend这个实体，而不是将Storage全部替换为Backend。 1. Storage，StorageGroup应该做为Backend的某个属性存在。因为Backend上不仅有Storage的功能还有Compute的能力。 2. 未来我们想要把我

[GitHub] [incubator-doris] imay merged pull request #1722: Use double when converting TIME type value

imay merged pull request #1722: Use double when converting TIME type value URL: https://github.com/apache/incubator-doris/pull/1722 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] morningman commented on issue #1721: Make bitmap_union agg column support insert into and broker load

morningman commented on issue #1721: Make bitmap_union agg column support insert into and broker load URL: https://github.com/apache/incubator-doris/pull/1721#issuecomment-526185297 There are a lot change related to load process in my pull request #1695 . So...Please do not change any cl

[GitHub] [incubator-doris] morningman commented on a change in pull request #1695: Refactor alter job

morningman commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319071480 ## File path: be/src/olap/schema_change.cpp ## @@ -1332,9 +1332,12 @@ OLAPStatus SchemaChangeHandler::_do_process_alter

[GitHub] [incubator-doris] morningman commented on a change in pull request #1695: Refactor alter job

morningman commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319072094 ## File path: fe/src/main/java/org/apache/doris/alter/RollupHandler.java ## @@ -270,93 +273,56 @@ private void processAd

[GitHub] [incubator-doris] morningman opened a new issue #1724: Support checking transaction at table level instead of database level

morningman opened a new issue #1724: Support checking transaction at table level instead of database level URL: https://github.com/apache/incubator-doris/issues/1724 When altering table, we will wait for all previous transaction to be finished. But because there is no table info in tran

[GitHub] [incubator-doris] morningman commented on a change in pull request #1695: Refactor alter job

morningman commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319074000 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java ## @@ -778,8 +758,8 @@ public boo

[GitHub] [incubator-doris] morningman commented on a change in pull request #1695: Refactor alter job

morningman commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319079538 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java ## @@ -329,15 +328,20 @@ public v

[GitHub] [incubator-doris] imay commented on issue #1429: Refactor the process of ALTER job.

imay commented on issue #1429: Refactor the process of ALTER job. URL: https://github.com/apache/incubator-doris/issues/1429#issuecomment-526228394 > rollup replica 在整个作业期间不能进行副本均衡和修复。 如果整个作业期间不能进行rollup replica副本修复，那么我担心Job作业时间过长，导入有多个副本损坏，会导致正常的导入作业也没法完成。 > 对于 WAITING_TXN 的作

[GitHub] [incubator-doris] kangkaisen commented on issue #1721: Make bitmap_union agg column support insert into and broker load

kangkaisen commented on issue #1721: Make bitmap_union agg column support insert into and broker load URL: https://github.com/apache/incubator-doris/pull/1721#issuecomment-526440302 > There are a lot change related to load process in my pull request #1695 . > So...Please do not change an

[GitHub] [incubator-doris] imay commented on a change in pull request #1695: Refactor alter job

imay commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319337884 ## File path: fe/src/main/java/org/apache/doris/task/StreamLoadTask.java ## @@ -83,8 +84,15 @@ public TFileFormatType getForma

[GitHub] [incubator-doris] imay commented on a change in pull request #1695: Refactor alter job

imay commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319345455 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java ## @@ -303,6 +304,10 @@ protected void setJobProperti

[GitHub] [incubator-doris] imay commented on a change in pull request #1695: Refactor alter job

imay commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319336556 ## File path: fe/src/main/java/org/apache/doris/planner/StreamLoadScanNode.java ## @@ -124,67 +126,85 @@ public void init(Anal

[GitHub] [incubator-doris] imay commented on a change in pull request #1695: Refactor alter job

imay commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319372633 ## File path: fe/src/main/java/org/apache/doris/analysis/DataDescription.java ## @@ -65,34 +67,43 @@ public class DataDescrip

[GitHub] [incubator-doris] imay commented on a change in pull request #1695: Refactor alter job

imay commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319369421 ## File path: fe/src/main/java/org/apache/doris/alter/RollupJobV2.java ## @@ -0,0 +1,744 @@ +// Licensed to the Apache Softwar

[GitHub] [incubator-doris] imay commented on a change in pull request #1695: Refactor alter job

imay commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319337464 ## File path: fe/src/main/java/org/apache/doris/transaction/TransactionState.java ## @@ -408,6 +414,23 @@ public void setTxnCo

[GitHub] [incubator-doris] imay merged pull request #1721: Make bitmap_union agg column support insert into and broker load

imay merged pull request #1721: Make bitmap_union agg column support insert into and broker load URL: https://github.com/apache/incubator-doris/pull/1721 This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-doris] EmmyMiao87 opened a new issue #1725: The null result of union stmt is incorrect

EmmyMiao87 opened a new issue #1725: The null result of union stmt is incorrect URL: https://github.com/apache/incubator-doris/issues/1725 **Describe the bug** The null result of union stmt is incorrect when the child of union stmt is a outer join with the null-supplying column.

[GitHub] [incubator-doris] imay opened a new issue #1726: CPU idle is still high when concurrent access is high

imay opened a new issue #1726: CPU idle is still high when concurrent access is high URL: https://github.com/apache/incubator-doris/issues/1726 When there is high concurrent access to Doris, our BE CPU idle is still high. If we increase the concurrence, the latency increase but the CPU idl

[GitHub] [incubator-doris] imay commented on issue #1726: CPU idle is still high when concurrent access is high

imay commented on issue #1726: CPU idle is still high when concurrent access is high URL: https://github.com/apache/incubator-doris/issues/1726#issuecomment-526524927 There are some enhancements we can do. First I will free the finished scanner out of lock.

[GitHub] [incubator-doris] morningman opened a new pull request #1727: Fix result of unix_timestamp()

morningman opened a new pull request #1727: Fix result of unix_timestamp() URL: https://github.com/apache/incubator-doris/pull/1727 Date before 1970-01-01 or after 2038-01-19 03:14:07 should return 0 for unix_timestamp() function

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1728: Error check about column which has no default value

EmmyMiao87 opened a new pull request #1728: Error check about column which has no default value URL: https://github.com/apache/incubator-doris/pull/1728 This commit check the all of parsed columns include hadoop functions and other functions. Otherwise, the load will thrown the "Column

[GitHub] [incubator-doris] morningman commented on a change in pull request #1728: Error check about column which has no default value

morningman commented on a change in pull request #1728: Error check about column which has no default value URL: https://github.com/apache/incubator-doris/pull/1728#discussion_r319438182 ## File path: fe/src/main/java/org/apache/doris/load/Load.java ## @@ -715,7 +714,7 @@

[GitHub] [incubator-doris] chaoyli commented on issue #1705: Limit V2 segment file row count (#1647)

chaoyli commented on issue #1705: Limit V2 segment file row count (#1647) URL: https://github.com/apache/incubator-doris/pull/1705#issuecomment-526549855 LGTM, I will merge it after code checks. This is an automated message fr

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1728: Error check about column which has no default value

EmmyMiao87 commented on a change in pull request #1728: Error check about column which has no default value URL: https://github.com/apache/incubator-doris/pull/1728#discussion_r319455334 ## File path: fe/src/main/java/org/apache/doris/load/Load.java ## @@ -715,7 +714,7 @@

[GitHub] [incubator-doris] imay commented on a change in pull request #1705: Limit V2 segment file row count (#1647)

imay commented on a change in pull request #1705: Limit V2 segment file row count (#1647) URL: https://github.com/apache/incubator-doris/pull/1705#discussion_r319457677 ## File path: be/src/olap/rowset/segment_v2/segment_writer.h ## @@ -60,6 +60,8 @@ class SegmentWriter {

[GitHub] [incubator-doris] chaoyli merged pull request #1705: Limit V2 segment file row count (#1647)

chaoyli merged pull request #1705: Limit V2 segment file row count (#1647) URL: https://github.com/apache/incubator-doris/pull/1705 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-doris] morningman merged pull request #1728: Error check about column which has no default value

morningman merged pull request #1728: Error check about column which has no default value URL: https://github.com/apache/incubator-doris/pull/1728 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-doris] morningman commented on a change in pull request #1695: Refactor alter job

morningman commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319503704 ## File path: fe/src/main/java/org/apache/doris/planner/StreamLoadScanNode.java ## @@ -124,67 +126,85 @@ public void ini

[GitHub] [incubator-doris] xy720 opened a new pull request #1729: Add English version Doris website

xy720 opened a new pull request #1729: Add English version Doris website URL: https://github.com/apache/incubator-doris/pull/1729 1、Adjustment of website menu structure, add a parent menu according the language. 2、Fix garbled title in help documents.

[GitHub] [incubator-doris] morningman commented on a change in pull request #1695: Refactor alter job

morningman commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319505262 ## File path: fe/src/main/java/org/apache/doris/transaction/TransactionState.java ## @@ -408,6 +414,23 @@ public void se

[GitHub] [incubator-doris] morningman commented on a change in pull request #1695: Refactor alter job

morningman commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319505833 ## File path: fe/src/main/java/org/apache/doris/task/StreamLoadTask.java ## @@ -83,8 +84,15 @@ public TFileFormatType ge

[GitHub] [incubator-doris] morningman commented on a change in pull request #1695: Refactor alter job

morningman commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319509179 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java ## @@ -303,6 +304,10 @@ protected void setJobPr

[GitHub] [incubator-doris] morningman commented on a change in pull request #1695: Refactor alter job

morningman commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319509613 ## File path: fe/src/main/java/org/apache/doris/alter/RollupJobV2.java ## @@ -0,0 +1,744 @@ +// Licensed to the Apache S

[GitHub] [incubator-doris] morningman commented on a change in pull request #1695: Refactor alter job

morningman commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319510217 ## File path: fe/src/main/java/org/apache/doris/analysis/DataDescription.java ## @@ -65,34 +67,43 @@ public class DataD

[GitHub] [incubator-doris] imay merged pull request #1727: Fix result of unix_timestamp()

imay merged pull request #1727: Fix result of unix_timestamp() URL: https://github.com/apache/incubator-doris/pull/1727 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-doris] morningman merged pull request #1729: Add English version Doris website

morningman merged pull request #1729: Add English version Doris website URL: https://github.com/apache/incubator-doris/pull/1729 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] morningman opened a new pull request #1730: Modify the website and documents

morningman opened a new pull request #1730: Modify the website and documents URL: https://github.com/apache/incubator-doris/pull/1730 1. Add Apache incubator disclaimer. 2. Add "Edit on Github" button on every page. 3. Add Committer Ling Miao. 4. Modify some English documents.

[GitHub] [incubator-doris] morningman merged pull request #1730: Modify the website and documents

morningman merged pull request #1730: Modify the website and documents URL: https://github.com/apache/incubator-doris/pull/1730 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-doris] morningman commented on a change in pull request #1695: Refactor alter job

morningman commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319721530 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/BrokerLoadJob.java ## @@ -355,16 +356,24 @@ private void cre

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1718: Basic implementation for BetaRowsetReader

gaodayue commented on a change in pull request #1718: Basic implementation for BetaRowsetReader URL: https://github.com/apache/incubator-doris/pull/1718#discussion_r319745639 ## File path: be/src/olap/rowset/beta_rowset_reader.cpp ## @@ -0,0 +1,111 @@ +// Licensed to the A

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1718: Basic implementation for BetaRowsetReader

gaodayue commented on a change in pull request #1718: Basic implementation for BetaRowsetReader URL: https://github.com/apache/incubator-doris/pull/1718#discussion_r319745649 ## File path: be/src/olap/rowset/beta_rowset_reader.cpp ## @@ -0,0 +1,111 @@ +// Licensed to the A

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1695: Refactor alter job

EmmyMiao87 commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319757282 ## File path: fe/src/main/java/org/apache/doris/analysis/DataDescription.java ## @@ -65,34 +67,43 @@ public class DataD

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1695: Refactor alter job

EmmyMiao87 commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319758050 ## File path: fe/src/main/java/org/apache/doris/planner/BrokerScanNode.java ## @@ -225,62 +229,73 @@ private void initPa

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1695: Refactor alter job

EmmyMiao87 commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319758180 ## File path: fe/src/main/java/org/apache/doris/load/Load.java ## @@ -643,16 +634,12 @@ public static void checkAndCreat

[GitHub] [incubator-doris] morningman commented on a change in pull request #1695: Refactor alter job

morningman commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319785451 ## File path: fe/src/main/java/org/apache/doris/analysis/DataDescription.java ## @@ -65,34 +67,43 @@ public class DataD

[GitHub] [incubator-doris] kangpinghuang commented on issue #1718: Basic implementation for BetaRowsetReader

kangpinghuang commented on issue #1718: Basic implementation for BetaRowsetReader URL: https://github.com/apache/incubator-doris/pull/1718#issuecomment-526973901 add a description for this pr. This is an automated message fro

[GitHub] [incubator-doris] morningman commented on a change in pull request #1695: Refactor alter job

morningman commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319787154 ## File path: fe/src/main/java/org/apache/doris/load/Load.java ## @@ -643,16 +634,12 @@ public static void checkAndCreat

[GitHub] [incubator-doris] yiguolei commented on issue #1678: Add rowset id generator to FE and BE

yiguolei commented on issue #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#issuecomment-526979725 #1717 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] gaodayue commented on issue #1718: Basic implementation for BetaRowsetReader

gaodayue commented on issue #1718: Basic implementation for BetaRowsetReader URL: https://github.com/apache/incubator-doris/pull/1718#issuecomment-526985884 @kangpinghuang I have updated the description for the PR This is an a

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #1731: Add scroll keepalive and http timeout configuration

wuyunfeng opened a new pull request #1731: Add scroll keepalive and http timeout configuration URL: https://github.com/apache/incubator-doris/pull/1731 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] imay opened a new pull request #1732: Add exchange in MemPool to reduce alloc/free operation

imay opened a new pull request #1732: Add exchange in MemPool to reduce alloc/free operation URL: https://github.com/apache/incubator-doris/pull/1732 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-doris] imay opened a new pull request #1733: Free olap scanner out of lock

imay opened a new pull request #1733: Free olap scanner out of lock URL: https://github.com/apache/incubator-doris/pull/1733 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #1734: Commit kafka offset in routine load

HangyuanLiu opened a new pull request #1734: Commit kafka offset in routine load URL: https://github.com/apache/incubator-doris/pull/1734 Commit kafka offset in routine load This is an automated message from the Apache Git Ser

[GitHub] [incubator-doris] morningman opened a new pull request #1735: Fix NPE of DataDescription

morningman opened a new pull request #1735: Fix NPE of DataDescription URL: https://github.com/apache/incubator-doris/pull/1735 When user does not specify column mapping in BrokerLoadStmt, NPE may be thrown. This is an automa

[GitHub] [incubator-doris] imay commented on a change in pull request #1718: Basic implementation for BetaRowsetReader

imay commented on a change in pull request #1718: Basic implementation for BetaRowsetReader URL: https://github.com/apache/incubator-doris/pull/1718#discussion_r319804287 ## File path: be/src/olap/rowset/beta_rowset_reader.cpp ## @@ -0,0 +1,122 @@ +// Licensed to the Apach

[GitHub] [incubator-doris] imay commented on a change in pull request #1718: Basic implementation for BetaRowsetReader

imay commented on a change in pull request #1718: Basic implementation for BetaRowsetReader URL: https://github.com/apache/incubator-doris/pull/1718#discussion_r319804882 ## File path: be/src/olap/rowset/beta_rowset_reader.cpp ## @@ -0,0 +1,122 @@ +// Licensed to the Apach

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1718: Basic implementation for BetaRowsetReader

gaodayue commented on a change in pull request #1718: Basic implementation for BetaRowsetReader URL: https://github.com/apache/incubator-doris/pull/1718#discussion_r319810639 ## File path: be/src/olap/rowset/beta_rowset_reader.cpp ## @@ -0,0 +1,122 @@ +// Licensed to the A

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1718: Basic implementation for BetaRowsetReader

gaodayue commented on a change in pull request #1718: Basic implementation for BetaRowsetReader URL: https://github.com/apache/incubator-doris/pull/1718#discussion_r319811405 ## File path: be/src/olap/rowset/beta_rowset_reader.cpp ## @@ -0,0 +1,122 @@ +// Licensed to the A

[GitHub] [incubator-doris] imay commented on a change in pull request #1718: Basic implementation for BetaRowsetReader

imay commented on a change in pull request #1718: Basic implementation for BetaRowsetReader URL: https://github.com/apache/incubator-doris/pull/1718#discussion_r319814625 ## File path: be/src/olap/rowset/beta_rowset_reader.cpp ## @@ -0,0 +1,122 @@ +// Licensed to the Apach

[GitHub] [incubator-doris] imay closed pull request #1733: Free olap scanner out of lock

imay closed pull request #1733: Free olap scanner out of lock URL: https://github.com/apache/incubator-doris/pull/1733 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-doris] imay opened a new pull request #1733: Free olap scanner out of lock

imay opened a new pull request #1733: Free olap scanner out of lock URL: https://github.com/apache/incubator-doris/pull/1733 This PR will close scanner out of OlapScanner's batch lock, which will lead all scanners wait for one scanner to finish. #1726 ---

[GitHub] [incubator-doris] kangkaisen commented on issue #1733: Free olap scanner out of lock

kangkaisen commented on issue #1733: Free olap scanner out of lock URL: https://github.com/apache/incubator-doris/pull/1733#issuecomment-527014747 @imay Hi, do you have a benchmark test for this PR? This is an automated messag

[GitHub] [incubator-doris] kangkaisen commented on issue #1732: Add exchange in MemPool to reduce alloc/free operation

kangkaisen commented on issue #1732: Add exchange in MemPool to reduce alloc/free operation URL: https://github.com/apache/incubator-doris/pull/1732#issuecomment-527015673 This PR seems have a indent issue? This is an autom

[GitHub] [incubator-doris] imay commented on issue #1733: Free olap scanner out of lock

imay commented on issue #1733: Free olap scanner out of lock URL: https://github.com/apache/incubator-doris/pull/1733#issuecomment-527016602 > @imay Hi, do you have a benchmark test for this PR? @kangkaisen This only one reason leading to competition. After this is fixed, c

<    27   28   29   30   31   32   33   34   35   36   >