imay commented on a change in pull request #1716: Avoid consistency problem
when has no more data
URL: https://github.com/apache/incubator-doris/pull/1716#discussion_r318955067
##########
File path: be/src/runtime/result_queue_mgr.cpp
##########
@@ -47,6 +47,10 @@ Status ResultQueueMgr::fetch_result(const TUniqueId&
fragment_instance_id, std::
// sentinel nullptr indicates scan end
if (*result == nullptr) {
*eos = true;
+ // put sentinel for consistency, avoid repeated invoking fetch
result when hava no rowbatch
+ if (queue) {
Review comment:
```suggestion
if (queue != nullptr) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]