yiguolei commented on a change in pull request #1695: Refactor alter job
URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319004248
 
 

 ##########
 File path: 
fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java
 ##########
 @@ -329,15 +328,20 @@ public void commitTransaction(long dbId, long 
transactionId, List<TabletCommitIn
                 if 
(!tableToPartition.get(tableId).contains(partition.getId())) {
                     continue;
                 }
-                List<MaterializedIndex> allIndices = new ArrayList<>();
-                allIndices.addAll(partition.getMaterializedIndices());
-                MaterializedIndex rollingUpIndex = null;
-                RollupJob rollupJob = null;
-                if (table.getState() == OlapTableState.ROLLUP) {
-                    rollupJob = (RollupJob) 
catalog.getRollupHandler().getAlterJob(tableId);
-                    rollingUpIndex = 
rollupJob.getRollupIndex(partition.getId());
+
+                List<MaterializedIndex> allIndices = null;
+                if (transactionState.getLoadedTblIndexes().isEmpty()) {
 
 Review comment:
   Only stream load pu loaded indices, but dpp load does not, so that dpp load 
will fail during schema change process.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to