Re: [VOTE] Release Apache Commons Daemon 1.2.2 RC2

2019-10-03 Thread Mark Thomas
The following votes were cast: Binding: +1: ggregory, markt, chtompki The vote therefore passes. Thanks to everyone who contributed to this release. Mark - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additio

Re: [VOTE] Release Apache Commons Daemon 1.2.2 RC2

2019-10-02 Thread Rob Tompkins
Reports good, java8 “mvn clean test install site” good, java11 “mvn clean test install” good, unix 64 bit build good +1 binding > On Sep 30, 2019, at 12:04 PM, Mark Thomas wrote: > > A further regression has been identified in the 1.2.0/1.2.1 releases so > I'd like to get 1.2.2 released to add

Re: [VOTE] Release Apache Commons Daemon 1.2.2 RC2

2019-10-02 Thread Mark Thomas
On 30/09/2019 17:04, Mark Thomas wrote: > [X] Approved - go ahead and release Commons Daemon 1.2.2 RC2 as 1.2.2 > [ ] Broken - do not release because... I've checked the contents of the src distros against the 1.2.1 release. That identified no missing files in 1.2.2 but a few files that shoul

Re: [VOTE] Release Apache Commons Daemon 1.2.2 RC2

2019-10-01 Thread Gary Gregory
On Tue, Oct 1, 2019 at 3:43 AM Mark Thomas wrote: > On 30/09/2019 21:09, Gary Gregory wrote: > > Hi Mark, > > > > I know you said you fixed a bunch of warnings but I still warning get > these > > using CPU=X64; I had only tested CPU=X86 previously (sorry): > > No problem. I think you hit upon I c

Re: [VOTE] Release Apache Commons Daemon 1.2.2 RC2

2019-10-01 Thread Mark Thomas
On 30/09/2019 21:09, Gary Gregory wrote: > Hi Mark, > > I know you said you fixed a bunch of warnings but I still warning get these > using CPU=X64; I had only tested CPU=X86 previously (sorry): No problem. I think you hit upon I configuration I've never tested. > C:\Program Files (x86)\Windows

Re: [VOTE] Release Apache Commons Daemon 1.2.2 RC2

2019-09-30 Thread Gary Gregory
Hi Mark, I know you said you fixed a bunch of warnings but I still warning get these using CPU=X64; I had only tested CPU=X86 previously (sorry): C:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\ucrt\corecrt_wstring.h(139): warning C4391: 'size_t wcslen(const wchar_t *)': incorrect ret

[VOTE] Release Apache Commons Daemon 1.2.2 RC2

2019-09-30 Thread Mark Thomas
A further regression has been identified in the 1.2.0/1.2.1 releases so I'd like to get 1.2.2 released to address it. So, time for another release vote. Notable changes since 1.2.1 include: - Correct a regression (DAEMON-408) that caused Windows services to crash on start-up when the universal C