Hi Mark, I know you said you fixed a bunch of warnings but I still warning get these using CPU=X64; I had only tested CPU=X86 previously (sorry):
C:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\ucrt\corecrt_wstring.h(139): warning C4391: 'size_t wcslen(const wchar_t *)': incorrect return type for intrinsic function, expected 'unsigned int' I can't imagine this would be a blocker but I wanted to get your feedback. Gary On Mon, Sep 30, 2019 at 12:04 PM Mark Thomas <ma...@apache.org> wrote: > A further regression has been identified in the 1.2.0/1.2.1 releases so > I'd like to get 1.2.2 released to address it. So, time for another > release vote. > > Notable changes since 1.2.1 include: > - Correct a regression (DAEMON-408) that caused Windows services to > crash on start-up when the universal C runtime was not available > - Improve the source assembly definitions to prevent build artefacts > from being included in the source distributions > - Fix various compiler warnings with newer compilers / stricter compiler > warning settings > > The full set of changes is in the changelog > > 1.2.2 RC2 can be obtained from (r36129) > https://dist.apache.org/repos/dist/dev/commons/daemon/ > > The git tag is: > Tag: COMMONS_DAEMON_1_2_2_RC2 > URL: > > https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=commit;h=a92401b3bf4f6ec7661f7a4efe20d04421a06a4a > Hash: a92401b3bf4f6ec7661f7a4efe20d04421a06a4a > > The Maven Staging repo is: > https://repository.apache.org/content/repositories/orgapachecommons-1473/ > > The Windows binaries have been signed by the DigiCert (formerly > Symantec) code signing service. > > Files signed with my preferred key: > http://people.apache.org/~markt/ > KEYS file is standard Apache Commons keys file: > http://www.apache.org/dist/commons/KEYS > > > [ ] Approved - go ahead and release Commons Daemon 1.2.2 RC2 as 1.2.2 > [ ] Broken - do not release because... > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
