On 30/09/2019 21:09, Gary Gregory wrote: > Hi Mark, > > I know you said you fixed a bunch of warnings but I still warning get these > using CPU=X64; I had only tested CPU=X86 previously (sorry):
No problem. I think you hit upon I configuration I've never tested. > C:\Program Files (x86)\Windows > Kits\10\include\10.0.17763.0\ucrt\corecrt_wstring.h(139): warning C4391: > 'size_t wcslen(const wchar_t *)': incorrect return type for intrinsic > function, expected 'unsigned int' > > I can't imagine this would be a blocker but I wanted to get your feedback. TL;DR - I don't think this is an issue. If I build with my standard release environment (the one designed not to create dependencies on anything that doesn't ship in a clean Windows 7 / Server 2008 install) I don't get any warnings. If I build with the Visual Studio 2017 command line tools the x86 build is clean whereas I do get one warning with the x64 build. It is a slightly different one to you: .\..\..\apps\prunsrv\prunsrv.c(1389): warning C4312: 'type cast': conversion from 'DWORD' to 'LPVOID' of greater size. If I cross-compile for x64 from the VS 2017 x86 toolchain (which I have never done previously for Daemon) then I get a whole bunch of warnings similar to yours. I'm not concerned about the cross-compilation warnings since I don't need to cross compile. I can use an x64 toolchain for the x64 build and and an x86 toolchain for the x86 build. My initial impression is that the warnings are not a significant concern but I haven't dug into them. If cross-compilation becomes an itch someone wants to scratch then confirming exactly what is going on with these warnings is probably one of the first things they'd need to look at. I'm not concerned about the warning I see with the VS 2017 x64 build but I'd still like to see that warning go away if possible. I'll take a quick look at that now but I don't see it as an issue that should prevent the release. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
