Bug#989735: minicom: stack smashing when searching in history buffer

2021-06-14 Thread Adam Lackorzynski
On Mon Jun 14, 2021 at 10:19:13 +0100, Mike Crowe wrote: > Hi Adam, > > On Monday 14 June 2021 at 09:16:51 +0200, Adam Lackorzynski wrote: > > Ok, thanks. Meantime I changed all of this static memory handling to be > > more dynamic, also addressing this case I believe. The 'magic' constant > > i

Bug#989735: minicom: stack smashing when searching in history buffer

2021-06-14 Thread Mike Crowe
Hi Adam, On Monday 14 June 2021 at 09:16:51 +0200, Adam Lackorzynski wrote: > Ok, thanks. Meantime I changed all of this static memory handling to be > more dynamic, also addressing this case I believe. The 'magic' constant > is gone, so hopefully any of those cases. Thanks for the extremely quic

Bug#989735: minicom: stack smashing when searching in history buffer

2021-06-14 Thread Mike Crowe
On Sunday 13 June 2021 at 21:22:32 +0200, Adam Lackorzynski wrote: > thanks again. I wonder why it did not reproduce for me earlier. > Could you try attached patch and report back? Hi Adam, Thanks for the patch. It did seem better. However, when I do a case-insensitive search I now get:

Bug#989735: minicom: stack smashing when searching in history buffer

2021-06-14 Thread Adam Lackorzynski
Hi Mike, On Mon Jun 14, 2021 at 08:12:18 +0100, Mike Crowe wrote: > On Sunday 13 June 2021 at 21:22:32 +0200, Adam Lackorzynski wrote: > > thanks again. I wonder why it did not reproduce for me earlier. > > Could you try attached patch and report back? > > Hi Adam, > > Thanks for the patch. It d

Bug#989735: minicom: stack smashing when searching in history buffer

2021-06-13 Thread Mike Crowe
Hi Adam, Thanks for the speedy response. On Sunday 13 June 2021 at 17:25:20 +0200, Adam Lackorzynski wrote: > Hi, > > thanks for the report. The issue has always been there and had to do > with the width of minicom's window (over 256 columns). I have addressed > this. Aha. I switched font at a

Bug#989735: minicom: stack smashing when searching in history buffer

2021-06-13 Thread Adam Lackorzynski
Hi Mike, thanks again. I wonder why it did not reproduce for me earlier. Could you try attached patch and report back? Thanks, Adam On Sun Jun 13, 2021 at 17:16:36 +0100, Mike Crowe wrote: > Hi Adam, > > Thanks for the speedy response. > > On Sunday 13 June 2021 at 17:25:20 +0200, Adam Lackor

Bug#989735: minicom: stack smashing when searching in history buffer

2021-06-13 Thread Adam Lackorzynski
Hi, thanks for the report. The issue has always been there and had to do with the width of minicom's window (over 256 columns). I have addressed this. Martin, I have pushed this on the 2.8.x branch (8deebed). Please pick both changes there for the next upload. Thanks, Adam On Fri Jun 11, 2021

Bug#989735: minicom: stack smashing when searching in history buffer

2021-06-11 Thread Mike Crowe
Package: minicom Version: 2.8-1 Severity: important Steps to reproduce: 1. Start Minicom connected to a serial port with MINICOM="-m -c on -8" (although I was also able to reproduce the problem with MINICOM="" if the keystrokes below are changed appropriately.) 2. Cause whatever is connected to