Bug#877702: redis-server: Easily run multiple instances with systemd

2017-10-09 Thread Chris Lamb
Hey, > I just executed the generate-systemd-service-files that you wrote on my > local machine, and there is no notable differences between my local > redis-server@.service and the generated one. Only the comments I wrote > were stripped. Excellent! I'll upload this change when the fix for #87798

Bug#877702: redis-server: Easily run multiple instances with systemd

2017-10-09 Thread Adrien CLERC
> In the meantime, what would be the easiest way for you to test the result > of this change? Shall I attach the 4 .service files it now generates? I just executed the generate-systemd-service-files that you wrote on my local machine, and there is no notable differences between my local redis-serv

Bug#877702: redis-server: Easily run multiple instances with systemd

2017-10-08 Thread Chris Lamb
block 877702 by 877989 thanks To avoid epic DRY violations I've moved the packaging to generating the .service files at package-build time. You can see this here: https://github.com/lamby/pkg-redis/commit/6e9c54f7cc79a6ceee250fd4fcdc19605c60a505 Unfortunately, I am blocked from uploading this

Bug#877702: redis-server: Easily run multiple instances with systemd

2017-10-07 Thread Adrien CLERC
>> You're right, I should have also posted the following: >> >> # cat /etc/systemd/system/redis-server@rspamd.service.d/override.conf >> [Service] >> Type=simple >> PIDFile=/run/redis-%i/redis-server.pid > You say "I should have also posted", but this line actually conficts > with your previous dif

Bug#877702: redis-server: Easily run multiple instances with systemd

2017-10-07 Thread Chris Lamb
Hi Adrien, > You're right, I should have also posted the following: > > # cat /etc/systemd/system/redis-server@rspamd.service.d/override.conf > [Service] > Type=simple > PIDFile=/run/redis-%i/redis-server.pid You say "I should have also posted", but this line actually conficts with your previous

Bug#877702: redis-server: Easily run multiple instances with systemd

2017-10-07 Thread Adrien CLERC
>> If you (or someone) find this seperation desirable, maybe it could be >> integrated into redis-server@.service by changing RuntimeDirectory to >> redis-%i and ReadWriteDirectory accordingly. It is probably a bad idea >> for all users, though. > Most users would be using the non-templated redis-

Bug#877702: redis-server: Easily run multiple instances with systemd

2017-10-07 Thread Adrien CLERC
Hi, I came to the following basis: --- redis.service +++ redis-server@.service @@ -1,12 +1,12 @@  [Unit] -Description=Advanced key-value store +Description=Advanced key-value store (%I)  After=network.target  Documentation=http://redis.io/documentation, man:redis-server(1)    [Service]  Type=forki

Bug#877702: redis-server: Easily run multiple instances with systemd

2017-10-07 Thread Chris Lamb
Hi Adrien, > > We need to keep the "redis" namespacing to avoid conflicts with > > sentinel :) > > I'm not familiar enough with sentinel to understand this redis-server and redis-sentinel share, for example, the /etc/redis configuration directory. Thus we could not have: ExecStart=/usr/bin/re

Bug#877702: redis-server: Easily run multiple instances with systemd

2017-10-06 Thread Chris Lamb
Hi Adrien, > Modification on the existing systemd service file should be minimal. Indeed, can you try with… --- a/debian/redis-server.service +++ b/debian/redis-server.service @@ -1,12 +1,12 @@ [Unit] -Description=Advanced key-value store +Description=Advanced key-value store (%I)

Bug#877702: redis-server: Easily run multiple instances with systemd

2017-10-04 Thread Adrien CLERC
Package: redis-server Version: 4:4.0.2-2 Severity: wishlist Hi, Since it is recommended to run multiple instances of redis instead of using databases, it could be interesting to be able to run multiple redis instances via systemd instance unit files, such as redis@my_instance.service would laun