Hi Adrien,
> > We need to keep the "redis" namespacing to avoid conflicts with
> > sentinel :)
>
> I'm not familiar enough with sentinel to understand this
redis-server and redis-sentinel share, for example, the /etc/redis
configuration directory. Thus we could not have:
ExecStart=/usr/bin/redis-server /etc/redis/%i.conf
… in our template redis-server@.service, as that could potentially
conflict with a templated redis-sentinel@.service if templated with
the same name.
> If you (or someone) find this seperation desirable, maybe it could be
> integrated into redis-server@.service by changing RuntimeDirectory to
> redis-%i and ReadWriteDirectory accordingly. It is probably a bad idea
> for all users, though.
Most users would be using the non-templated redis-server.service, so
this is of no consequence? ie. we should have a different
RuntimeDirectory for the templated one, no?
Just to be clear, you are also setting RuntimeDirectory=redis-%i or
not? You say you need it, but then you don't include it in your diff...
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
