Bug#514674: audacious: Segfaults when opening ape file

2009-04-12 Thread Luís Picciochi Oliveira
Wow, great! This seems to have fixed it. Thank you a lot for this! Now for everything to be perfect, it's just the cuesheet plugin that needs a bit polishing to *cough*work at all*... But that's another story... Luís Picciochi -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.or

Bug#514674: audacious: Segfaults when opening ape file

2009-04-09 Thread John Lindgren
These patches have been pulled into upstream revision 3031. http://atheme.org/projects/activity/audacious-plugins John Lindgren -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#514674: audacious: Segfaults when opening ape file

2009-03-22 Thread Luís Picciochi Oliveira
The mplayer version I'm using is the one at sid. $ apt-cache policy mplayer mplayer: Installed: 1.0~rc2+svn20090303-3 I would like to try a version of the decoder that skips the bad sections, even if that makes the time display wrong. Do you think we can try that? Luís Picciochi -- To UNSUB

Bug#514674: audacious: Segfaults when opening ape file

2009-03-22 Thread John Lindgren
If you have a version of mplayer which can actually play the bad sections of that file, all I can say is that I want to know how it does it. The squeeze version, which crashes, has code very similar to the existing Audacious code. The sid version adds some fairly simple error handling, which looks

Bug#514674: audacious: Segfaults when opening ape file

2009-03-21 Thread Luís Picciochi Oliveira
hmmm... I don't know how hard it would be to make those changes to the interface, but I'm betting that would be too much of an hassle just because of this issue. I have been analysing the file (I have some more ape files that make this happen, but I'm using this one as a reference for the discussi

Bug#514674: audacious: Segfaults when opening ape file

2009-03-21 Thread John Lindgren
As far as the decoder is concerned, it's pretty easy to skip the bad spots; I played around with doing that. The problem is updating the time display. Normally, the display measures how much audio is actually output, so it falls behind if the decoder skips ahead. It would take some sort of new inte

Bug#514674: audacious: Segfaults when opening ape file

2009-03-21 Thread Luís Picciochi Oliveira
Apparently, what mplayer does is just to skip the corrupted frames. There seems to be no silence, and the track just keeps playing as if there was no error. The only hint about it appears on the terminal, if you start mplayer from there. Do you think that is possible to do here? Or even maybe add

Bug#514674: audacious: Segfaults when opening ape file

2009-03-20 Thread Luís Picciochi Oliveira
Well, despite the terrible noise, this solution is certainly better than letting audacious suddenly die. However, I can't avoid comparing this to mplayer's behaviour, where it just keeps playing without any audible problem. This is what I see when I open such an ape file with the mplayer version cu

Bug#514674: audacious: Segfaults when opening ape file

2009-03-20 Thread John Lindgren
tags 514674 patch thanks I have added some error handling to apedec.c so that Audacious no longer crashes when playing corrupted .ape files (or at least some of them). John --- apedec.0.c 2008-05-23 18:44:19.0 -0400 +++ apedec.c 2009-03-20 09:51:54.0 -0400 @@ -166,16 +166,15 @@ }

Bug#514674: audacious: Segfaults when opening ape file

2009-03-18 Thread John Lindgren
Luis: Can you post a link to that file, if it's available on the internet, or email it to me? (Don't email it to the list; I don't expect Debian would want it on their server.) That would help a lot in debugging this problem. I'm not the maintainer for Audacious, but I've worked with the code some

Bug#514674: audacious: Segfaults when opening ape file

2009-02-09 Thread Luís Picciochi Oliveira
Package: audacious Version: 1.5.1-4 Severity: important When opening some .ape files (encoded with Monkey's Audio codec), audacious segfaults. Not all ape files make audacious fail. In fact, I only found one that does it. This may be caused by the file's curruption, but I found that the file i