On Mon, 7 Jul 2025 02:05:06 GMT, Xiaohong Gong wrote:
>> @XiaohongGong I quickly scanned the patch, it looks good to me too. I'm
>> submitting some internal testing now, to make sure our extended testing does
>> not break on integration. Should take about 24h.
>
> Hi @eme64 , may I ask how the
On Wed, 25 Jun 2025 09:16:48 GMT, Xiaohong Gong wrote:
>> JDK-8318650 introduced hotspot intrinsification of subword gather load APIs
>> for X86 platforms [1]. However, the current implementation is not optimal
>> for AArch64 SVE platform, which natively supports vector instructions for
>> sub
On Wed, 2 Jul 2025 08:24:22 GMT, Emanuel Peter wrote:
>>> Agree with Paul, these are minor regressions. Let us proceed with this
>>> patch.
>>
>> Thanks so much for your review @sviswa7 !
>
> @XiaohongGong I quickly scanned the patch, it looks good to me too. I'm
> submitting some internal tes
On Wed, 2 Jul 2025 01:52:19 GMT, Xiaohong Gong wrote:
>> Agree with Paul, these are minor regressions. Let us proceed with this
>> patch.
>
>> Agree with Paul, these are minor regressions. Let us proceed with this patch.
>
> Thanks so much for your review @sviswa7 !
> @XiaohongGong I quickly
On Wed, 2 Jul 2025 01:52:19 GMT, Xiaohong Gong wrote:
>> Agree with Paul, these are minor regressions. Let us proceed with this
>> patch.
>
>> Agree with Paul, these are minor regressions. Let us proceed with this patch.
>
> Thanks so much for your review @sviswa7 !
@XiaohongGong I quickly sc
On Tue, 1 Jul 2025 21:30:20 GMT, Sandhya Viswanathan
wrote:
> Agree with Paul, these are minor regressions. Let us proceed with this patch.
Thanks so much for your review @sviswa7 !
-
PR Comment: https://git.openjdk.org/jdk/pull/25138#issuecomment-3026080679
On Tue, 1 Jul 2025 18:03:33 GMT, Paul Sandoz wrote:
> This is a nice simplification, Java changes look good. I'll let the Intel
> folks sign-off related to regressions. IMO minor regressions like this are
> acceptable if the generated code quality is good, and if the benchmark
> reports higher
On Wed, 25 Jun 2025 09:16:48 GMT, Xiaohong Gong wrote:
>> JDK-8318650 introduced hotspot intrinsification of subword gather load APIs
>> for X86 platforms [1]. However, the current implementation is not optimal
>> for AArch64 SVE platform, which natively supports vector instructions for
>> sub
On Wed, 25 Jun 2025 09:16:48 GMT, Xiaohong Gong wrote:
>> JDK-8318650 introduced hotspot intrinsification of subword gather load APIs
>> for X86 platforms [1]. However, the current implementation is not optimal
>> for AArch64 SVE platform, which natively supports vector instructions for
>> sub
On Wed, 25 Jun 2025 09:16:48 GMT, Xiaohong Gong wrote:
>> JDK-8318650 introduced hotspot intrinsification of subword gather load APIs
>> for X86 platforms [1]. However, the current implementation is not optimal
>> for AArch64 SVE platform, which natively supports vector instructions for
>> sub
On Tue, 1 Jul 2025 06:41:32 GMT, Xiaohong Gong wrote:
>> Ping again! Thanks in advance!
>
>> @XiaohongGong I'm a little busy at the moment, and soon going on a summer
>> vacation, so I cannot promise a full review soon. Feel free to ask someone
>> else to have a look.
>>
>> I quickly looked th
On Tue, 1 Jul 2025 06:07:03 GMT, Xiaohong Gong wrote:
>> Xiaohong Gong has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Address review comments
>> - Merge 'jdk:master' into JDK-8355563
>> - 8355563: Vector
On Tue, 1 Jul 2025 06:41:32 GMT, Xiaohong Gong wrote:
>> Ping again! Thanks in advance!
>
>> @XiaohongGong I'm a little busy at the moment, and soon going on a summer
>> vacation, so I cannot promise a full review soon. Feel free to ask someone
>> else to have a look.
>>
>> I quickly looked th
On Tue, 1 Jul 2025 06:07:03 GMT, Xiaohong Gong wrote:
>> Xiaohong Gong has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Address review comments
>> - Merge 'jdk:master' into JDK-8355563
>> - 8355563: Vector
On Fri, 9 May 2025 07:35:41 GMT, Xiaohong Gong wrote:
> JDK-8318650 introduced hotspot intrinsification of subword gather load APIs
> for X86 platforms [1]. However, the current implementation is not optimal for
> AArch64 SVE platform, which natively supports vector instructions for subword
>
> JDK-8318650 introduced hotspot intrinsification of subword gather load APIs
> for X86 platforms [1]. However, the current implementation is not optimal for
> AArch64 SVE platform, which natively supports vector instructions for subword
> gather load operations using an int vector for indices (
On Mon, 2 Jun 2025 10:48:25 GMT, Emanuel Peter wrote:
>>> > @XiaohongGong Thanks for splitting this one out, and for investigating
>>> > the regressions here.
>>> > Putting the permalink here, fixed to the current change (the link you
>>> > pasted will always refer to the newest, which may late
On Tue, 3 Jun 2025 01:45:57 GMT, Xiaohong Gong wrote:
>>> > @XiaohongGong Thanks for splitting this one out, and for investigating
>>> > the regressions here.
>>> > Putting the permalink here, fixed to the current change (the link you
>>> > pasted will always refer to the newest, which may late
On Fri, 30 May 2025 08:15:22 GMT, Xiaohong Gong wrote:
>>> @XiaohongGong Thanks for splitting this one out, and for investigating the
>>> regressions here.
>>>
>>> Putting the permalink here, fixed to the current change (the link you
>>> pasted will always refer to the newest, which may later
On Fri, 30 May 2025 08:15:22 GMT, Xiaohong Gong wrote:
>>> @XiaohongGong Thanks for splitting this one out, and for investigating the
>>> regressions here.
>>>
>>> Putting the permalink here, fixed to the current change (the link you
>>> pasted will always refer to the newest, which may later
On Fri, 9 May 2025 07:35:41 GMT, Xiaohong Gong wrote:
> JDK-8318650 introduced hotspot intrinsification of subword gather load APIs
> for X86 platforms [1]. However, the current implementation is not optimal for
> AArch64 SVE platform, which natively supports vector instructions for subword
>
On Tue, 20 May 2025 05:40:04 GMT, Xiaohong Gong wrote:
> > @XiaohongGong Thanks for splitting this one out, and for investigating the
> > regressions here.
> > Putting the permalink here, fixed to the current change (the link you
> > pasted will always refer to the newest, which may later on po
On Mon, 26 May 2025 06:51:12 GMT, Emanuel Peter wrote:
>> JDK-8318650 introduced hotspot intrinsification of subword gather load APIs
>> for X86 platforms [1]. However, the current implementation is not optimal
>> for AArch64 SVE platform, which natively supports vector instructions for
>> sub
On Fri, 9 May 2025 07:35:41 GMT, Xiaohong Gong wrote:
> JDK-8318650 introduced hotspot intrinsification of subword gather load APIs
> for X86 platforms [1]. However, the current implementation is not optimal for
> AArch64 SVE platform, which natively supports vector instructions for subword
>
On Tue, 20 May 2025 02:22:13 GMT, Xiaohong Gong wrote:
>> Ping again~ could any one please take a look at this PR？ Thanks a lot!
>
>> Hi @XiaohongGong , Very nice work!, Looks good to me, will do some testing
>> and get back.
>>
>> Do you have any idea about following regression?
>>
>> ```
>>
On Tue, 20 May 2025 02:22:13 GMT, Xiaohong Gong wrote:
>> Ping again~ could any one please take a look at this PR？ Thanks a lot!
>
>> Hi @XiaohongGong , Very nice work!, Looks good to me, will do some testing
>> and get back.
>>
>> Do you have any idea about following regression?
>>
>> ```
>>
On Mon, 19 May 2025 03:10:46 GMT, Xiaohong Gong wrote:
>> JDK-8318650 introduced hotspot intrinsification of subword gather load APIs
>> for X86 platforms [1]. However, the current implementation is not optimal
>> for AArch64 SVE platform, which natively supports vector instructions for
>> sub
On Mon, 19 May 2025 03:10:46 GMT, Xiaohong Gong wrote:
>> JDK-8318650 introduced hotspot intrinsification of subword gather load APIs
>> for X86 platforms [1]. However, the current implementation is not optimal
>> for AArch64 SVE platform, which natively supports vector instructions for
>> sub
On Fri, 9 May 2025 07:35:41 GMT, Xiaohong Gong wrote:
> JDK-8318650 introduced hotspot intrinsification of subword gather load APIs
> for X86 platforms [1]. However, the current implementation is not optimal for
> AArch64 SVE platform, which natively supports vector instructions for subword
>
On Fri, 9 May 2025 07:35:41 GMT, Xiaohong Gong wrote:
> JDK-8318650 introduced hotspot intrinsification of subword gather load APIs
> for X86 platforms [1]. However, the current implementation is not optimal for
> AArch64 SVE platform, which natively supports vector instructions for subword
>
On Fri, 9 May 2025 07:35:41 GMT, Xiaohong Gong wrote:
> JDK-8318650 introduced hotspot intrinsification of subword gather load APIs
> for X86 platforms [1]. However, the current implementation is not optimal for
> AArch64 SVE platform, which natively supports vector instructions for subword
>
JDK-8318650 introduced hotspot intrinsification of subword gather load APIs for
X86 platforms [1]. However, the current implementation is not optimal for
AArch64 SVE platform, which natively supports vector instructions for subword
gather load operations using an int vector for indices (see [2][
32 matches
Mail list logo
