On Tue, 1 Jul 2025 18:03:33 GMT, Paul Sandoz <psan...@openjdk.org> wrote:
> This is a nice simplification, Java changes look good. I'll let the Intel > folks sign-off related to regressions. IMO minor regressions like this are > acceptable if the generated code quality is good, and if the benchmark > reports higher variance and averaging results from multiple forks close the > gap. (In this case i don't understand how the Java changes impacts alignment). Thanks for your review and comments @PaulSandoz ! The java changes in this patch makes the outer loop in test not be peeled as before since all the range checks or branches are hoisted out side of the loop. While it needs one iteration of loop peeling to eliminate branches before. I think this makes the whole generated code's layout changes a lot. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25138#issuecomment-3026080127
