On Thu, 17 Jul 2025 19:06:25 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/jdk/internal/math/FloatingDecimal.java line 1769:
>>
>>> 1767: * fields (> 550 lines).
>>> 1768: */
>>> 1769: private static BinaryToASCIIConverter
>>> getCompatBinaryToASCIIConverter(doub
On Thu, 17 Jul 2025 12:28:06 GMT, Raffaello Giulietti
wrote:
>> Align the behavior of `DecimalFormat` on `double`s with that of `Formatter`.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Added comment to COMPAT st
On Thu, 17 Jul 2025 16:48:20 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/io/Console.java line 51:
>>
>>> 49: * console. Regardless of how the virtual machine was created, it may
>>> not
>>> 50: * have a console if either the standard input or output stream is
>>> 51: * redirec
On Wed, 16 Jul 2025 13:42:45 GMT, cagliostro92 wrote:
>> src/java.base/share/classes/java/util/Properties.java line 78:
>>
>>> 76: * the call to the {@code propertyNames} or {@code list} method
>>> 77: * will fail if it is called on a "compromised" {@code Properties}
>>> 78: * object that con
On Tue, 20 May 2025 16:03:14 GMT, cagliostro92 wrote:
> Trivial PR to enhance Javadoc for the `Properties#list` method, which has
> cost me some debugging time.
The copyright year for this file should also be updated: `1995, 2025,`
Also, the PR title will need to be changed to,
_8358530: Prop
On Tue, 20 May 2025 16:03:14 GMT, cagliostro92 wrote:
> Trivial PR to enhance Javadoc for the `Properties#list` method, which has
> cost me some debugging time.
It does appear true that a `ClassCastException` is thrown if a value is not a
String for `Properties.list(PrintWriter)` and the behav
On Mon, 14 Jul 2025 22:39:56 GMT, Naoto Sato wrote:
>> This accompanies the fix for
>> [JDK-8361613](https://bugs.openjdk.org/browse/JDK-8361613), which restricts
>> `System.console()` to return a `Console` instance only when both standard
>> input and output are connected to a terminal. The c
On Mon, 14 Jul 2025 17:15:57 GMT, Naoto Sato wrote:
> This accompanies the fix for
> [JDK-8361613](https://bugs.openjdk.org/browse/JDK-8361613), which restricts
> `System.console()` to return a `Console` instance only when both standard
> input and output are connected to a terminal. The chang
On Mon, 14 Jul 2025 19:38:04 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/io/Console.java line 49:
>>
>>> 47: * was launched. If the virtual machine is started automatically, for
>>> 48: * example by a background job scheduler, or if one or both of the
>>> 49: * standard input
On Mon, 14 Jul 2025 17:15:57 GMT, Naoto Sato wrote:
> This accompanies the fix for
> [JDK-8361613](https://bugs.openjdk.org/browse/JDK-8361613), which restricts
> `System.console()` to return a `Console` instance only when both standard
> input and output are connected to a terminal. The chang
On Fri, 11 Jul 2025 22:07:01 GMT, Naoto Sato wrote:
>> In prior JDK releases, `System.console()` could return a `Console` instance
>> even when the JVM was not attached to an interactive terminal. This could
>> lead to confusion, particularly when input was not from a keyboard or output
>> was
On Wed, 9 Jul 2025 18:39:40 GMT, Naoto Sato wrote:
> Replaced Collections.emptyList() with List.of() as part of refactoring. This
> was discussed in the context of investigating a CDS-related issue
> (https://bugs.openjdk.org/browse/JDK-8357281?focusedId=14796714&page=com.atlassian.jira.plugin.
On Fri, 27 Jun 2025 18:27:15 GMT, Alisen Chung wrote:
> 8359761: JDK 25 RDP1 L10n resource files update
Marked as reviewed by jlu (Committer).
-
PR Review: https://git.openjdk.org/jdk/pull/26026#pullrequestreview-2967612181
On Tue, 24 Jun 2025 14:58:38 GMT, Weijun Wang wrote:
>> However, there is no space required between two Chinese sentences. In
>> English, we usually write "I am here, and you are there." But in Chinese,
>> with the full-width punctuation, it's always "我在这里，你在那里。".
>
> Some people like to insert
On Wed, 25 Jun 2025 21:28:16 GMT, Alisen Chung wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the las
On Wed, 25 Jun 2025 17:08:20 GMT, Alisen Chung wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with three additional
> commits since the
On Wed, 25 Jun 2025 00:27:48 GMT, Damon Nguyen wrote:
>> src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties
>> line 49:
>>
>>> 47: .Principal.=\t主用户：\u0020
>>> 48: .Public.Credential.=\t公共身份证明:\u0020
>>> 49: .Private.Credential.=\t专用身份证明:\u0020
>>
>> Why aren't t
On Wed, 18 Jun 2025 15:59:35 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix unicode escapes
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_de.proper
On Wed, 18 Jun 2025 15:52:15 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix unicode escapes
>
> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/resources/jarsigner_de.properties
>
On Wed, 18 Jun 2025 18:48:04 GMT, Damon Nguyen wrote:
>> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java
>> line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2001, 2023, Oracle and/or its affiliates. All rights
>>> reserved.
>>
>> Looks wrong but is correct. File had
On Mon, 9 Jun 2025 20:42:43 GMT, Justin Lu wrote:
> Please review this PR which finishes Applet removal for the test:
> jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
>
> `testclasses.jar` is updated such that the two classes no longer extend
> Applet.
>
>
On Tue, 17 Jun 2025 21:47:49 GMT, Justin Lu wrote:
>> Please review this PR which finishes Applet removal for the test:
>> jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
>>
>> `testclasses.jar` is updated such that the two classes no longer extend
>>
On Wed, 18 Jun 2025 15:34:38 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix unicode escapes
>
> src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 1:
>
>> 1: # Copyright (c)
On Wed, 18 Jun 2025 15:28:49 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix unicode escapes
>
> src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties
> line 56:
On Tue, 17 Jun 2025 01:22:31 GMT, Alisen Chung wrote:
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK since the previous L10n drop.
src/java.base/share/classes/sun/security/tools/keytool/resources/keytool_de.properties
line 30:
> 28:
On Tue, 17 Jun 2025 01:22:31 GMT, Alisen Chung wrote:
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK since the previous L10n drop.
src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_de.properties
line 2:
> 1: #
> 2:
On Tue, 17 Jun 2025 08:16:15 GMT, Johannes Döbler wrote:
> I am still wondering what this (old) test tries to proof. It is filed below
> jdk.onternal.loader.URLClassPath but doesn't use or test URLClassPath, and it
> succeeds to construct a Class with an invalid name "fo o".
URLClassPath is us
se classes.
>
> Additionally, the security APIs that were marked for removal are also removed
> from this test as well.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
SB -> String
-
Changes:
- all: https://git
On Fri, 13 Jun 2025 19:34:40 GMT, Johannes Graham wrote:
>> Ah got it, I see your point. We would have goten underflow in
>> `ASCIIToBinaryConverter.doubleValue()` for some extreme cases without a
>> check.
>>
>> Is there a specific example you have that requires the switch to the newer
>> c
On Fri, 13 Jun 2025 20:56:49 GMT, Johannes Döbler wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review - Convert to JUnit, correct comment typo, remove 'Infra'
>>
se classes.
>
> Additionally, the security APIs that were marked for removal are also removed
> from this test as well.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Review suggestion - read class file from memory
se classes.
>
> Additionally, the security APIs that were marked for removal are also removed
> from this test as well.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Address review - Convert to JUnit, correct comment typo, remove
On Thu, 12 Jun 2025 21:42:26 GMT, Lance Andersen wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address offline review -> comments for maintainers, simplify exc and
>> JAR_PATH
On Thu, 12 Jun 2025 15:26:55 GMT, Johannes Graham wrote:
>> src/java.base/share/classes/jdk/internal/math/FloatingDecimal.java line 1841:
>>
>>> 1839:
>>> 1840: static ASCIIToBinaryConverter readDoubleSignlessDigits(int
>>> decExp, char[] digits, int length) {
>>> 1841: if (decExp
se classes.
>
> Additionally, the security APIs that were marked for removal are also removed
> from this test as well.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Address offline review -> comments for maintainers, simpli
On Thu, 12 Jun 2025 15:14:37 GMT, Jaikiran Pai wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Jai's review - dynamically create jar file
>
> test/jdk/jdk/internal/loader/URLClass
se classes.
>
> Additionally, the security APIs that were marked for removal are also removed
> from this test as well.
Justin Lu has updated the pull request incrementally with two additional
commits since the last revision:
- removing a typo
- Jai's review - Cleanup & JAR_P
On Wed, 11 Jun 2025 22:39:48 GMT, Stuart Marks wrote:
> Add a note to String.trim pointing to the String.strip family of methods.
>
> Add notes cross-linking String.isBlank and String.isEmpty.
src/java.base/share/classes/java/lang/String.java line 3937:
> 3935:
> 3936: /**
> 3937: *
On Mon, 9 Jun 2025 23:44:20 GMT, Justin Lu wrote:
>> Johannes Graham has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> catch ArithmeticException
>
> src/java.base/share/classes/jdk/internal/math/FloatingDeci
On Tue, 10 Jun 2025 15:41:47 GMT, Johannes Graham wrote:
>> This PR replaces construction of intermediate strings to be parsed with more
>> direct manipulation of numbers. It also has a more streamlined mechanism of
>> handling `Long.MIN_VALUE` when parsing longs by using
>> `Long.parseUnsigne
se classes.
>
> Additionally, the security APIs that were marked for removal are also removed
> from this test as well.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Jai's review - dynamically create jar file
---
On Mon, 9 Jun 2025 20:42:43 GMT, Justin Lu wrote:
> Please review this PR which finishes Applet removal for the test:
> jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
>
> `testclasses.jar` is updated such that the two classes no longer extend
> Applet.
>
>
On Mon, 9 Jun 2025 20:42:43 GMT, Justin Lu wrote:
> Please review this PR which finishes Applet removal for the test:
> jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
>
> `testclasses.jar` is updated such that the two classes no longer extend
> Applet.
>
>
On Tue, 10 Jun 2025 18:36:15 GMT, Naoto Sato wrote:
> This regression was introduced by the removal of the COMPAT locale provider,
> which partially broke support for the first year in the Japanese calendar. In
> the Japanese calendar system, the first year of an era should be formatted
> usin
On Mon, 9 Jun 2025 22:46:50 GMT, Johannes Graham wrote:
>> This PR replaces construction of intermediate strings to be parsed with more
>> direct manipulation of numbers. It also has a more streamlined mechanism of
>> handling `Long.MIN_VALUE` when parsing longs by using
>> `Long.parseUnsigned
On Mon, 9 Jun 2025 20:07:53 GMT, Naoto Sato wrote:
>> The parallel loading of JavaTimeSupplementary was a historical artifact from
>> the introduction of JSR 310, which additionally loads resouces that had not
>> existed before. Since the COMPAT locale provider which relied on this
>> mechanis
On Thu, 5 Jun 2025 20:29:48 GMT, Justin Lu wrote:
>> Please review this PR which improves occurrences of lazy computation in
>> `Locale` and `BaseLocale`.
>>
>> Existing lazy initialization strategies such as CHM, static nested class,
>> and local inner class a
On Sat, 7 Jun 2025 17:36:40 GMT, Johannes Graham wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review - Moving all ISO resources to LocaleISOData & blessed modifier
>> order for l
On Wed, 4 Jun 2025 21:20:46 GMT, Justin Lu wrote:
> Please review this PR which improves occurrences of lazy computation in
> `Locale` and `BaseLocale`.
>
> Existing lazy initialization strategies such as CHM, static nested class, and
> local inner class are replaced wit
Please review this PR which finishes Applet removal for the test:
jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
`testclasses.jar` is updated such that the two classes no longer extend Applet.
$ javap fo\ o.class
public class fo o {
}
$ javap æ$'\302\211'$'\302\213'å$'\302\206'$'\302
On Tue, 3 Jun 2025 20:14:31 GMT, Per Minborg wrote:
> This PR proposes to simplify lazy computation related to resource bundles.
> Previously, some objects were computed lazily using a double-checked locking
> algorithm. StableValues offers a more robust and succinct solution.
>
>
> This P
On Tue, 3 Jun 2025 20:14:31 GMT, Per Minborg wrote:
> This PR proposes to simplify lazy computation related to resource bundles.
> Previously, some objects were computed lazily using a double-checked locking
> algorithm. StableValues offers a more robust and succinct solution.
>
>
> This P
represented as a SV. Also, I did not think it was necessary to maintain a
> SV for _both_ the array and set of ISO3166-1 alpha-2 codes.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
review - Moving all ISO resources to Loca
On Thu, 5 Jun 2025 11:50:01 GMT, Johannes Döbler wrote:
>> Please review this PR which improves occurrences of lazy computation in
>> `Locale` and `BaseLocale`.
>>
>> Existing lazy initialization strategies such as CHM, static nested class,
>> and local inner class are replaced with Stable Val
Please review this PR which improves occurrences of lazy computation in
`Locale` and `BaseLocale`.
Existing lazy initialization strategies such as CHM, static nested class, and
local inner class are replaced with Stable Values.
Lambda usage is intentionally avoided in this change during `Locale
On Tue, 3 Jun 2025 16:47:20 GMT, Justin Lu wrote:
> Please review this PR which modifies the
> test/jdk/java/util/TimeZone/Bug8167143.java "testCompat" case to be
> repurposed to check the implicit locales for the FALLBACK BreakIterator and
> Collator providers. (F
On Tue, 3 Jun 2025 17:13:45 GMT, Justin Lu wrote:
> Please review this trivial doc correction to
> `Locale.getISOCountries(Locale.IsoCountryCode type)` which makes it apparent
> that the returned Set is unmodifiable. Associated CSR filed.
This pull request has now been integrated.
On Tue, 3 Jun 2025 16:59:18 GMT, Naoto Sato wrote:
>> Fixing a regression caused by the fix to JDK-8356985. Although the fix in
>> `CharsetTest` was a clean-up and not the gist of the original issue, the
>> change seem to have caused not finding `SkippedException` at runtime in
>> certain case
On Tue, 3 Jun 2025 18:17:17 GMT, Naoto Sato wrote:
>> Please review this trivial doc correction to
>> `Locale.getISOCountries(Locale.IsoCountryCode type)` which makes it apparent
>> that the returned Set is unmodifiable. Associated CSR filed.
>
> Looks good. Reviewed the CSR too, but not sure i
On Tue, 3 Jun 2025 17:40:19 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review - var rename
>
> test/jdk/java/util/TimeZone/Bug8167143.java line 239:
>
>>
Since
> the method is corrected, it can be re-added as a test case. This change stems
> from discussion in https://git.openjdk.org/jdk/pull/25532.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
review - var rename
--
Please review this trivial doc correction to
`Locale.getISOCountries(Locale.IsoCountryCode type)` which makes it apparent
that the returned Set is unmodifiable. Associated CSR filed.
-
Commit messages:
- init
Changes: https://git.openjdk.org/jdk/pull/25622/files
Webrev: https://
Please review this PR which modifies the
test/jdk/java/util/TimeZone/Bug8167143.java "testCompat" case to be repurposed
to check the implicit locales for the FALLBACK BreakIterator and Collator
providers. (FALLBACK is the primary provider in those cases.) Since the method
is corrected, it can b
On Fri, 30 May 2025 17:02:12 GMT, Justin Lu wrote:
>> Please review this PR which cleans up some i18n tests.
>>
>> There are some i18n related tests that set the locale provider to CLDR (and
>> only CLDR). Since JDK9, this is redundant and equivalent to the default.
On Thu, 29 May 2025 21:59:30 GMT, Justin Lu wrote:
> Please review this PR which cleans up some i18n tests.
>
> There are some i18n related tests that set the locale provider to CLDR (and
> only CLDR). Since JDK9, this is redundant and equivalent to the default.
> Thus,
On Thu, 29 May 2025 19:01:04 GMT, Justin Lu wrote:
> Please review this PR which removes the test tool `GenerateKeyList.java`
> after the COMPAT locale data removal.
>
> `LocaleDataTest.java` may optionally use the `GenerateKeyList.java` tool.
> However, this tool is manual
On Fri, 30 May 2025 00:41:12 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> re-add testCompat to Bug8167143.java
>
> test/jdk/java/util/TimeZone/Bug8167143.java line 10
are just extra noise for
> these tests.
>
> As this change is trivial cleanup, bug IDs are not updated in this change.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
re-add testCompat to Bug8167143.java
-
Changes
are just extra noise for
> these tests.
>
> As this change is trivial cleanup, bug IDs are not updated in this change.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
reflect review: strip othervm mode + cleanup
On Thu, 29 May 2025 22:47:11 GMT, Naoto Sato wrote:
>> Please review this PR which cleans up some i18n tests.
>>
>> There are some i18n related tests that set the locale provider to CLDR (and
>> only CLDR). Since JDK9, this is redundant and equivalent to the default.
>> Thus, occurrences of "-
Please review this PR which cleans up some i18n tests.
There are some i18n related tests that set the locale provider to CLDR (and
only CLDR). Since JDK9, this is redundant and equivalent to the default. Thus,
occurrences of "-Djava.locale.providers=CLDR" are just extra noise for these
tests.
On Thu, 29 May 2025 21:15:57 GMT, Justin Lu wrote:
>> Please review this PR which removes the test tool `GenerateKeyList.java`
>> after the COMPAT locale data removal.
>>
>> `LocaleDataTest.java` may optionally use the `GenerateKeyList.java` tool.
>> However,
There is no longer any point to keep it, and it can always be retrieved via
> the VCS if needed.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
reflect some corrections
-
Changes:
- all: https://git.openjdk.org/jdk/pul
Please review this PR which updates the test tool `GenerateKeyList.java` after
the COMPAT locale data removal.
`LocaleDataTest.java` may optionally use the `GenerateKeyList.java` tool; the
latter requires similar bundle name changes that were made to the former in
https://bugs.openjdk.org/brows
On Wed, 28 May 2025 17:00:22 GMT, Justin Lu wrote:
> Please review this PR which updates the language subtag registry to Version
> 2025-05-15.
>
> LanguageSubtagRegistryTest.java was updated with the preferred-values: `hnm`,
> `eko`, `luh`,`sjc`, `sqm`. A small change was a
On Thu, 29 May 2025 17:20:12 GMT, Naoto Sato wrote:
> Test refactoring stemmed from the discussion at
> https://git.openjdk.org/jdk/pull/25228#discussion_r2106755160. The test is
> now based on UTF-8 instead of ISO-8859-1
Test change looks good. Skimmed the data change, which also looks to be
On Mon, 19 May 2025 20:56:55 GMT, Justin Lu wrote:
> It is not clear that `Locale.Builder.setLanguageTag(String)` accepts
> _extlang_ subtags in the input as well as what behavior occurs. Additionally,
> both this method and `Locale.forLanguageTag(String)` should mention their
> b
On Wed, 28 May 2025 17:00:22 GMT, Justin Lu wrote:
> Please review this PR which updates the language subtag registry to Version
> 2025-05-15.
>
> LanguageSubtagRegistryTest.java was updated with the preferred-values: `hnm`,
> `eko`, `luh`,`sjc`, `sqm`. A small change was a
Please review this PR which updates the language subtag registry to Version
2025-05-15.
LanguageSubtagRegistryTest.java was updated with the preferred-values: `hnm`,
`eko`, `luh`,`sjc`, `sqm`. A small change was also made to the test to improve
the output as well.
-
Commit message
On Sun, 18 May 2025 11:11:32 GMT, Shaojin Wen wrote:
> When debugging getLong/getDouble/getDecimal of DigitList, the debugger will
> call the DigitList::toString method. At this time, DigitList::toString will
> modify tempBuilder, which will cause incorrect results.
Change looks good to me, si
On Mon, 26 May 2025 08:25:30 GMT, Magnus Ihse Bursie wrote:
>> After we converted the source base to be fully UTF-8, we do not need to use
>> unicode sequences (like \u0123) in string literals. Sometimes, that might
>> still make sense, as for control characters, non-breaking space, etc. But
>
On Wed, 21 May 2025 21:19:36 GMT, Justin Lu wrote:
> _sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data
> carrier for Locale. The class, once created is not modified; the class should
> be made immutable. Converting the class to a record accomplishes this an
On Thu, 22 May 2025 17:51:32 GMT, Justin Lu wrote:
>> _sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data
>> carrier for Locale. The class, once created is not modified; the class
>> should be made immutable. Converting the class to a record accomplishes
On Thu, 22 May 2025 17:46:33 GMT, Naoto Sato wrote:
>> `java.io.Console` uses the charset specified by the `stdout.encoding` system
>> property for both input and output. While this is generally sufficient,
>> since Console is intended for interactive terminal use, some platforms allow
>> diff
> _sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data
> carrier for Locale. The class, once created is not modified; the class should
> be made immutable. Converting the class to a record accomplishes this and
> also simplifies some of the existing code.
J
On Thu, 22 May 2025 17:14:03 GMT, Chen Liang wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review: subtag -> subtags, switch on baseLang, improve fragility of list
>> field
On Wed, 21 May 2025 21:19:36 GMT, Justin Lu wrote:
> _sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data
> carrier for Locale. The class, once created is not modified; the class should
> be made immutable. Converting the class to a record accomplishes this an
> _sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data
> carrier for Locale. The class, once created is not modified; the class should
> be made immutable. Converting the class to a record accomplishes this and
> also simplifies some of the existing code.
J
_sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data carrier
for Locale. The class, once created is not modified; the class should be made
immutable. Converting the class to a record accomplishes this and also
simplifies some of the existing code.
-
Commit message
On Wed, 21 May 2025 16:54:22 GMT, Naoto Sato wrote:
>> Actually providing mock charset was a workaround of not having public method
>> for getting the input encoding. I think it would be an overkill to introduce
>> a new public method because it will not be used much, as most cases are
>> suff
ovided. This PR
> clarifies the lack of context in the specification.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
CSR review - clarify that 3 extlang subtags is not a JDK specific condition
-
Changes:
On Tue, 20 May 2025 21:57:45 GMT, Naoto Sato wrote:
>> `java.io.Console` uses the charset specified by the `stdout.encoding` system
>> property for both input and output. While this is generally sufficient,
>> since Console is intended for interactive terminal use, some platforms allow
>> diff
On Tue, 20 May 2025 23:02:45 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> setLanguageTag should mention all conversions, not just extlang
>
> src/java.base/share/clas
ovided. This PR
> clarifies the lack of context in the specification.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
adjust example wording
-
Changes:
- all: https://git.openjdk.org/jdk/pull/25309/files
On Tue, 20 May 2025 00:39:16 GMT, Naoto Sato wrote:
>> An exception is thrown when more than three extlang subtags are provided
>> (ill-formed). The new wording is when an allowed amount of extlang subtags
>> are provided (not ill-formed). For example,
>>
>> `new Locale.Builder().setLanguageTa
ovided. This PR
> clarifies the lack of context in the specification.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
setLanguageTag should mention all conversions, not just extlang
-
Changes:
- all: https://git.openj
On Mon, 19 May 2025 23:41:25 GMT, Naoto Sato wrote:
>> It is not clear that `Locale.Builder.setLanguageTag(String)` accepts
>> _extlang_ subtags in the input as well as what behavior occurs.
>> Additionally, both this method and `Locale.forLanguageTag(String)` should
>> mention their behavior
It is not clear that `Locale.Builder.setLanguageTag(String)` accepts _extlang_
subtags in the input as well as what behavior occurs. Additionally, both this
method and `Locale.forLanguageTag(String)` should mention their behavior when
more than three _extlang_ subtags are provided. This PR clari
On Thu, 15 May 2025 19:31:45 GMT, Naoto Sato wrote:
> Removing now-defunct COMPAT locale provider tests.
Nice cleanup; lgtm
test/jdk/sun/text/resources/LocaleDataTest.java line 178:
> 176: public class LocaleDataTest
> 177: {
> 178: static final String TEXT_RESOURCES_PACKAGE
> ="sun.text.
On Sun, 11 May 2025 08:42:41 GMT, Abhishek N wrote:
>> Create a Test case to have special cases coverage for currency.getInstance().
>>
>> The test Validates that all currency codes and country-currency mappings in
>> the input file are consistent with the Java Currency API.
>>
>> test results
1 - 100 of 1237 matches
Mail list logo
