On Thu, 22 May 2025 17:14:03 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> review: subtag -> subtags, switch on baseLang, improve fragility of list >> field accessors > > src/java.base/share/classes/sun/util/locale/LanguageTag.java line 249: > >> 247: return EMPTY_SUBTAGS; >> 248: } >> 249: List<String> extLangs = null; > > Do we want to name this `extLangs` or `extlangs`? The parsing method and the > record uses `extlangs`. Changed to `extlangs`, more consistent. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25371#discussion_r2103105426
