Re: RFR: 8360884: Better scoped values [v4]

2025-07-01 Thread ExE Boss
On Tue, 1 Jul 2025 15:41:45 GMT, Alan Bateman wrote: >> Andrew Haley has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8360884: Better scoped values >> - 8360884: Better scoped values > > src/java.base/share/classes/java/lang/ScopedValu

Re: RFR: 8360163: Create annotations to mark dumping method handles and runtime setup required classes [v5]

2025-07-01 Thread Ioi Lam
On Tue, 1 Jul 2025 23:20:59 GMT, Chen Liang wrote: >> I have updated this patch to avoid a redundant `runtimeSetup` annotation - >> we have agreed that the requirement for setup is a side effect of >> initialization, and such methods in AOTCI classes must be automatically >> recognized. This l

Re: [jdk25] RFR: 8359337: XML/JAXP tests that make network connections should ensure that no proxy is selected

2025-07-01 Thread Jaikiran Pai
On Tue, 1 Jul 2025 11:48:30 GMT, Jaikiran Pai wrote: > Can I please get a review of this backport of a test-only fix? > > This backports the fix for https://bugs.openjdk.org/browse/JDK-8359337 into > JDK 25. The original fix was integrated into mainline a few minutes back > https://github.com

Re: RFR: 8359419: AArch64: Relax min vector length to 32-bit for short vectors

2025-07-01 Thread Xiaohong Gong
On Tue, 1 Jul 2025 05:59:15 GMT, Xiaohong Gong wrote: > ### Background > On AArch64, the minimum vector length supported is 64-bit for basic types, > except for `byte` and `boolean` (32-bit and 16-bit respectively to match > special Vector API features). This limitation prevents intrinsificatio

Re: Could ByteOrder be turned into an enum?

2025-07-01 Thread Chen Liang
Indeed, given that ByteOrder is more widely used and appears in many other APIs like FFM, it would be quite helpful to modernize it. There are other eligible candidates like CodingErrorAction, but their usages are more restricted to Buffer itself. On Tue, Jul 1, 2025 at 11:15 AM Rob Spoor wrote:

Re: RFR: 8359419: AArch64: Relax min vector length to 32-bit for short vectors [v2]

2025-07-01 Thread Xiaohong Gong
> ### Background > On AArch64, the minimum vector length supported is 64-bit for basic types, > except for `byte` and `boolean` (32-bit and 16-bit respectively to match > special Vector API features). This limitation prevents intrinsification of > vector type conversions between `short` and wide

Re: RFR: 8355563: VectorAPI: Refactor current implementation of subword gather load API [v2]

2025-07-01 Thread Xiaohong Gong
On Tue, 1 Jul 2025 21:30:20 GMT, Sandhya Viswanathan wrote: > Agree with Paul, these are minor regressions. Let us proceed with this patch. Thanks so much for your review @sviswa7 ! - PR Comment: https://git.openjdk.org/jdk/pull/25138#issuecomment-3026080679

Re: RFR: 8355563: VectorAPI: Refactor current implementation of subword gather load API [v2]

2025-07-01 Thread Xiaohong Gong
On Tue, 1 Jul 2025 18:03:33 GMT, Paul Sandoz wrote: > This is a nice simplification, Java changes look good. I'll let the Intel > folks sign-off related to regressions. IMO minor regressions like this are > acceptable if the generated code quality is good, and if the benchmark > reports higher

[jdk25] Integrated: 8359337: XML/JAXP tests that make network connections should ensure that no proxy is selected

2025-07-01 Thread Jaikiran Pai
On Tue, 1 Jul 2025 11:48:30 GMT, Jaikiran Pai wrote: > Can I please get a review of this backport of a test-only fix? > > This backports the fix for https://bugs.openjdk.org/browse/JDK-8359337 into > JDK 25. The original fix was integrated into mainline a few minutes back > https://github.com

RFR: 8360555: Archive all unnamed modules in CDS full module graph

2025-07-01 Thread Ioi Lam
The CDS full module graph is supposed to contain a snapshot of the boot layer, which has 3 unnamed modules for the boot, platform and system class loaders. Each unnamed module is represented by a `java.lang.Module` Java object and a `ModuleEntry` C++ object. Currently, we archive only the `java

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v15]

2025-07-01 Thread Brian Burkhalter
> This proposed change would move the native objects required for NIO file > interaction from the libnio native library to the libjava native library on > Linux, macOS, and Windows. Brian Burkhalter has updated the pull request with a new target base due to a merge or a rebase. The pull request

Re: RFR: 8360163: Create annotations to mark dumping method handles and runtime setup required classes [v4]

2025-07-01 Thread Chen Liang
On Tue, 1 Jul 2025 23:03:32 GMT, Chen Liang wrote: >> I have updated this patch to avoid a redundant `runtimeSetup` annotation - >> we have agreed that the requirement for setup is a side effect of >> initialization, and such methods in AOTCI classes must be automatically >> recognized. This l

Re: RFR: 8360163: Create annotations to mark dumping method handles and runtime setup required classes [v5]

2025-07-01 Thread Chen Liang
> I have updated this patch to avoid a redundant `runtimeSetup` annotation - we > have agreed that the requirement for setup is a side effect of > initialization, and such methods in AOTCI classes must be automatically > recognized. This latest revision implements that model. > > I intentionall

Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines [v9]

2025-07-01 Thread Brian Burkhalter
On Tue, 1 Jul 2025 15:10:10 GMT, Brian Burkhalter wrote: >> src/java.base/share/classes/java/io/Reader.java line 482: >> >>> 480: if (pos == limit) { >>> 481: int len = limit - start; >>> 482: if (len >= cb.length) { >> >> Observation: thi

Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines [v10]

2025-07-01 Thread Brian Burkhalter
> Replaces the implementation `readAllCharsAsString().lines().toList()` with > reading into a temporary `char` array which is then processed to detect line > terminators and copy non-terminating characters into strings which are added > to the list. Brian Burkhalter has updated the pull request

Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines [v9]

2025-07-01 Thread Brian Burkhalter
On Tue, 1 Jul 2025 19:17:17 GMT, Roger Riggs wrote: >> With this change >> >> --- a/test/jdk/java/io/Reader/ReadAll.java >> +++ b/test/jdk/java/io/Reader/ReadAll.java >> @@ -115,6 +115,8 @@ public static void setup() throws IOException { >> sb.setLength(0); >> } >> >> +

Re: RFR: 8360163: Create annotations to mark dumping method handles and runtime setup required classes [v4]

2025-07-01 Thread Chen Liang
> I have updated this patch to avoid a redundant `runtimeSetup` annotation - we > have agreed that the requirement for setup is a side effect of > initialization, and such methods in AOTCI classes must be automatically > recognized. This latest revision implements that model. > > I intentionall

Re: RFR: 8354872: Clarify java.lang.Process resource cleanup [v3]

2025-07-01 Thread Roger Riggs
> Improve the documentation of Process use of system resources. > > Describe the implementation closing streams when no longer referenced. > Clarify the interactions between inputStream and inputReader and errorStream > and errorReader. > Add advice and example using try-with-resources to open an

Re: RFR: 8354872: Clarify java.lang.Process resource cleanup [v2]

2025-07-01 Thread Roger Riggs
On Fri, 27 Jun 2025 19:06:22 GMT, Roger Riggs wrote: >> Improve the documentation of Process use of system resources. >> >> Describe the implementation closing streams when no longer referenced. >> Clarify the interactions between inputStream and inputReader and errorStream >> and errorReader.

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer away from jdk.internal.ref.Cleaner [v7]

2025-07-01 Thread Roger Riggs
On Sun, 29 Jun 2025 20:43:56 GMT, Kim Barrett wrote: >> This change makes java.nio no longer use jdk.internal.ref.Cleaner to manage >> native memory for Direct-X-Buffers. Instead it uses bespoke PhantomReferences >> and a dedicated ReferenceQueue. This differs from PR 22165, which proposed to >>

Re: RFR: 8360037: Refactor ImageReader in preparation for Valhalla support [v3]

2025-07-01 Thread David Beaumont
> Refactoring `ImageReader` to make it easy to add preview mode functionality > for Valhalla. > > This PR is a large change to `ImageReader` (effectively a rewrite) but > reduces the surface area of the API significantly, reduces code complexity > and increases performance/memory efficiency. Th

Re: RFR: 8355563: VectorAPI: Refactor current implementation of subword gather load API [v2]

2025-07-01 Thread Sandhya Viswanathan
On Wed, 25 Jun 2025 09:16:48 GMT, Xiaohong Gong wrote: >> JDK-8318650 introduced hotspot intrinsification of subword gather load APIs >> for X86 platforms [1]. However, the current implementation is not optimal >> for AArch64 SVE platform, which natively supports vector instructions for >> sub

Re: RFR: 8334015: Add Support for UUID Version 7 (UUIDv7) defined in RFC 9562 [v10]

2025-07-01 Thread Jaikiran Pai
On Mon, 30 Jun 2025 18:19:30 GMT, Kieran Farrell wrote: >> With the recent approval of UUIDv7 >> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new >> static method UUID.timestampUUID() which constructs and returns a UUID in >> support of the new time generated UUID version

Re: RFR: 8360037: Refactor ImageReader in preparation for Valhalla support [v2]

2025-07-01 Thread David Beaumont
On Tue, 1 Jul 2025 18:45:49 GMT, Roger Riggs wrote: >> test/jdk/jdk/internal/jimage/ImageReaderTest.java line 78: >> >>> 76: >>> 77: @Test >>> 78: public void testModuleDirectories() throws IOException { >> >> I could make these more data driven (i.e. parametrized) if people want. > >

Re: RFR: 8360037: Refactor ImageReader in preparation for Valhalla support [v2]

2025-07-01 Thread David Beaumont
On Tue, 1 Jul 2025 19:54:10 GMT, David Beaumont wrote: >> src/java.base/share/classes/jdk/internal/module/SystemModuleFinders.java >> line 456: >> >>> 454: Optional node = >>> Optional.ofNullable(reader.findNode(nodeName)); >>> 455: if (node.isPresent() && !node.get().i

Re: RFR: 8360037: Refactor ImageReader in preparation for Valhalla support [v2]

2025-07-01 Thread David Beaumont
On Tue, 1 Jul 2025 14:29:28 GMT, Alan Bateman wrote: >> David Beaumont has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updates based on feedback. > > src/java.base/share/classes/jdk/internal/module/SystemModuleFinders.java line > 62: >

Re: RFR: 8360037: Refactor ImageReader in preparation for Valhalla support [v2]

2025-07-01 Thread David Beaumont
> Refactoring `ImageReader` to make it easy to add preview mode functionality > for Valhalla. > > This PR is a large change to `ImageReader` (effectively a rewrite) but > reduces the surface area of the API significantly, reduces code complexity > and increases performance/memory efficiency. Th

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-07-01 Thread Daniel Jeliński
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

Re: RFR: 8360037: Refactor ImageReader in preparation for Valhalla support

2025-07-01 Thread David Beaumont
On Tue, 1 Jul 2025 14:37:50 GMT, Alan Bateman wrote: >> Refactoring `ImageReader` to make it easy to add preview mode functionality >> for Valhalla. >> >> This PR is a large change to `ImageReader` (effectively a rewrite) but >> reduces the surface area of the API significantly, reduces code c

Re: RFR: 8360037: Refactor ImageReader in preparation for Valhalla support

2025-07-01 Thread David Beaumont
On Tue, 1 Jul 2025 18:38:26 GMT, Roger Riggs wrote: >> Refactoring `ImageReader` to make it easy to add preview mode functionality >> for Valhalla. >> >> This PR is a large change to `ImageReader` (effectively a rewrite) but >> reduces the surface area of the API significantly, reduces code co

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-07-01 Thread Daniel Jeliński
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

Re: RFR: 8361018: Re-examine buffering and encoding conversion in BufferedWriter [v6]

2025-07-01 Thread Xueming Shen
On Tue, 1 Jul 2025 14:33:34 GMT, Brett Okken wrote: > StreamEncoder/CharsetEncoder that is really forcing that - and the > conversion to utf-16 is required for optimal encoder performance. It might be worth exploring the idea of using string-buffer as the buffer to carry the byte[] + coder (d

Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines [v9]

2025-07-01 Thread Roger Riggs
On Tue, 1 Jul 2025 16:34:51 GMT, Brian Burkhalter wrote: >> I don't know, but I doubt it. I will look into adding something. > > With this change > > --- a/test/jdk/java/io/Reader/ReadAll.java > +++ b/test/jdk/java/io/Reader/ReadAll.java > @@ -115,6 +115,8 @@ public static void setup() throws IO

Re: RFR: 8360037: Refactor ImageReader in preparation for Valhalla support

2025-07-01 Thread Roger Riggs
On Tue, 1 Jul 2025 14:02:11 GMT, David Beaumont wrote: >> Refactoring `ImageReader` to make it easy to add preview mode functionality >> for Valhalla. >> >> This PR is a large change to `ImageReader` (effectively a rewrite) but >> reduces the surface area of the API significantly, reduces code

Re: [External] : Re: jpackage: Support building native Windows MSIs

2025-07-01 Thread Alexey Semenyuk
Hi Armin, Create a PR. If you haven't signed the OCA yet, it will ask you to do so. After that, we will proceed with the review. - Alexey On 7/1/2025 2:46 PM, Armin Schrenk wrote: Great, thank you. I created a ticket in the issue tracker, see https://bugs.openjdk.org/browse/JDK-8361207

Re: RFR: 8360037: Refactor ImageReader in preparation for Valhalla support

2025-07-01 Thread Roger Riggs
On Mon, 30 Jun 2025 23:27:49 GMT, David Beaumont wrote: > Refactoring `ImageReader` to make it easy to add preview mode functionality > for Valhalla. > > This PR is a large change to `ImageReader` (effectively a rewrite) but > reduces the surface area of the API significantly, reduces code com

Re: [External] : Re: jpackage: Support building native Windows MSIs

2025-07-01 Thread Armin Schrenk
Great, thank you. I created a ticket in the issue tracker, see https://bugs.openjdk.org/browse/JDK-8361207 .  The sanity checks already finished with success. Are there more steps needed/any requirements or can i create the PR now (after a rebase (-;) ? Best regards, Armin Am Montag, Juni 30,

Re: RFR: 8355563: VectorAPI: Refactor current implementation of subword gather load API [v2]

2025-07-01 Thread Paul Sandoz
On Wed, 25 Jun 2025 09:16:48 GMT, Xiaohong Gong wrote: >> JDK-8318650 introduced hotspot intrinsification of subword gather load APIs >> for X86 platforms [1]. However, the current implementation is not optimal >> for AArch64 SVE platform, which natively supports vector instructions for >> sub

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v4]

2025-07-01 Thread David Beaumont
> Initial benchmark to capture at least some comparative measures of > ImageReader performance. > > Current results on my laptop: > > Benchmark Mode Cnt ScoreError > Units > NewImageBenchmark.warmCache_CountAllNodes avgt5 0.785 ± 0.

Re: RFR: 8334015: Add Support for UUID Version 7 (UUIDv7) defined in RFC 9562 [v10]

2025-07-01 Thread Jaikiran Pai
On Mon, 30 Jun 2025 18:19:30 GMT, Kieran Farrell wrote: >> With the recent approval of UUIDv7 >> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new >> static method UUID.timestampUUID() which constructs and returns a UUID in >> support of the new time generated UUID version

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v3]

2025-07-01 Thread David Beaumont
On Tue, 1 Jul 2025 07:25:35 GMT, Alan Bateman wrote: >> David Beaumont has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Some tidying up relating to the state objects. > > test/micro/org/openjdk/bench/jdk/internal/jrtfs/ImageReaderBenchmar

Re: [jdk25] RFR: 8359337: XML/JAXP tests that make network connections should ensure that no proxy is selected

2025-07-01 Thread Joe Wang
On Tue, 1 Jul 2025 11:48:30 GMT, Jaikiran Pai wrote: > Can I please get a review of this backport of a test-only fix? > > This backports the fix for https://bugs.openjdk.org/browse/JDK-8359337 into > JDK 25. The original fix was integrated into mainline a few minutes back > https://github.com

Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines [v9]

2025-07-01 Thread Brian Burkhalter
On Tue, 1 Jul 2025 15:10:33 GMT, Brian Burkhalter wrote: >> test/jdk/java/io/Reader/ReadAll.java line 117: >> >>> 115: sb.setLength(0); >>> 116: } >>> 117: >> >> Does one of these cases result in a *very very long line without a >> terminator"; something that would trigger

Re: RFR: 8358533: Improve performance of java.io.Reader.readAllLines [v9]

2025-07-01 Thread Brian Burkhalter
On Tue, 1 Jul 2025 01:37:27 GMT, Roger Riggs wrote: > I think resizing the buffer when the line length exceeds cb.length/2 will be > more efficient (cpu wise). I concur. I missed that this had been changed in the most recent commit. > test/jdk/java/io/Reader/ReadAll.java line 117: > >> 115:

Re: StringCharBuffer and bulk get

2025-07-01 Thread Chen Liang
Hi Brett, I think your suggestion makes sense. I have created https://bugs.openjdk.org/browse/JDK-8361209 to track this RFE. Feel free to contribute a patch to implement this enhancement. From: core-libs-dev on behalf of Brett Okken Sent: Tuesday, July 1, 2025

Could ByteOrder be turned into an enum?

2025-07-01 Thread Rob Spoor
Hi all, I've been using ByteOrder quite a bit, but something that's always annoyed me is that it's not an enum (because it predates them), and therefore cannot be easily used in switch expressions or statements. For instance, the closest I get is this, which still requires a default statement

Re: [jdk25] RFR: 8359337: XML/JAXP tests that make network connections should ensure that no proxy is selected

2025-07-01 Thread Iris Clark
On Tue, 1 Jul 2025 11:48:30 GMT, Jaikiran Pai wrote: > Can I please get a review of this backport of a test-only fix? > > This backports the fix for https://bugs.openjdk.org/browse/JDK-8359337 into > JDK 25. The original fix was integrated into mainline a few minutes back > https://github.com

Re: RFR: 8360884: Better scoped values [v4]

2025-07-01 Thread Alan Bateman
On Tue, 1 Jul 2025 11:15:54 GMT, Andrew Haley wrote: >> Scoped values cannot be used early in the JDK boot process because of some >> dependencies on System.getProperty(). This dependency should be removed in a >> way that allows scoped values to be created (but not necessarily bound) at >> an

Re: RFR: 8334015: Add Support for UUID Version 7 (UUIDv7) defined in RFC 9562 [v10]

2025-07-01 Thread Daniel Fuchs
On Tue, 1 Jul 2025 15:20:07 GMT, Jaikiran Pai wrote: >> The uniqueness comes not just from the timestamp but also from the random >> data in the other bytes that are generated for each new UUID. > > Hello Roger, that's true about the uniqueness semantics. However, from what I > understand of RF

Re: RFR: 8334015: Add Support for UUID Version 7 (UUIDv7) defined in RFC 9562 [v10]

2025-07-01 Thread Jaikiran Pai
On Tue, 1 Jul 2025 14:48:50 GMT, Roger Riggs wrote: >> src/java.base/share/classes/java/util/UUID.java line 107: >> >>> 105: >>> 106: private static long monotonicMS() { >>> 107: return ORIGIN_MS + (System.nanoTime() - ORIGIN_NS) / 1_000_000; >> >> Hello Kieran, the `System.nanoTim

Re: RFR: 8360037: Refactor ImageReader in preparation for Valhalla support

2025-07-01 Thread ExE Boss
On Mon, 30 Jun 2025 23:27:49 GMT, David Beaumont wrote: > Refactoring `ImageReader` to make it easy to add preview mode functionality > for Valhalla. > > This PR is a large change to `ImageReader` (effectively a rewrite) but > reduces the surface area of the API significantly, reduces code com

StringCharBuffer and bulk get

2025-07-01 Thread Brett Okken
jdk 25 introduced[1] a bulk getChars method to CharSequence[2]. Should StringCharBuffer be updated to utilize that new method to implement the bulk get method[3]? That would presumably require changes to the private getArray[4]. I think there could also be changes to putBuffer[5] for when the targe

Re: RFR: 8334015: Add Support for UUID Version 7 (UUIDv7) defined in RFC 9562 [v10]

2025-07-01 Thread Roger Riggs
On Tue, 1 Jul 2025 14:39:11 GMT, Jaikiran Pai wrote: >> Kieran Farrell has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new com

Re: RFR: 8334015: Add Support for UUID Version 7 (UUIDv7) defined in RFC 9562 [v10]

2025-07-01 Thread Jaikiran Pai
On Mon, 30 Jun 2025 18:19:30 GMT, Kieran Farrell wrote: >> With the recent approval of UUIDv7 >> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new >> static method UUID.timestampUUID() which constructs and returns a UUID in >> support of the new time generated UUID version

Re: RFR: 8360037: Refactor ImageReader in preparation for Valhalla support

2025-07-01 Thread Alan Bateman
On Mon, 30 Jun 2025 23:27:49 GMT, David Beaumont wrote: > Refactoring `ImageReader` to make it easy to add preview mode functionality > for Valhalla. > > This PR is a large change to `ImageReader` (effectively a rewrite) but > reduces the surface area of the API significantly, reduces code com

Re: RFR: 8360122: Fix java.sql\Connection.java indentation [v2]

2025-07-01 Thread simon
On Mon, 23 Jun 2025 17:45:02 GMT, Lance Andersen wrote: >> simon has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8360122: refactor code formatting to enforce 100 chars line length limit >> for improved readability > > I might not have

Re: RFR: 8361018: Re-examine buffering and encoding conversion in BufferedWriter [v6]

2025-07-01 Thread Brett Okken
On Tue, 1 Jul 2025 00:01:21 GMT, Shaojin Wen wrote: >> BufferedWriter -> OutputStreamWriter -> StreamEncoder >> >> In this call chain, BufferedWriter has a char[] buffer, and StreamEncoder >> has a ByteBuffer. There are two layers of cache here, or the BufferedWriter >> layer can be removed. A

Re: RFR: 8360037: Refactor ImageReader in preparation for Valhalla support

2025-07-01 Thread Alan Bateman
On Mon, 30 Jun 2025 23:27:49 GMT, David Beaumont wrote: > Refactoring `ImageReader` to make it easy to add preview mode functionality > for Valhalla. > > This PR is a large change to `ImageReader` (effectively a rewrite) but > reduces the surface area of the API significantly, reduces code com

Re: [jdk25] RFR: 8359337: XML/JAXP tests that make network connections should ensure that no proxy is selected

2025-07-01 Thread Jaikiran Pai
On Tue, 1 Jul 2025 14:26:44 GMT, Jaikiran Pai wrote: > So the same JVM will never run more than one test concurrently. Just for my own peace of mind I looked up the jtreg FAQ to be sure it specifies this behaviour. The FAQ here says https://openjdk.org/jtreg/faq.html#how-do-i-specify-whether-t

Re: [jdk25] RFR: 8359337: XML/JAXP tests that make network connections should ensure that no proxy is selected

2025-07-01 Thread Jaikiran Pai
On Tue, 1 Jul 2025 14:13:08 GMT, Daniel Fuchs wrote: > This seems OK without /othervm as long as tests are not run concurrently in > the same VM. jtreg guarantees that a agentvm is only used for one single action. So the same JVM will never run more than one test concurrently. -

Re: RFR: 8346719: Add relaunchers to the static JDK image for missing executables [v3]

2025-07-01 Thread Magnus Ihse Bursie
On Fri, 27 Jun 2025 16:15:57 GMT, Magnus Ihse Bursie wrote: >> In the static JDK image, a single humongous java executable is generated, >> and no other launcher, such as javac. This makes it impossible to run our >> jtreg tests, which assume these are present. >> >> The solution is fortunatel

Re: RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java

2025-07-01 Thread Takuya Kiriyama
On Wed, 19 Mar 2025 20:07:26 GMT, Roger Riggs wrote: >> The current test program for the logging feature added in JDK-8301627 does >> not fully check some important cases. >> >> Issue Details: >> The test does not properly check cases where logging might not happen due to >> different logging

Re: RFR: 8360037: Refactor ImageReader in preparation for Valhalla support

2025-07-01 Thread David Beaumont
On Mon, 30 Jun 2025 23:27:49 GMT, David Beaumont wrote: > Refactoring `ImageReader` to make it easy to add preview mode functionality > for Valhalla. > > This PR is a large change to `ImageReader` (effectively a rewrite) but > reduces the surface area of the API significantly, reduces code com

RFR: 8360037: Refactor ImageReader in preparation for Valhalla support

2025-07-01 Thread David Beaumont
Refactoring `ImageReader` to make it easy to add preview mode functionality for Valhalla. This PR is a large change to `ImageReader` (effectively a rewrite) but reduces the surface area of the API significantly, reduces code complexity and increases performance/memory efficiency. The need for t

Re: [jdk25] RFR: 8359337: XML/JAXP tests that make network connections should ensure that no proxy is selected

2025-07-01 Thread Daniel Fuchs
On Tue, 1 Jul 2025 11:48:30 GMT, Jaikiran Pai wrote: > Can I please get a review of this backport of a test-only fix? > > This backports the fix for https://bugs.openjdk.org/browse/JDK-8359337 into > JDK 25. The original fix was integrated into mainline a few minutes back > https://github.com

Re: RFR: 8334015: Add Support for UUID Version 7 (UUIDv7) defined in RFC 9562 [v10]

2025-07-01 Thread Roger Riggs
On Mon, 30 Jun 2025 18:19:30 GMT, Kieran Farrell wrote: >> With the recent approval of UUIDv7 >> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new >> static method UUID.timestampUUID() which constructs and returns a UUID in >> support of the new time generated UUID version

Re: RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java [v3]

2025-07-01 Thread Roger Riggs
On Fri, 4 Apr 2025 10:29:43 GMT, Takuya Kiriyama wrote: >> The current test program for the logging feature added in JDK-8301627 does >> not fully check some important cases. >> >> Issue Details: >> The test does not properly check cases where logging might not happen due to >> different loggi

Re: RFR: 8334015: Add Support for UUID Version 7 (UUIDv7) defined in RFC 9562 [v10]

2025-07-01 Thread Roger Riggs
On Mon, 30 Jun 2025 18:19:30 GMT, Kieran Farrell wrote: >> With the recent approval of UUIDv7 >> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new >> static method UUID.timestampUUID() which constructs and returns a UUID in >> support of the new time generated UUID version

Re: RFR: 8355563: VectorAPI: Refactor current implementation of subword gather load API [v2]

2025-07-01 Thread Xiaohong Gong
On Wed, 25 Jun 2025 09:16:48 GMT, Xiaohong Gong wrote: >> JDK-8318650 introduced hotspot intrinsification of subword gather load APIs >> for X86 platforms [1]. However, the current implementation is not optimal >> for AArch64 SVE platform, which natively supports vector instructions for >> sub

[jdk25] RFR: 8359337: XML/JAXP tests that make network connections should ensure that no proxy is selected

2025-07-01 Thread Jaikiran Pai
Can I please get a review of this backport of a test-only fix? This backports the fix for https://bugs.openjdk.org/browse/JDK-8359337 into JDK 25. The original fix was integrated into mainline a few minutes back https://github.com/openjdk/jdk/pull/26052. Backporting this fix should help preven

Integrated: 8359337: XML/JAXP tests that make network connections should ensure that no proxy is selected

2025-07-01 Thread Jaikiran Pai
On Mon, 30 Jun 2025 16:18:00 GMT, Jaikiran Pai wrote: > Can I please get a review of this test-only change which addresses the issue > noted in https://bugs.openjdk.org/browse/JDK-8359337? > > On macOS, the JDK by default (without any explicit system properties) picks > up the proxy settings c

Re: RFR: 8359337: XML/JAXP tests that make network connections should ensure that no proxy is selected [v2]

2025-07-01 Thread Jaikiran Pai
On Mon, 30 Jun 2025 16:52:55 GMT, Jaikiran Pai wrote: >> Can I please get a review of this test-only change which addresses the issue >> noted in https://bugs.openjdk.org/browse/JDK-8359337? >> >> On macOS, the JDK by default (without any explicit system properties) picks >> up the proxy setti

Re: RFR: 8346884: Add since checker test to jdk.editpad

2025-07-01 Thread Nizar Benalla
On Tue, 3 Jun 2025 10:09:44 GMT, Nizar Benalla wrote: > Please review this patch to add a new test to check `@since` tags in the > `jdk.editpad` module. > > TIA keep alive - PR Comment: https://git.openjdk.org/jdk/pull/25613#issuecomment-3023556036

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-07-01 Thread Daniel Jeliński
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

Re: RFR: 8360884: Better scoped values [v4]

2025-07-01 Thread Andrew Haley
> Scoped values cannot be used early in the JDK boot process because of some > dependencies on System.getProperty(). This dependency should be removed in a > way that allows scoped values to be created (but not necessarily bound) at > any stage during boot. > > Also, Scoped Value's constructor

Re: RFR: 8361018: Re-examine buffering and encoding conversion in BufferedWriter [v6]

2025-07-01 Thread Shaojin Wen
On Tue, 1 Jul 2025 02:33:16 GMT, Chen Liang wrote: > I think we can split this into two parts: > > 1. Update buffering strategy for BufferedWriter when backing writer is an > OutputStreamWriter > 2. Use an alternative StreamDecoder impl if the CharsetDecoder is an > ArrayDecoder > > This shou

Re: RFR: 8360884: Better scoped values [v3]

2025-07-01 Thread ExE Boss
On Tue, 1 Jul 2025 08:21:10 GMT, Andrew Haley wrote: >> src/java.base/share/classes/java/lang/ScopedValue.java line 802: >> >>> 800: return x; >>> 801: } >>> 802: }; >> >> There's something a bit uncomfortable about initializing hashGe

Re: RFR: 8355563: VectorAPI: Refactor current implementation of subword gather load API [v2]

2025-07-01 Thread Xiaohong Gong
On Tue, 1 Jul 2025 06:41:32 GMT, Xiaohong Gong wrote: >> Ping again! Thanks in advance! > >> @XiaohongGong I'm a little busy at the moment, and soon going on a summer >> vacation, so I cannot promise a full review soon. Feel free to ask someone >> else to have a look. >> >> I quickly looked th

Re: RFR: 8359419: AArch64: Relax min vector length to 32-bit for short vectors

2025-07-01 Thread Xiaohong Gong
On Tue, 1 Jul 2025 08:10:16 GMT, Andrew Haley wrote: >> ### Background >> On AArch64, the minimum vector length supported is 64-bit for basic types, >> except for `byte` and `boolean` (32-bit and 16-bit respectively to match >> special Vector API features). This limitation prevents intrinsifica

Re: RFR: 8360884: Better scoped values [v3]

2025-07-01 Thread Andrew Haley
On Mon, 30 Jun 2025 15:55:03 GMT, Alan Bateman wrote: > There's something a bit uncomfortable about initializing hashGenerator in > ScopedValue's class initializer, then changing it in Constants class > initializer. Iimmediately clear what the memory model issues. It doesn't of > course matter

Re: RFR: 8359419: AArch64: Relax min vector length to 32-bit for short vectors

2025-07-01 Thread Andrew Haley
On Tue, 1 Jul 2025 05:59:15 GMT, Xiaohong Gong wrote: > ### Background > On AArch64, the minimum vector length supported is 64-bit for basic types, > except for `byte` and `boolean` (32-bit and 16-bit respectively to match > special Vector API features). This limitation prevents intrinsificatio

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-07-01 Thread Daniel Jeliński
On Thu, 26 Jun 2025 17:34:45 GMT, Daniel Fuchs wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 525 commits: >> >> - merge latest changes from master branch >> - http3: run H3StreamLimitReachedTest.java wit

Re: RFR: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes [v3]

2025-07-01 Thread Alan Bateman
On Mon, 30 Jun 2025 15:08:25 GMT, David Beaumont wrote: >> Initial benchmark to capture at least some comparative measures of >> ImageReader performance. >> >> Current results on my laptop: >> >> Benchmark Mode Cnt ScoreError >> Units >> NewImag

Re: RFR: 8355563: VectorAPI: Refactor current implementation of subword gather load API [v2]

2025-07-01 Thread Xiaohong Gong
On Tue, 1 Jul 2025 06:07:03 GMT, Xiaohong Gong wrote: >> Xiaohong Gong has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains three commits: >> >> - Address review comments >> - Merge 'jdk:master' into JDK-8355563 >> - 8355563: Vector