On Tue, 1 Jul 2025 11:48:30 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of this backport of a test-only fix? > > This backports the fix for https://bugs.openjdk.org/browse/JDK-8359337 into > JDK 25. The original fix was integrated into mainline a few minutes back > https://github.com/openjdk/jdk/pull/26052. Backporting this fix should help > prevent failure of these tests on macOS hosts which have proxies configured. Look reasonable to me - though strictly speaking tests that fiddle with the global configuration should be run in /othervm. This seems OK without /othervm as long as tests are not run concurrently in the same VM. Maybe wait for @JoeWang-Java to approve before pushing. ------------- PR Review: https://git.openjdk.org/jdk/pull/26065#pullrequestreview-2975637913 Marked as reviewed by dfuchs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/26065#pullrequestreview-2975643173
