On Thu, 29 May 2025 18:52:51 GMT, Mohamed Issa wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_cbrt.cpp line 49:
>>
>>> 47:
>>> /**/
>>> 48:
>>> 49: ATTRIBUTE_ALIGNED(4) static const juint _SIG_MASK[] =
>>
>> ATTRI
On Mon, 26 May 2025 17:08:45 GMT, Aleksey Shipilev wrote:
> SonarCloud complains that since
> [JDK-8356080](https://bugs.openjdk.org/browse/JDK-8356080) we are using
> `Boolean` boxes in `ReverseOrderListView`. This change `boolean` -> `Boolean`
> was made in [JDK-8356080](https://bugs.openjdk
On Fri, 30 May 2025 02:23:17 GMT, Liam Miller-Cushon wrote:
> I have reviewed the CSR for you. Maybe us, Per Minborg, and Stuart Marks can
> work together to get the two significant collection changes into early 26 and
> broadcast on quality discuss list, as otherwise corpus analysis provides
> This change overrides mutator methods in the implementation returned by
> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
Liam Miller-Cushon has updated the pull request incrementally with one
additional commit since the last revision:
Add an implementation comment to Abstra
On Wed, 28 May 2025 07:11:36 GMT, Alexander Matveev
wrote:
> - `--install-dir` option in DMG packaging is no longer ignored.
> - Defaults are still the same: `/Applications` and
> `/Library/Java/JavaVirtualMachines`.
> - It will be user responsibility to make sure installation directory exist o
On Fri, 30 May 2025 01:31:12 GMT, Chen Liang wrote:
> For some reason the lines you've added for UOE in MOAT are failing; can you
> check?
This was due to the merge with
https://github.com/openjdk/jdk/commit/fbc4691bfa11f31601fd89d05da63e689343e214,
I resolved the conflict in the test but mis
On Thu, 29 May 2025 00:21:35 GMT, Stuart Marks wrote:
> For a full explanation, see the bug report
> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>
> This PR includes three related changes:
> * New overrides in SequencedMap view collection implementations, which
> improve their
> This change overrides mutator methods in the implementation returned by
> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
Liam Miller-Cushon has updated the pull request incrementally with one
additional commit since the last revision:
Update for Stable Values
-
On Fri, 30 May 2025 01:45:41 GMT, Alexander Matveev
wrote:
>> - `--install-dir` option in DMG packaging is no longer ignored.
>> - Defaults are still the same: `/Applications` and
>> `/Library/Java/JavaVirtualMachines`.
>> - It will be user responsibility to make sure installation directory exi
> - `--install-dir` option in DMG packaging is no longer ignored.
> - Defaults are still the same: `/Applications` and
> `/Library/Java/JavaVirtualMachines`.
> - It will be user responsibility to make sure installation directory exist on
> target machine, since DMG cannot create directories durin
On Thu, 3 Apr 2025 18:47:43 GMT, Matthew Donovan wrote:
> In this PR I added TLS groups and signature algorithms to the output of the
> show settings flag. The values are printed in a single column, like the
> cipher suites. There can be a lot of values so putting on a single line is
> ugly. I
On Wed, 28 May 2025 23:01:30 GMT, Alexey Semenyuk wrote:
>> If the installation directory doesn't exist, jpackage will try to create and
>> delete it right after the DMG package is created.
> Is this absolutely necessary? Is there a better way?
Yes, there is better way. I just figure it out. A
On Wed, 28 May 2025 07:11:36 GMT, Alexander Matveev
wrote:
> - `--install-dir` option in DMG packaging is no longer ignored.
> - Defaults are still the same: `/Applications` and
> `/Library/Java/JavaVirtualMachines`.
> - It will be user responsibility to make sure installation directory exist o
On Wed, 28 May 2025 17:13:41 GMT, Liam Miller-Cushon wrote:
>> This change overrides mutator methods in the implementation returned by
>> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
>
> Liam Miller-Cushon has updated the pull request with a new target base due to
> a merge o
On Fri, 30 May 2025 00:20:26 GMT, Justin Lu wrote:
>> Please review this PR which cleans up some i18n tests.
>>
>> There are some i18n related tests that set the locale provider to CLDR (and
>> only CLDR). Since JDK9, this is redundant and equivalent to the default.
>> Thus, occurrences of "-D
> Please review this PR which cleans up some i18n tests.
>
> There are some i18n related tests that set the locale provider to CLDR (and
> only CLDR). Since JDK9, this is redundant and equivalent to the default.
> Thus, occurrences of "-Djava.locale.providers=CLDR" are just extra noise for
> th
On Thu, 29 May 2025 22:47:11 GMT, Naoto Sato wrote:
>> Please review this PR which cleans up some i18n tests.
>>
>> There are some i18n related tests that set the locale provider to CLDR (and
>> only CLDR). Since JDK9, this is redundant and equivalent to the default.
>> Thus, occurrences of "-
On Fri, 30 May 2025 00:17:37 GMT, Justin Lu wrote:
>> Please review this PR which cleans up some i18n tests.
>>
>> There are some i18n related tests that set the locale provider to CLDR (and
>> only CLDR). Since JDK9, this is redundant and equivalent to the default.
>> Thus, occurrences of "-D
On Thu, 29 May 2025 21:59:30 GMT, Justin Lu wrote:
> Please review this PR which cleans up some i18n tests.
>
> There are some i18n related tests that set the locale provider to CLDR (and
> only CLDR). Since JDK9, this is redundant and equivalent to the default.
> Thus, occurrences of "-Djava.
Yeah. I can see these distinctions and guidelines being useful for callers
of the low-level concurrency primitive methods (semaphore etc.)
But at a higher level, in the application code, does anyone know of a
plausible scenario where being forced to catch IE is useful? It seems like
you either alw
On Thu, 29 May 2025 08:36:31 GMT, Jatin Bhateja wrote:
>> Mohamed Issa has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Remove comment mentioning invalid exception when NaN input is provided
>> - Use rcx as base and r8 as index for ad
On Wed, 28 May 2025 03:35:40 GMT, Alexey Semenyuk wrote:
> Various enhancements of jpackage test helpers:
> - Can run fa tests when JAVA_TOOL_OPTIONS env variable contains
> `--module-path` option. This change makes support for
> `jpackage.test.clear-app-launcher-java-env-vars` system property
On Thu, 29 May 2025 21:59:30 GMT, Justin Lu wrote:
> Please review this PR which cleans up some i18n tests.
>
> There are some i18n related tests that set the locale provider to CLDR (and
> only CLDR). Since JDK9, this is redundant and equivalent to the default.
> Thus, occurrences of "-Djava.
Please review this PR which cleans up some i18n tests.
There are some i18n related tests that set the locale provider to CLDR (and
only CLDR). Since JDK9, this is redundant and equivalent to the default. Thus,
occurrences of "-Djava.locale.providers=CLDR" are just extra noise for these
tests.
> VectorShape#largestShapeFor is referenced in existing JavaDoc but has been
> package-private. This propose change makes it public and adds documentation
> for it.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Updating copyrights
On Thu, 29 May 2025 21:52:30 GMT, Ian Graves wrote:
>> VectorShape#largestShapeFor is referenced in existing JavaDoc but has been
>> package-private. This propose change makes it public and adds documentation
>> for it.
>
> Ian Graves has updated the pull request incrementally with one addition
> VectorShape#largestShapeFor is referenced in existing JavaDoc but has been
> package-private. This propose change makes it public and adds documentation
> for it.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Adding test coverage
On Thu, 29 May 2025 21:19:31 GMT, Justin Lu wrote:
>> Please review this PR which removes the test tool `GenerateKeyList.java`
>> after the COMPAT locale data removal.
>>
>> `LocaleDataTest.java` may optionally use the `GenerateKeyList.java` tool.
>> However, this tool is manually used and was
On Wed, 28 May 2025 03:35:40 GMT, Alexey Semenyuk wrote:
> Various enhancements of jpackage test helpers:
> - Can run fa tests when JAVA_TOOL_OPTIONS env variable contains
> `--module-path` option. This change makes support for
> `jpackage.test.clear-app-launcher-java-env-vars` system property
On Thu, 29 May 2025 21:15:57 GMT, Justin Lu wrote:
>> Please review this PR which removes the test tool `GenerateKeyList.java`
>> after the COMPAT locale data removal.
>>
>> `LocaleDataTest.java` may optionally use the `GenerateKeyList.java` tool.
>> However, this tool is manually used and was
> Please review this PR which removes the test tool `GenerateKeyList.java`
> after the COMPAT locale data removal.
>
> `LocaleDataTest.java` may optionally use the `GenerateKeyList.java` tool.
> However, this tool is manually used and was primarily used for COMPAT data.
> There is no longer any
On Sat, 24 May 2025 10:00:56 GMT, Shaojin Wen wrote:
> Classes such as java.lang.CharacterDataXXX have multiple static final arrays,
> these are immutable, We should add `@Stable` and final to provide information
> to the optimizer.
This pull request has now been integrated.
Changeset: 727412
On Thu, 29 May 2025 00:21:35 GMT, Stuart Marks wrote:
> For a full explanation, see the bug report
> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
>
> This PR includes three related changes:
> * New overrides in SequencedMap view collection implementations, which
> improve their
> This proposed change would move the native objects required for NIO file
> interaction from the libnio native library to the libjava native library on
> Linux, macOS, and Windows.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase. The pull request
On Mon, 26 May 2025 08:20:19 GMT, Magnus Ihse Bursie wrote:
>> I found a few other places in the code that can be cleaned up after the
>> conversion to UTF-8.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Restore
Please review this PR which updates the test tool `GenerateKeyList.java` after
the COMPAT locale data removal.
`LocaleDataTest.java` may optionally use the `GenerateKeyList.java` tool; the
latter requires similar bundle name changes that were made to the former in
https://bugs.openjdk.org/brows
On Thu, 29 May 2025 08:21:29 GMT, Jatin Bhateja wrote:
>> Mohamed Issa has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Remove comment mentioning invalid exception when NaN input is provided
>> - Use rcx as base and r8 as index for ad
On Thu, 29 May 2025 09:01:05 GMT, Julian Waters wrote:
>> Mohamed Issa has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Remove comment mentioning invalid exception when NaN input is provided
>> - Use rcx as base and r8 as index for ad
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
> included to check the performance of specific input value ranges to help
> prevent regressions in the future.
>
> The command to run all range specific
On Thu, 29 May 2025 18:43:31 GMT, Vladimir Ivanov wrote:
>> We already have this to address that issue for the specific case of
>> Reference.get:
>> https://github.com/openjdk/jdk/blob/4cf729cfac57c9aec692a52c1f3f95f2403e7958/src/hotspot/share/opto/compile.cpp#L786-L792
>> I think if we made the
On Thu, 29 May 2025 13:08:25 GMT, Kim Barrett wrote:
>> The current limitation of intrinsics support in C1/C2 is that intrinsics are
>> always applied in the context of some method (as part of inlining). If a
>> method is at the root of the compilation, it is never intrinsified.
>>
>> The prob
On Sat, 24 May 2025 10:15:44 GMT, Thomas Stuefe wrote:
>> See bug description. We now unblock all signals in both FORK and POSIX_SPAWN
>> launch modes. This fixes the problem and makes the behavior consistent
>> across these two modes.
>>
>> I left the VFORK mode alone since I believe the sign
On Thu, 29 May 2025 17:20:12 GMT, Naoto Sato wrote:
> Test refactoring stemmed from the discussion at
> https://git.openjdk.org/jdk/pull/25228#discussion_r2106755160. The test is
> now based on UTF-8 instead of ISO-8859-1
Marked as reviewed by joehw (Reviewer).
-
PR Review: https
On Thu, 29 May 2025 17:05:23 GMT, kieran-farrell wrote:
>> We don't have a reliable sub-microsecond source across platforms, so can
>> only be confident using random numbers for the low order bits. (and I don't
>> expect a higher resolution monotonic clock to be available anytime soon).
>>
>>
For a full explanation, see the bug report
[JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015).
This PR includes three related changes:
* New overrides in SequencedMap view collection implementations, which improve
their behavior.
* Update to `@implSpec` clauses to reflect this behavior (
On Wed, 28 May 2025 17:00:22 GMT, Justin Lu wrote:
> Please review this PR which updates the language subtag registry to Version
> 2025-05-15.
>
> LanguageSubtagRegistryTest.java was updated with the preferred-values: `hnm`,
> `eko`, `luh`,`sjc`, `sqm`. A small change was also made to the test
On Thu, 29 May 2025 17:20:12 GMT, Naoto Sato wrote:
> Test refactoring stemmed from the discussion at
> https://git.openjdk.org/jdk/pull/25228#discussion_r2106755160. The test is
> now based on UTF-8 instead of ISO-8859-1
Test change looks good. Skimmed the data change, which also looks to be
On Mon, 19 May 2025 20:56:55 GMT, Justin Lu wrote:
> It is not clear that `Locale.Builder.setLanguageTag(String)` accepts
> _extlang_ subtags in the input as well as what behavior occurs. Additionally,
> both this method and `Locale.forLanguageTag(String)` should mention their
> behavior when
Test refactoring stemmed from the discussion at
https://git.openjdk.org/jdk/pull/25228#discussion_r2106755160. The test is now
based on UTF-8 instead of ISO-8859-1
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/25524/files
Webrev: https://webrevs.o
On Wed, 28 May 2025 03:35:40 GMT, Alexey Semenyuk wrote:
> Various enhancements of jpackage test helpers:
> - Can run fa tests when JAVA_TOOL_OPTIONS env variable contains
> `--module-path` option. This change makes support for
> `jpackage.test.clear-app-launcher-java-env-vars` system property
On Thu, 29 May 2025 14:35:11 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Enhanced exception messages are designed to hide sensitive information such
>> as hostnames, IP
>> addresses from exception message strings, unless the enhanced mode for the
>> specific category
>> has been explicitly enab
On Wed, 28 May 2025 20:57:15 GMT, Roger Riggs wrote:
>> The first 48 bits need to be from the unix epoch time stamp in ms only to
>> remain complaint. If I understand correctly, to be able to guarantee that
>> the nsBits are actually time orderable, System.nanoTime() would have to be
>> pinned
On Wed, 28 May 2025 17:00:22 GMT, Justin Lu wrote:
> Please review this PR which updates the language subtag registry to Version
> 2025-05-15.
>
> LanguageSubtagRegistryTest.java was updated with the preferred-values: `hnm`,
> `eko`, `luh`,`sjc`, `sqm`. A small change was also made to the test
Various enhancements of jpackage test helpers:
- Can run fa tests when JAVA_TOOL_OPTIONS env variable contains
`--module-path` option. This change makes support for
`jpackage.test.clear-app-launcher-java-env-vars` system property redundant.
- Rework JUnitAdapter to make it run jpackage TestInst
On Wed, 28 May 2025 03:35:40 GMT, Alexey Semenyuk wrote:
> Various enhancements of jpackage test helpers:
> - Can run fa tests when JAVA_TOOL_OPTIONS env variable contains
> `--module-path` option. This change makes support for
> `jpackage.test.clear-app-launcher-java-env-vars` system property
> VectorShape#largestShapeFor is referenced in existing JavaDoc but has been
> package-private. This propose change makes it public and adds documentation
> for it.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Fixing tabbing
-
> VectorShape#largestShapeFor is referenced in existing JavaDoc but has been
> package-private. This propose change makes it public and adds documentation
> for it.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Tweaking doc language
On Thu, 29 May 2025 13:42:34 GMT, Nizar Benalla wrote:
>> Get JDK 26 underway.
>
> Nizar Benalla has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 16 commits:
>
> - Merge branch 'master' into jdk.8355746
> - Merge branch 'master' i
On Thu, 17 Apr 2025 16:18:55 GMT, Brian Burkhalter wrote:
> Implement the requested methods and add a test thereof.
This pull request has now been integrated.
Changeset: 79aff26c
Author:Brian Burkhalter
URL:
https://git.openjdk.org/jdk/commit/79aff26c2880922b92863911d8a5a035ba9a1e75
> Hi,
>
> Enhanced exception messages are designed to hide sensitive information such
> as hostnames, IP
> addresses from exception message strings, unless the enhanced mode for the
> specific category
> has been explicitly enabled. Enhanced exceptions were first introduced in
> 8204233 in JD
On Sat, 24 May 2025 10:15:44 GMT, Thomas Stuefe wrote:
>> See bug description. We now unblock all signals in both FORK and POSIX_SPAWN
>> launch modes. This fixes the problem and makes the behavior consistent
>> across these two modes.
>>
>> I left the VFORK mode alone since I believe the sign
> Get JDK 26 underway.
Nizar Benalla has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 16 commits:
- Merge branch 'master' into jdk.8355746
- Merge branch 'master' into jdk.8355746
- Update --release 25 symbol information for JDK 25
On Thu, 29 May 2025 01:14:30 GMT, Vladimir Ivanov wrote:
>> The comment is about why we have native `get0` at all, rather than just
>> making
>> `get` also be native.
>>
>>> [...] JDK-8271862 was about migrating to non-virtual intrinsic method.
>>
>> That's not a correct summary of JDK-8271862
On Wed, 23 Mar 2022 00:35:14 GMT, Xin Liu wrote:
>> If AbstractStringBuilder only grow, the inflated value which has been
>> encoded in UTF16 can't be compressed.
>> toString() can skip compression in this case. This can save an
>> ArrayAllocation in StringUTF16::compress().
>>
>> java.io.Buf
On Tue, 27 May 2025 12:03:41 GMT, Per Minborg wrote:
>> This PR builds on a concept John Rose told me about some time ago. Instead
>> of combining memory operations of various sizes, a single large and skewed
>> memory operation can be made to clean up the tail of remaining bytes.
>>
>> This h
On Wed, 28 May 2025 18:39:13 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Wed, 28 May 2025 23:13:21 GMT, Mark Sheppard wrote:
> here are a few files with IOException, UnknownHostException and
> MalformedURLException, which are worth reviewing for Exception that may have
> been missed
>
> IOEXception:
>
> open/src/java.base/share/classes/sun/net/www/protocol/http
On Mon, 26 May 2025 20:39:51 GMT, Mark Sheppard wrote:
> You could take a slightly more radical approach, and rather than applying a
> filter explicitly on the exception message, adopt a builder pattern for the
> creation of the filter exceptions, for example
>
> FilteredExceptionBuilder / Enh
On Wed, 28 May 2025 12:12:50 GMT, Emanuel Peter wrote:
>> erifan has updated the pull request with a new target base due to a merge or
>> a rebase. The incremental webrev excludes the unrelated changes brought in
>> by the merge/rebase. The pull request contains 10 additional commits since
>>
On Wed, 28 May 2025 18:39:13 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.cbrt() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Fri, 16 May 2025 07:40:53 GMT, erifan wrote:
>> erifan has updated the pull request with a new target base due to a merge or
>> a rebase. The incremental webrev excludes the unrelated changes brought in
>> by the merge/rebase. The pull request contains 10 additional commits since
>> the las
On Wed, 28 May 2025 12:16:23 GMT, Emanuel Peter wrote:
>> src/hotspot/share/opto/vectornode.cpp line 2244:
>>
>>> 2242: // BoolTest doesn't support unsigned comparisons.
>>> 2243: BoolTest::mask neg_cond =
>>> 2244: (BoolTest::mask) (((VectorMaskCmpNode*) in1)->get_predicate() ^
>>> 4
On Wed, 28 May 2025 17:56:07 GMT, Adam Sotona wrote:
> java.lang.classfile.Signature.ArrayTypeSig.of constraint check did not
> include dimensions of the given component if the component is an array.
>
> This patch fixes the constraint check, corrects the @throws description and
> adds test of
On Wed, 28 May 2025 17:56:07 GMT, Adam Sotona wrote:
> java.lang.classfile.Signature.ArrayTypeSig.of constraint check did not
> include dimensions of the given component if the component is an array.
>
> This patch fixes the constraint check, corrects the @throws description and
> adds test of
74 matches
Mail list logo
