On Thu, 29 May 2025 21:19:31 GMT, Justin Lu <j...@openjdk.org> wrote:

>> Please review this PR which removes the test tool `GenerateKeyList.java` 
>> after the COMPAT locale data removal.
>> 
>> `LocaleDataTest.java` may optionally use the `GenerateKeyList.java` tool. 
>> However, this tool is manually used and was primarily used for COMPAT data. 
>> There is no longer any point to keep it, and it can always be retrieved via 
>> the VCS if needed.
>
> Justin Lu has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   reflect some corrections

LGTM. The manual tool hasn't been used and it does not cope with CLDR. Removing 
the tool would be appropriate.

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25527#pullrequestreview-2879670600

Reply via email to