On Sat, 24 May 2025 10:15:44 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> See bug description. We now unblock all signals in both FORK and POSIX_SPAWN >> launch modes. This fixes the problem and makes the behavior consistent >> across these two modes. >> >> I left the VFORK mode alone since I believe the signal state is still shared >> with the parent. One more reason to get rid of this mode soon (it's >> deprecated with 25 and will be removed with 26) >> >> The fix just moves the unblocking code from the jspawnhelper over to the >> child process function that is called for all three modes. >> >> ----- >> >> Testing: I did various manual tests. I also tested that >> test/jdk/java/lang/ProcessBuilder/UnblockSignals.java succeeds with both >> POSIX_SPAWN and FORK mode now and that the behavior is unchanged (still >> broken) for VFORK mode. >> >> ping @RogerRiggs I would like to get this still into JDK 25; the fix is >> small and clean enough to not worry me. > > Thomas Stuefe has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'openjdk:master' into > JDK-8357683-process-SIGQUIT-still-blocked-after-JDK-8234262-with-jdk-lang-Process-launchMechanism=FORK-or-VFORK > - unblock signals in fork mode Passes the CI and no problems are expected under normal launching mechanisms. ------------- Marked as reviewed by rriggs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25428#pullrequestreview-2879276283
