On Mon, 26 May 2025 21:44:32 GMT, Mark Sheppard wrote:
> The point I was raising, is that the socket etc category was dropped under
> the premise that it requires knowledge of the APIs used.
Right, what is now "hostInfoExclSocket" is a confusing category and not easy to
explain to anyone. Howe
On Sat, 24 May 2025 11:35:33 GMT, Doug Lea wrote:
> Method startDelayScheduler should trap the ISE thrown by
> SharedThreadContainer.start and possibly re-try termination before eventually
> throwing RejectedExecutionException.
This pull request has now been integrated.
Changeset: 2c034f57
Au
On Sun, 18 May 2025 11:11:32 GMT, Shaojin Wen wrote:
> When debugging getLong/getDouble/getDecimal of DigitList, the debugger will
> call the DigitList::toString method. At this time, DigitList::toString will
> modify tempBuilder, which will cause incorrect results.
This is a formatting-relate
On Mon, 26 May 2025 18:59:10 GMT, Raffaello Giulietti
wrote:
>> Add a `-Dcount=N` command line option to specify the number of random
>> samples per test (default is 10'000).
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision
On Mon, 26 May 2025 19:22:39 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/jdk/internal/util/Exceptions.java line 253:
>>
>>> 251: return;
>>> 252: enhancedSocketExceptionText =
>>> SecurityProperties.includedInExceptions("hostInfo");
>>> 253: enhancedNonSo
On Mon, 26 May 2025 10:31:39 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Enhanced exception messages are designed to hide sensitive information such
>> as hostnames, IP
>> addresses from exception message strings, unless the enhanced mode for the
>> specific category
>> has been explicitly enab
On Tue, 20 May 2025 15:25:52 GMT, Michael McMahon wrote:
> Hi,
>
> This is a simple test update which increases a timeout from 300s to 400 to
> account for slow mac os test machines.
> A repeat 50 test of :jdk_lang passes. I will run this a few more times before
> pushing, if the change is acc
On Mon, 26 May 2025 19:06:56 GMT, Mark Sheppard wrote:
>> Michael McMahon has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 28 commits:
>>
>> - Merge branch 'master' into 8348986-exceptions
>> - update
>> - reduced number of new
> Through JVM Option +PrintInlining, we found that String has a constructor
> codeSize of 852, which is too large. This caused failed to inline.
>
> The following is the output information of PrintInlining:
>
> @ 9 java.lang.String:: (12 bytes) inline (hot)
> !m
On Mon, 26 May 2025 17:08:45 GMT, Aleksey Shipilev wrote:
> SonarCloud complains that since
> [JDK-8356080](https://bugs.openjdk.org/browse/JDK-8356080) we are allocating
> and using `Boolean` boxes in `ReverseOrderListView`. This change `boolean` ->
> `Boolean` was made in
> [JDK-8356080](ht
On Mon, 26 May 2025 10:31:39 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Enhanced exception messages are designed to hide sensitive information such
>> as hostnames, IP
>> addresses from exception message strings, unless the enhanced mode for the
>> specific category
>> has been explicitly enab
> Add a `-Dcount=N` command line option to specify the number of random samples
> per test (default is 10'000).
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
Changed option name to "samples".
-
Changes:
- all
Add a `-Dcount=N` command line option to specify the number of random samples
per test (default is 10'000).
-
Commit messages:
- 8357808: Add a command line option for specifying a counter in
TestRandomFloatingDecimal
Changes: https://git.openjdk.org/jdk/pull/25460/files
Webrev:
On Mon, 26 May 2025 10:31:39 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Enhanced exception messages are designed to hide sensitive information such
>> as hostnames, IP
>> addresses from exception message strings, unless the enhanced mode for the
>> specific category
>> has been explicitly enab
On Mon, 26 May 2025 15:57:17 GMT, Daniel Fuchs wrote:
>> Can I please get a review of this change which proposes to address the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8357708?
>>
>> As noted in the issue, the current code in
>> `com.sun.jndi.ldap.Connection.readReply()` is susce
On Mon, 26 May 2025 05:43:49 GMT, Jaikiran Pai wrote:
>> Steffen Nießing has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8357597: Update copyright year
>
> The change looks OK to me. Please update the copyright year on the file from
> `
Depending on which static final arrays, this might be fine.
On 2025-05-26 01:57, wenshao wrote:
Some static final arrays of BigInteger and BigDecimal are stable and
immutable. We should add @Stable to give the optimizer more information
-
Shaojin Wen
On Mon, 26 May 2025 10:31:39 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Enhanced exception messages are designed to hide sensitive information such
>> as hostnames, IP
>> addresses from exception message strings, unless the enhanced mode for the
>> specific category
>> has been explicitly enab
On Mon, 26 May 2025 10:31:39 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Enhanced exception messages are designed to hide sensitive information such
>> as hostnames, IP
>> addresses from exception message strings, unless the enhanced mode for the
>> specific category
>> has been explicitly enab
> SonarCloud complains `ST_NEW` constant is not used. Looks to me the
> constructor implicitly relies on default value for `state`. It would be
> cleaner to initialize it explicitly
>
> Additional testing:
> - [x] Linux x86_64 server fastdebug, `java/util/concurrent`
Aleksey Shipilev has updat
On Mon, 26 May 2025 17:17:30 GMT, Aleksey Shipilev wrote:
>> SonarCloud complains `ST_NEW` constant is not used. Looks to me the
>> constructor implicitly relies on default value for `state`. It would be
>> cleaner to initialize it explicitly
>>
>> Additional testing:
>> - [x] Linux x86_64 se
On Mon, 26 May 2025 16:46:49 GMT, Alan Bateman wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move to the end
>
> src/java.base/share/classes/java/util/concurrent/StructuredTaskScopeImpl.java
> line 70:
>
>>
SonarCloud complains that since
[JDK-8356080](https://bugs.openjdk.org/browse/JDK-8356080) we are allocating
and using `Boolean` boxes in `ReverseOrderListView`. This change `boolean` ->
`Boolean` was made in
[JDK-8356080](https://bugs.openjdk.org/browse/JDK-8356080) to allow `@Stable`
folding
On Mon, 26 May 2025 10:31:39 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Enhanced exception messages are designed to hide sensitive information such
>> as hostnames, IP
>> addresses from exception message strings, unless the enhanced mode for the
>> specific category
>> has been explicitly enab
On Mon, 26 May 2025 16:16:44 GMT, Jaikiran Pai wrote:
> Additionally, the addRequest(), close() and cancel() methods of this
> LdapRequet get called by a single thread managed by the Connection class, so
> there isn't expected to be concurrent calls across these methods.
I am not seeing that
On Mon, 26 May 2025 16:37:01 GMT, Aleksey Shipilev wrote:
> SonarCloud complains `ST_NEW` constant is not used. Looks to me the
> constructor implicitly relies on default value for `state`. It would be
> cleaner to initialize it explicitly
>
> Additional testing:
> - [x] Linux x86_64 server f
On Tue, 20 May 2025 15:25:52 GMT, Michael McMahon wrote:
> Hi,
>
> This is a simple test update which increases a timeout from 300s to 400 to
> account for slow mac os test machines.
> A repeat 50 test of :jdk_lang passes. I will run this a few more times before
> pushing, if the change is acc
On Fri, 23 May 2025 15:15:30 GMT, Viktor Klang wrote:
> While it could be argued that unbounded Spliterators should not report SIZED
> / SUBSIZED, GatherSink should report an unknown emission size, so switching
> to downstream.begin(-1) rather than downstream.begin(size).
>
> Includes a regres
SonarCloud complains `ST_NEW` constant is not used. Looks to me the constructor
implicitly relies on default value for `state`. It would be cleaner to
initialize it explicitly
Additional testing:
- [x] Linux x86_64 server fastdebug, `java/util/concurrent`
-
Commit messages:
- Fix
On Mon, 26 May 2025 12:28:16 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the issue
> noted in https://bugs.openjdk.org/browse/JDK-8357708?
>
> As noted in the issue, the current code in
> `com.sun.jndi.ldap.Connection.readReply()` is susceptibl
On Mon, 26 May 2025 15:48:10 GMT, Steffen Nießing wrote:
>> `Proxy#getInvocationHandler(Object)` throws a `NullPointerException` if the
>> specified argument is `null`. This PR adds the missing `throws` declaration
>> for the NPE.
>
> Steffen Nießing has updated the pull request incrementally w
On Mon, 26 May 2025 12:54:06 GMT, Doug Lea wrote:
>> Method startDelayScheduler should trap the ISE thrown by
>> SharedThreadContainer.start and possibly re-try termination before
>> eventually throwing RejectedExecutionException.
>
> Doug Lea has updated the pull request incrementally with one
On Mon, 26 May 2025 15:48:10 GMT, Steffen Nießing wrote:
>> `Proxy#getInvocationHandler(Object)` throws a `NullPointerException` if the
>> specified argument is `null`. This PR adds the missing `throws` declaration
>> for the NPE.
>
> Steffen Nießing has updated the pull request incrementally w
> `Proxy#getInvocationHandler(Object)` throws a `NullPointerException` if the
> specified argument is `null`. This PR adds the missing `throws` declaration
> for the NPE.
Steffen Nießing has updated the pull request incrementally with one additional
commit since the last revision:
8357597: U
Yeah, I think I missed the task cancellation and the joining part.
When the mapConcurrent() thread is interrupted, it propagates the
cancellation to the child threads.
And if any of the children threads (running the user-provided Function)
receives that cancellation, it will still need to catch i
On Wed, 21 May 2025 15:37:34 GMT, serhiysachkov wrote:
> Update open/test/jdk/TEST.groups manual test groups definitions with missing
> manual test
LGTM
-
PR Comment: https://git.openjdk.org/jdk/pull/25360#issuecomment-2910047397
On Fri, 23 May 2025 19:52:50 GMT, Chen Liang wrote:
> Can we remove all meaningless `!Architecture.isLittleEndian()` calls and use
> the platform-specific endianness unsafe primitives instead? For compensation,
> we can add a check in each of fill2/fill3/fill4 that `assert value ==
> Integer/S
On Mon, 26 May 2025 13:23:07 GMT, Shaojin Wen wrote:
>> Through JVM Option +PrintInlining, we found that String has a constructor
>> codeSize of 852, which is too large. This caused failed to inline.
>>
>> The following is the output information of PrintInlining:
>>
>> @ 9 ja
> Through JVM Option +PrintInlining, we found that String has a constructor
> codeSize of 852, which is too large. This caused failed to inline.
>
> The following is the output information of PrintInlining:
>
> @ 9 java.lang.String:: (12 bytes) inline (hot)
> !m
> Classes such as java.lang.CharacterDataXXX have multiple static final arrays,
> these are immutable, We should add `@Stable` and final to provide information
> to the optimizer.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
add '
> Get JDK 26 underway.
Nizar Benalla has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 14 commits:
- Update --release 25 symbol information for JDK 25 build 24
The macOS/AArch64 build 24 was taken from https://jdk.java.net/25/
- Me
> Method startDelayScheduler should trap the ISE thrown by
> SharedThreadContainer.start and possibly re-try termination before eventually
> throwing RejectedExecutionException.
Doug Lea has updated the pull request incrementally with one additional commit
since the last revision:
rethrow Er
On Fri, 23 May 2025 14:59:07 GMT, Nizar Benalla wrote:
>> Please review this patch to fix some `javadoc` bugs in `java.base`.
>> Certain `@link` tags used to refer to private fields instead of public APIs.
>>
>> A couple of `@see` tags in the [serialization
>> page](https://download.java.net/ja
On Sat, 17 May 2025 19:42:39 GMT, Nizar Benalla wrote:
> Please review this patch to fix some `javadoc` bugs in `java.base`.
> Certain `@link` tags used to refer to private fields instead of public APIs.
>
> A couple of `@see` tags in the [serialization
> page](https://download.java.net/java/ea
Can I please get a review of this change which proposes to address the issue
noted in https://bugs.openjdk.org/browse/JDK-8357708?
As noted in the issue, the current code in
`com.sun.jndi.ldap.Connection.readReply()` is susceptible to throwing a
`ServiceUnavailableException` even when the LDAP
On Mon, 26 May 2025 12:00:02 GMT, Per Minborg wrote:
>> I thought this would both increase cleaniness and reduce code size of the
>> decode method. @minborg What do you think? This also removes one of the
>> switches on COMPACT_STRING.
>
> I think it is better to keep the code smaller rather th
On Sun, 25 May 2025 12:54:03 GMT, Chen Liang wrote:
>> private String(char[] value, int off, int len, Void sig) {
>> if (len == 0) {
>> this.value = "".value;
>> this.coder = "".coder;
>> return;
>> }
>> if (COMPACT_STRINGS) {
>>
On Mon, 26 May 2025 10:31:39 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Enhanced exception messages are designed to hide sensitive information such
>> as hostnames, IP
>> addresses from exception message strings, unless the enhanced mode for the
>> specific category
>> has been explicitly enab
On Sat, 24 May 2025 10:00:56 GMT, Shaojin Wen wrote:
> Classes such as java.lang.CharacterDataXXX have multiple static final arrays,
> these are immutable, We should add `@Stable` and final to provide information
> to the optimizer.
We could add '@Stable` to `static final char[][][] charMap` a
> Hi,
>
> Enhanced exception messages are designed to hide sensitive information such
> as hostnames, IP
> addresses from exception message strings, unless the enhanced mode for the
> specific category
> has been explicitly enabled. Enhanced exceptions were first introduced in
> 8204233 in JD
On Mon, 26 May 2025 08:16:03 GMT, Matthias Baesken wrote:
>> On a 'german' Ubuntu 24 (LANG="de_DE.UTF-8") the jtreg test
>> java/lang/System/LoggerFinder/internal/BootstrapLogger/BootstrapLoggerTest
>> fails with
>>
>>
>> FEIN: hi now!
>> java.lang.RuntimeException: System.err does not contai
On Mon, 26 May 2025 08:16:03 GMT, Matthias Baesken wrote:
>> On a 'german' Ubuntu 24 (LANG="de_DE.UTF-8") the jtreg test
>> java/lang/System/LoggerFinder/internal/BootstrapLogger/BootstrapLoggerTest
>> fails with
>>
>>
>> FEIN: hi now!
>> java.lang.RuntimeException: System.err does not contai
On Wed, 14 May 2025 15:11:24 GMT, Magnus Ihse Bursie wrote:
> Non-breaking space characters are problematic. They look identical to the
> normal space character, but is not. For that reason, it should never be typed
> as an UTF-8 literal, but only by using unicode sequences.
>
> I have checked
On 24/05/2025 15:37, Markus KARG wrote:
Chen,
thank you for your approval for a DRAFT PR.
Following your proposal, I have published a DRAFT PR at
https://github.com/openjdk/jdk/pull/25432 so everybody can see what
the actual intended code change looks like, and better focus on that
act
On Mon, 26 May 2025 08:10:19 GMT, Magnus Ihse Bursie wrote:
>> I found a few other places in the code that can be cleaned up after the
>> conversion to UTF-8.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Restore
> On second thought, we should just focus on adding stable and final as you
> recommend - we should fix stylistic things with no semantic impact later.
I’ll note that the code generator used to emit these CharacterData classes —
build.tools.generatecharacter.GenerateCharacter — has legacy suppo
> On a 'german' Ubuntu 24 (LANG="de_DE.UTF-8") the jtreg test
> java/lang/System/LoggerFinder/internal/BootstrapLogger/BootstrapLoggerTest
> fails with
>
>
> FEIN: hi now!
> java.lang.RuntimeException: System.err does not contain: FINE: hi now!
> at BootstrapLoggerTest.main(BootstrapLoggerTest.
> I found a few other places in the code that can be cleaned up after the
> conversion to UTF-8.
Magnus Ihse Bursie has updated the pull request incrementally with two
additional commits since the last revision:
- Restore MenuShortcut.java
- Restore LocaleDataTest.java
-
Changes
On Wed, 14 May 2025 14:29:23 GMT, Magnus Ihse Bursie wrote:
> After we converted the source base to be fully UTF-8, we do not need to use
> unicode sequences (like \u0123) in string literals. Sometimes, that might
> still make sense, as for control characters, non-breaking space, etc. But for
On Wed, 14 May 2025 14:29:23 GMT, Magnus Ihse Bursie wrote:
> After we converted the source base to be fully UTF-8, we do not need to use
> unicode sequences (like \u0123) in string literals. Sometimes, that might
> still make sense, as for control characters, non-breaking space, etc. But for
On Thu, 22 May 2025 21:26:08 GMT, Phil Race wrote:
>> FYI, the style guide for France
>> [recommends](https://fr.wikipedia.org/wiki/Espace_ins%C3%A9cable#En_France):
>>
>> - U+202F (Narrow No-Break Space NNBSP) preceding semicolon, question mark,
>> and exclamation mark.
>> - U+00A0 (No-Break
On Thu, 22 May 2025 21:43:20 GMT, Phil Race wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Restore MenuShortcut.java
>> - Restore LocaleDataTest.java
>
> src/java.desktop/share/classes/java/awt/MenuShortc
On Thu, 15 May 2025 18:30:28 GMT, Naoto Sato wrote:
>> I found a few other places in the code that can be cleaned up after the
>> conversion to UTF-8.
>
> test/jdk/sun/text/resources/LocaleDataTest.java line 106:
>
>> 104: *FormatData/fr_FR/MonthNames/0=janvier
>> 105: *Format
On a 'german' Ubuntu 24 (LANG="de_DE.UTF-8") the jtreg test
java/lang/System/LoggerFinder/internal/BootstrapLogger/BootstrapLoggerTest
fails with
FEIN: hi now!
java.lang.RuntimeException: System.err does not contain: FINE: hi now!
at BootstrapLoggerTest.main(BootstrapLoggerTest.java:231)
at
ja
Yes, the updated Gatherers.mapConcurrent will continue under interruption until
done, and then restore the interrupt status of the calling thread.
It cannot (reasonably) do anything else—if it were to throw
InterruptedException, it couldn't since that is a checked exception and there's
no track
On Thu, 22 May 2025 17:46:33 GMT, Naoto Sato wrote:
>> `java.io.Console` uses the charset specified by the `stdout.encoding` system
>> property for both input and output. While this is generally sufficient,
>> since Console is intended for interactive terminal use, some platforms allow
>> diff
On Mon, 26 May 2025 06:51:12 GMT, Emanuel Peter wrote:
>> JDK-8318650 introduced hotspot intrinsification of subword gather load APIs
>> for X86 platforms [1]. However, the current implementation is not optimal
>> for AArch64 SVE platform, which natively supports vector instructions for
>> sub
67 matches
Mail list logo