On Mon, 26 May 2025 08:10:19 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

>> I found a few other places in the code that can be cleaned up after the 
>> conversion to UTF-8.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two 
> additional commits since the last revision:
> 
>  - Restore MenuShortcut.java
>  - Restore LocaleDataTest.java

test/jdk/java/awt/event/KeyEvent/KeyTyped/EscapeKeyTyped.java line 90:

> 88:                 printKey(e);
> 89:                 int keychar = e.getKeyChar();
> 90:                 if (keychar == 27) { // Escape character is 27 or \u001b

@prrace I think this is an actual bug. `\u0021` codes to `!`, and I don't think 
that is what was meant. Do you still want me to revert it?

test/jdk/java/awt/print/RemotePrinterStatusRefresh/RemotePrinterStatusRefresh.java
 line 188:

> 186:                     +          "\"After\" lists.\n"
> 187:                     + "              Added printers are highlighted with 
> "
> 188:                     +               "green color, removed ones \u2014 
> with "

@prrace This too seems like a bug, or rather a typo. The text currently reads 
`Added printers are highlighted with green color, removed ones — with red 
color.`. The Em dash does not make any sense to me, and seems to be a copy 
paste error.

Do you still want me to revert it?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25228#discussion_r2106774492
PR Review Comment: https://git.openjdk.org/jdk/pull/25228#discussion_r2106778974

Reply via email to