On Mon, 26 May 2025 08:16:03 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> On a 'german' Ubuntu 24 (LANG="de_DE.UTF-8") the jtreg test >> java/lang/System/LoggerFinder/internal/BootstrapLogger/BootstrapLoggerTest >> fails with >> >> >> FEIN: hi now! >> java.lang.RuntimeException: System.err does not contain: FINE: hi now! >> at BootstrapLoggerTest.main(BootstrapLoggerTest.java:231) >> at >> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) >> at java.base/java.lang.reflect.Method.invoke(Method.java:565) >> at >> com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138) >> at java.base/java.lang.Thread.run(Thread.java:1447) >> >> >> The test (and some others in :tier1 as well) do not work with non en/US >> LANG, so they need an adjustment. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > adjust LocalizedLevelName too Thanks for the patch! Restoring to the savedLocale at the end of main is not strictly needed since tests run in /othervm mode, but it's not wrong to restore it either. LGTM. Give me some time to test these proposed changes in our CI. ------------- PR Review: https://git.openjdk.org/jdk/pull/25441#pullrequestreview-2867904187
