Re: Missing throws declaration for NullPointerException in Proxy#getInvocationHandler

2025-05-22 Thread Alan Bateman
On 22/05/2025 21:33, Kevin Bourrillion wrote: I think Steffen is almost certainly right that this was an accidental omission. That omission results in the `@throws IAE` line being *interpreted* as also applying to null, but I doubt it was ever meant that way. I think adding a `@throws NPE` is

Re: RFR: 8357401: BigDecimal: Constants ONE_TENTH and ONE_HALF are unused after JDK-8341402

2025-05-22 Thread Joe Darcy
On Wed, 21 May 2025 00:59:34 GMT, Sergey Bylokhov wrote: > Both fields were added by the > [JDK-4851777](https://bugs.openjdk.org/browse/JDK-4851777): > see > https://github.com/openjdk/jdk/commit/4045a8be07195acac7fb2faef0e6bf90edcaf9f8 > And the usage were deleted by the > [JDK-8341402](http

Re: RFR: 8354475: TestDockerMemoryMetricsSubgroup.java fails with exitValue = 1 [v3]

2025-05-22 Thread PAWAN CHAWDHARY
> 8354475: TestDockerMemoryMetricsSubgroup.java fails with exitValue = 1 PAWAN CHAWDHARY has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge branch 'master' into 8354475 - Update TestDockerMemoryMetricsSubgroup.ja

Re: RFR: 8355798: Implement JEP 514: Ahead-of-Time Command Line Ergonomics [v12]

2025-05-22 Thread Ioi Lam
> This is the implementation of the draft [JEP: Ahead-of-time Command Line > Ergonomics](https://bugs.openjdk.org/browse/JDK-8350022) > > - Implemented new flag `AOTCacheOutput`, which can be used to create an AOT > cache using the "one-command workflow" > - Added processing of the `JDK_AOT_VM_O

Re: RFR: 8356985: Use "stdin.encoding" in Console's read*() methods [v5]

2025-05-22 Thread Stuart Marks
On Thu, 22 May 2025 17:46:33 GMT, Naoto Sato wrote: >> `java.io.Console` uses the charset specified by the `stdout.encoding` system >> property for both input and output. While this is generally sufficient, >> since Console is intended for interactive terminal use, some platforms allow >> diff

Re: RFR: 8357285 : JSR166 Test case testShutdownNow_delayedTasks failed

2025-05-22 Thread SendaoYan
On Thu, 22 May 2025 14:19:09 GMT, Viktor Klang wrote: > Barring other effects, it is likely that this test just needs to have some > longer timeouts to ensure that a stall isn't likely to fail the test case. > The shouldn't have any impact on test execution duration, as the test looks > at tas

Re: RFR: 8357081: Removed unused methods of HexDigits [v2]

2025-05-22 Thread Shaojin Wen
> In HexDigits, getCharsLatin1 and getCharsUTF16 are no longer used, so remove > these methods Shaojin Wen has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge remote-tracking branch 'upstream/master' into hexdigits_

Integrated: 8353741: Eliminate table lookup in UUID.toString

2025-05-22 Thread Shaojin Wen
On Mon, 6 Jan 2025 13:18:50 GMT, Shaojin Wen wrote: > Improve the performance of UUID::toString by using Long.expand and SWAR (SIMD > within a register) instead of table lookup. Eliminating the table lookup can > also avoid the performance degradation problem when the cache misses. This pull r

Re: Reducing Classloader's parallelLockMap memory consumption proposal

2025-05-22 Thread Dmytro Ukhlov
Hello Alan, Thank you for the useful information. Jenkins's class loader topology is hierarchical. I believe Jenkins can make its internal class loader implementations non-parallel capable. However, the problem persists because Jenkins pipelines are built on top of Groovy scripts. Running a pipeli

Re: RFR: 8356977: UTF-8 cleanups

2025-05-22 Thread Phil Race
On Wed, 14 May 2025 14:23:31 GMT, Magnus Ihse Bursie wrote: > I found a few other places in the code that can be cleaned up after the > conversion to UTF-8. src/java.desktop/share/classes/java/awt/MenuShortcut.java line 49: > 47: * For example, a menu shortcut for "Ctrl+cyrillic ef" is create

Re: RFR: 8356978: Convert unicode sequences in Java source code to UTF-8

2025-05-22 Thread Phil Race
On Wed, 14 May 2025 14:29:23 GMT, Magnus Ihse Bursie wrote: > After we converted the source base to be fully UTF-8, we do not need to use > unicode sequences (like \u0123) in string literals. Sometimes, that might > still make sense, as for control characters, non-breaking space, etc. But for

Re: RFR: 8356980: Better handling of non-breaking space

2025-05-22 Thread Phil Race
On Thu, 15 May 2025 12:33:06 GMT, Raffaello Giulietti wrote: >>> maybe this is just a translation error and a simple space can be used >>> instead, like in all the other properties in these files? >> >> That seems unlikely. The pattern is used consistently in the French >> translations, where

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v5]

2025-05-22 Thread Archie Cobbs
On Thu, May 22, 2025 at 3:31 PM John R Rose wrote: > > Update benchmark to reflect new fill method > > Related discussion at the hardware level: > > https://github.com/openjdk/jdk/pull/25147#issuecomment-2902463076 > This discussion spurred me to ask a dumb question. Apologies in advance, just

Re: RFR: 8354674: AArch64: Intrinsify Unsafe::setMemory [v8]

2025-05-22 Thread John R Rose
On Thu, 15 May 2025 16:03:44 GMT, Andrew Haley wrote: >> This intrinsic is generally faster than the current implementation for >> Panama segment operations for all writes larger than about 8 bytes in size, >> increasing to more than 2* the performance on larger memory blocks on >> Graviton 2,

Re: RFR: 8356985: Use "stdin.encoding" in Console's read*() methods [v5]

2025-05-22 Thread Justin Lu
On Thu, 22 May 2025 17:46:33 GMT, Naoto Sato wrote: >> `java.io.Console` uses the charset specified by the `stdout.encoding` system >> property for both input and output. While this is generally sufficient, >> since Console is intended for interactive terminal use, some platforms allow >> diff

Re: Missing throws declaration for NullPointerException in Proxy#getInvocationHandler

2025-05-22 Thread Kevin Bourrillion
I think Steffen is almost certainly right that this was an accidental omission. That omission results in the `@throws IAE` line being *interpreted* as also applying to null, but I doubt it was ever meant that way. I think adding a `@throws NPE` is the right fix, and makes the class more consist

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v5]

2025-05-22 Thread John R Rose
On Thu, 22 May 2025 11:52:34 GMT, Per Minborg wrote: >> This PR builds on a concept John Rose told me about some time ago. Instead >> of combining memory operations of various sizes, a single large and skewed >> memory operation can be made to clean up the tail of remaining bytes. >> >> This h

Re: Missing throws declaration for NullPointerException in Proxy#getInvocationHandler

2025-05-22 Thread Chen Liang
Hello, I have created https://bugs.openjdk.org/browse/JDK-8357597 for this. Your analysis isn't quite correct - if you look at the method documentation, you would anticipate this to fail with an IllegalArgumentException instead of a NullPointerException. However, this mismatch has been there sinc

Re: RFR: 8357401: BigDecimal: Constants ONE_TENTH and ONE_HALF are unused after JDK-8341402

2025-05-22 Thread Chen Liang
On Wed, 21 May 2025 00:59:34 GMT, Sergey Bylokhov wrote: > Both fields were added by the > [JDK-4851777](https://bugs.openjdk.org/browse/JDK-4851777): > see > https://github.com/openjdk/jdk/commit/4045a8be07195acac7fb2faef0e6bf90edcaf9f8 > And the usage were deleted by the > [JDK-8341402](http

Re: RFR: 8357401: BigDecimal: Constants ONE_TENTH and ONE_HALF are unused after JDK-8341402

2025-05-22 Thread Brian Burkhalter
On Wed, 21 May 2025 00:59:34 GMT, Sergey Bylokhov wrote: > Both fields were added by the > [JDK-4851777](https://bugs.openjdk.org/browse/JDK-4851777): > see > https://github.com/openjdk/jdk/commit/4045a8be07195acac7fb2faef0e6bf90edcaf9f8 > And the usage were deleted by the > [JDK-8341402](http

RFR: 8357401: BigDecimal: Constants ONE_TENTH and ONE_HALF are unused after JDK-8341402

2025-05-22 Thread Sergey Bylokhov
Both fields were added by the [JDK-4851777](https://bugs.openjdk.org/browse/JDK-4851777): see https://github.com/openjdk/jdk/commit/4045a8be07195acac7fb2faef0e6bf90edcaf9f8 And the usage were deleted by the [JDK-8341402](https://bugs.openjdk.org/browse/JDK-8341402): see https://github.com/openj

RFR: 8357171: Test tools/jpackage/windows/WinOSConditionTest.java fails for non administrator

2025-05-22 Thread Alexey Semenyuk
- Allow to configure multiple expected installation exit codes for jpackage native packaging tests. - Adjusted the test to get skipped if executed in a restricted environment that doesn't allow per-user installations for non-administrators. - Commit messages: - 8357171: Test tools

Re: RFR: 8357171: Test tools/jpackage/windows/WinOSConditionTest.java fails for non administrator

2025-05-22 Thread Alexey Semenyuk
On Thu, 22 May 2025 19:39:04 GMT, Alexey Semenyuk wrote: > - Allow to configure multiple expected installation exit codes for jpackage > native packaging tests. > - Adjusted the test to get skipped if executed in a restricted environment > that doesn't allow per-user installations for non-admi

Missing throws declaration for NullPointerException in Proxy#getInvocationHandler

2025-05-22 Thread Steffen Nießing
Hi, recently I've come across the documentation of Proxy#getInvocationHandler(Object) and recognized that there's a missing throws declaration for a NullPointerException. The expression Proxy.getInvocationHandler(null) fails, because proxy.getClass() is called without asserting that proxy is n

Re: RFR: 8357281: sun.util.Locale.LanguageTag should be immutable [v3]

2025-05-22 Thread Chen Liang
On Thu, 22 May 2025 17:51:32 GMT, Justin Lu wrote: >> _sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data >> carrier for Locale. The class, once created is not modified; the class >> should be made immutable. Converting the class to a record accomplishes this >> and also sim

Re: RFR: 8357285 : JSR166 Test case testShutdownNow_delayedTasks failed

2025-05-22 Thread Doug Lea
On Thu, 22 May 2025 14:59:04 GMT, Viktor Klang wrote: >> test/jdk/java/util/concurrent/tck/ScheduledExecutorTest.java line 703: >> >>> 701: final ScheduledThreadPoolExecutor p = new >>> ScheduledThreadPoolExecutor(1); >>> 702: List> tasks = new ArrayList<>(); >>> 703: fi

Re: RFR: 8357281: sun.util.Locale.LanguageTag should be immutable [v3]

2025-05-22 Thread Naoto Sato
On Thu, 22 May 2025 17:51:32 GMT, Justin Lu wrote: >> _sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data >> carrier for Locale. The class, once created is not modified; the class >> should be made immutable. Converting the class to a record accomplishes this >> and also sim

Re: RFR: 8356443: Update open/test/jdk/TEST.groups manual test groups definitions with missing manual test

2025-05-22 Thread Ivan Šipka
On Wed, 21 May 2025 15:37:34 GMT, serhiysachkov wrote: > Update open/test/jdk/TEST.groups manual test groups definitions with missing > manual test https://github.com/openjdk/jdk/blob/master/test/jdk/java/util/zip/ZipFile/CenSizeMaximum.java https://github.com/openjdk/jdk/blob/master/test/jdk/j

Re: RFR: 8356632: Fix remaining {@link/@linkplain} tags with refer to private/protected types in java.base [v2]

2025-05-22 Thread Chen Liang
On Thu, 22 May 2025 15:18:43 GMT, Nizar Benalla wrote: >> Please review this patch to fix some `javadoc` bugs in `java.base`. >> Certain `@link` tags used to refer to private fields instead of public APIs. >> >> A couple of `@see` tags in the [serialization >> page](https://download.java.net/ja

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v14]

2025-05-22 Thread Henry Jen
> This PR check the jar file to ensure entries are consistent from the central > directory and local file header. Also check there is no duplicate entry names > that could override the desired content by accident. Henry Jen has updated the pull request incrementally with one additional commit s

Re: RFR: 8357281: sun.util.Locale.LanguageTag should be immutable [v3]

2025-05-22 Thread Justin Lu
> _sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data > carrier for Locale. The class, once created is not modified; the class should > be made immutable. Converting the class to a record accomplishes this and > also simplifies some of the existing code. Justin Lu has updated

Re: RFR: 8357281: sun.util.Locale.LanguageTag should be immutable [v2]

2025-05-22 Thread Justin Lu
On Thu, 22 May 2025 17:14:03 GMT, Chen Liang wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> review: subtag -> subtags, switch on baseLang, improve fragility of list >> field accessors > > src/java.base/share/classes

Re: RFR: 8356985: Use "stdin.encoding" in Console's read*() methods [v2]

2025-05-22 Thread Naoto Sato
On Thu, 22 May 2025 16:39:46 GMT, Alan Bateman wrote: >> I'm confused by the actual behavior here. What might be helpful is to divide >> the discussion between a) what charsets get used for input and output, and >> b) the return value of the `charset()` method. >> >> I'm not entirely sure, but

Re: RFR: 8356985: Use "stdin.encoding" in Console's read*() methods [v5]

2025-05-22 Thread Naoto Sato
> `java.io.Console` uses the charset specified by the `stdout.encoding` system > property for both input and output. While this is generally sufficient, since > Console is intended for interactive terminal use, some platforms allow > different encodings to be configured for input and output. In

Re: RFR: 8357178: Simplify Class::componentType [v2]

2025-05-22 Thread Chen Liang
On Mon, 19 May 2025 00:22:08 GMT, Chen Liang wrote: >> `isArray` and null return is now redundant when `componentType` is changed >> to an explicit field. > > Chen Liang has updated the pull request incrementally with one additional > commit since the last revision: > > For parity with MT.de

Re: RFR: 8357281: sun.util.Locale.LanguageTag should be immutable [v2]

2025-05-22 Thread Steven Loomis
On Thu, 22 May 2025 16:46:10 GMT, Justin Lu wrote: >> _sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data >> carrier for Locale. The class, once created is not modified; the class >> should be made immutable. Converting the class to a record accomplishes this >> and also sim

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v6]

2025-05-22 Thread Henry Jen
On Wed, 14 May 2025 17:27:25 GMT, Lance Andersen wrote: >> UTF-8 messed up the index, we don't want any conversion to happen. >> Warning: Entry META-INFMAANIFEST.MF in local file header is not in central >> directory >> Warning: Entry META-INF/BANIFEST.MF in local file header is not in central

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v12]

2025-05-22 Thread Henry Jen
On Thu, 22 May 2025 11:42:04 GMT, Jaikiran Pai wrote: >> Henry Jen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Validator to take a file, use term JAR file > > test/jdk/tools/jar/ValidatorTest.java line 60: > >> 58: import jdk.test.l

Re: RFR: 8357281: sun.util.Locale.LanguageTag should be immutable [v2]

2025-05-22 Thread Chen Liang
On Thu, 22 May 2025 16:46:10 GMT, Justin Lu wrote: >> _sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data >> carrier for Locale. The class, once created is not modified; the class >> should be made immutable. Converting the class to a record accomplishes this >> and also sim

Integrated: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails

2025-05-22 Thread PAWAN CHAWDHARY
On Tue, 29 Apr 2025 13:04:15 GMT, PAWAN CHAWDHARY wrote: > 8352926: New test TestDockerMemoryMetricsSubgroup.java fails This pull request has now been integrated. Changeset: 9ca1004e Author:pawan chawdhary Committer: Mikhailo Seledtsov URL: https://git.openjdk.org/jdk/commit/9ca100

Re: RFR: 8357281: sun.util.Locale.LanguageTag should be immutable

2025-05-22 Thread Justin Lu
On Wed, 21 May 2025 21:19:36 GMT, Justin Lu wrote: > _sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data > carrier for Locale. The class, once created is not modified; the class should > be made immutable. Converting the class to a record accomplishes this and > also simplif

Re: RFR: 8357281: sun.util.Locale.LanguageTag should be immutable [v2]

2025-05-22 Thread Justin Lu
> _sun.util.Locale.LanguageTag_ is essentially a BCP47 language tag data > carrier for Locale. The class, once created is not modified; the class should > be made immutable. Converting the class to a record accomplishes this and > also simplifies some of the existing code. Justin Lu has updated

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v5]

2025-05-22 Thread John R Rose
On Thu, 22 May 2025 11:52:34 GMT, Per Minborg wrote: >> This PR builds on a concept John Rose told me about some time ago. Instead >> of combining memory operations of various sizes, a single large and skewed >> memory operation can be made to clean up the tail of remaining bytes. >> >> This h

Re: RFR: 8355022: Implement JEP 506: Scoped Values [v8]

2025-05-22 Thread Chen Liang
On Thu, 22 May 2025 15:09:12 GMT, Andrew Haley wrote: >> Propose to finalize scoped values. >> The only functional change is that the orElse() method no longer accepts a >> null argument. > > Andrew Haley has updated the pull request with a new target base due to a > merge or a rebase. The pull

Re: RFR: 8356985: Use "stdin.encoding" in Console's read*() methods [v2]

2025-05-22 Thread Alan Bateman
On Thu, 22 May 2025 16:15:56 GMT, Stuart Marks wrote: >> Good point. Brought the same wording to the `charset()` method description >> for further clarification. > > I'm confused by the actual behavior here. What might be helpful is to divide > the discussion between a) what charsets get used f

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v11]

2025-05-22 Thread Henry Jen
On Thu, 22 May 2025 12:25:04 GMT, Lance Andersen wrote: >> Non-zero could also mean negative which we currently do not do nor do,I see >> that going forward as part of future additions to validate > > We are somewhat inconsistent in documenting the exit code from our commands > as many do not i

Re: RFR: 8357285 : JSR166 Test case testShutdownNow_delayedTasks failed

2025-05-22 Thread Alan Bateman
On Thu, 22 May 2025 14:19:09 GMT, Viktor Klang wrote: > Barring other effects, it is likely that this test just needs to have some > longer timeouts to ensure that a stall isn't likely to fail the test case. > The shouldn't have any impact on test execution duration, as the test looks > at tas

Re: RFR: 8356985: Use "stdin.encoding" in Console's read*() methods [v2]

2025-05-22 Thread Stuart Marks
On Wed, 21 May 2025 16:48:20 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/io/Console.java line 67: >> >>> 65: * stdout.encoding}, in which case read operations use the {@code >>> Charset} >>> 66: * designated by {@code stdin.encoding}. >>> 67: * >> >> `Console.charset()` stat

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v13]

2025-05-22 Thread Henry Jen
> This PR check the jar file to ensure entries are consistent from the central > directory and local file header. Also check there is no duplicate entry names > that could override the desired content by accident. Henry Jen has updated the pull request incrementally with one additional commit s

Re: RFR: 8356632: Fix remaining {@link/@linkplain} tags with refer to private/protected types in java.base [v2]

2025-05-22 Thread Nizar Benalla
> Please review this patch to fix some `javadoc` bugs in `java.base`. > Certain `@link` tags used to refer to private fields instead of public APIs. > > A couple of `@see` tags in the [serialization > page](https://download.java.net/java/early_access/jdk25/docs/api/serialized-form.html#java.lang.

Re: RFR: 8355022: Implement JEP 506: Scoped Values [v8]

2025-05-22 Thread Andrew Haley
> Propose to finalize scoped values. > The only functional change is that the orElse() method no longer accepts a > null argument. Andrew Haley has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits: - Merge from JDK head - Fix

Re: RFR: 8357285 : JSR166 Test case testShutdownNow_delayedTasks failed

2025-05-22 Thread Viktor Klang
On Thu, 22 May 2025 14:55:21 GMT, Mikhail Yankelevich wrote: >> Barring other effects, it is likely that this test just needs to have some >> longer timeouts to ensure that a stall isn't likely to fail the test case. >> The shouldn't have any impact on test execution duration, as the test look

Re: RFR: 8357285 : JSR166 Test case testShutdownNow_delayedTasks failed

2025-05-22 Thread Mikhail Yankelevich
On Thu, 22 May 2025 14:19:09 GMT, Viktor Klang wrote: > Barring other effects, it is likely that this test just needs to have some > longer timeouts to ensure that a stall isn't likely to fail the test case. > The shouldn't have any impact on test execution duration, as the test looks > at tas

Re: RFR: 8357165: test java/lang/invoke/ClassValueTest.java fails intermittently [v2]

2025-05-22 Thread Chen Liang
On Wed, 21 May 2025 17:09:29 GMT, Chen Liang wrote: >> The test was originally written with product builds in mind; it didn't >> consider the slowness of debug builds, thus causing tests to fail. >> >> Also there was a bug in testWeakAgainstClassValue: the test need to flush >> the backing map

Integrated: 8357165: test java/lang/invoke/ClassValueTest.java fails intermittently

2025-05-22 Thread Chen Liang
On Sun, 18 May 2025 21:58:04 GMT, Chen Liang wrote: > The test was originally written with product builds in mind; it didn't > consider the slowness of debug builds, thus causing tests to fail. > > Also there was a bug in testWeakAgainstClassValue: the test need to flush the > backing map in t

RFR: 8357285 : JSR166 Test case testShutdownNow_delayedTasks failed

2025-05-22 Thread Viktor Klang
Barring other effects, it is likely that this test just needs to have some longer timeouts to ensure that a stall isn't likely to fail the test case. The shouldn't have any impact on test execution duration, as the test looks at tasks which *have not executed yet*. - Commit message

Re: RFR: 8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message

2025-05-22 Thread Viktor Klang
On Thu, 22 May 2025 02:09:08 GMT, He-Pin(kerr) wrote: >> @He-Pin Just pinging you here, in case the notification from my most recent >> comments got lost in transit. > > @viktorklang-ora @liach, I think we need a contribution guide that explains > how to set up the work in the IDE, how to perfo

Re: RFR: 8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message [v5]

2025-05-22 Thread Per Minborg
On Tue, 20 May 2025 10:54:44 GMT, He-Pin(kerr) wrote: >> Motivation: >> When a user passes a wrong parameter, the current implementation throws an >> IllegalArgumentException with an error message `null`, which is not helpful. >> >> Modification: >> Add detail error messages. >> >> Result: >>

Re: RFR: 8210549: Runtime.exec: in closeDescriptors(), use FD_CLOEXEC instead of close()

2025-05-22 Thread Roger Riggs
On Mon, 19 May 2025 12:23:07 GMT, Thomas Stuefe wrote: > Hi, please consider the following patch. > > This patch replaces the existing close-file-descriptors-logic we follow > before exec'ing a target binary: instead of explicitly closing the file > descriptors, we mark them as CLOEXEC. That s

Re: RFR: 8357462: Amend open/test/jdk//java/foreign/TestMatrix.java test scenario to run as manual [v2]

2025-05-22 Thread SendaoYan
On Thu, 22 May 2025 08:31:06 GMT, serhiysachkov wrote: >> Amend open/test/jdk//java/foreign/TestMatrix.java test scenario to run as >> manual > > serhiysachkov has updated the pull request incrementally with one additional > commit since the last revision: > > 8357462: copyright update LGTM

Integrated: 8357462: Amend open/test/jdk//java/foreign/TestMatrix.java test scenario to run as manual

2025-05-22 Thread serhiysachkov
On Wed, 21 May 2025 13:44:09 GMT, serhiysachkov wrote: > Amend open/test/jdk//java/foreign/TestMatrix.java test scenario to run as > manual This pull request has now been integrated. Changeset: 428d33ef Author:Serhiy Sachkov Committer: SendaoYan URL: https://git.openjdk.org/jdk/co

Re: RFR: 8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message [v5]

2025-05-22 Thread Chen Liang
On Tue, 20 May 2025 10:54:44 GMT, He-Pin(kerr) wrote: >> Motivation: >> When a user passes a wrong parameter, the current implementation throws an >> IllegalArgumentException with an error message `null`, which is not helpful. >> >> Modification: >> Add detail error messages. >> >> Result: >>

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v11]

2025-05-22 Thread Lance Andersen
On Thu, 22 May 2025 01:46:40 GMT, Lance Andersen wrote: >> I use exit code, but still keep non-zero instead of > 0. Leave that to >> future work if we want to have more specific value for exit code for >> different situations. > > Non-zero could also mean negative which we currently do not do n

Re: RFR: 8357462: Amend open/test/jdk//java/foreign/TestMatrix.java test scenario to run as manual [v2]

2025-05-22 Thread duke
On Thu, 22 May 2025 08:31:06 GMT, serhiysachkov wrote: >> Amend open/test/jdk//java/foreign/TestMatrix.java test scenario to run as >> manual > > serhiysachkov has updated the pull request incrementally with one additional > commit since the last revision: > > 8357462: copyright update @ser

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v12]

2025-05-22 Thread Jaikiran Pai
On Thu, 22 May 2025 01:29:12 GMT, Henry Jen wrote: >> This PR check the jar file to ensure entries are consistent from the central >> directory and local file header. Also check there is no duplicate entry >> names that could override the desired content by accident. > > Henry Jen has updated t

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v5]

2025-05-22 Thread Per Minborg
On Thu, 22 May 2025 11:52:34 GMT, Per Minborg wrote: >> This PR builds on a concept John Rose told me about some time ago. Instead >> of combining memory operations of various sizes, a single large and skewed >> memory operation can be made to clean up the tail of remaining bytes. >> >> This h

Re: RFR: 8357462: Amend open/test/jdk//java/foreign/TestMatrix.java test scenario to run as manual [v2]

2025-05-22 Thread Jorn Vernee
On Thu, 22 May 2025 08:31:06 GMT, serhiysachkov wrote: >> Amend open/test/jdk//java/foreign/TestMatrix.java test scenario to run as >> manual > > serhiysachkov has updated the pull request incrementally with one additional > commit since the last revision: > > 8357462: copyright update Mark

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v12]

2025-05-22 Thread Jaikiran Pai
On Thu, 22 May 2025 01:29:12 GMT, Henry Jen wrote: >> This PR check the jar file to ensure entries are consistent from the central >> directory and local file header. Also check there is no duplicate entry >> names that could override the desired content by accident. > > Henry Jen has updated t

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v5]

2025-05-22 Thread Per Minborg
> This PR builds on a concept John Rose told me about some time ago. Instead of > combining memory operations of various sizes, a single large and skewed > memory operation can be made to clean up the tail of remaining bytes. > > This has the effect of simplifying and shortening the code. The nu

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v12]

2025-05-22 Thread Jaikiran Pai
On Thu, 22 May 2025 01:29:12 GMT, Henry Jen wrote: >> This PR check the jar file to ensure entries are consistent from the central >> directory and local file header. Also check there is no duplicate entry >> names that could override the desired content by accident. > > Henry Jen has updated t

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v12]

2025-05-22 Thread Jaikiran Pai
On Thu, 22 May 2025 01:29:12 GMT, Henry Jen wrote: >> This PR check the jar file to ensure entries are consistent from the central >> directory and local file header. Also check there is no duplicate entry >> names that could override the desired content by accident. > > Henry Jen has updated t

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v12]

2025-05-22 Thread Jaikiran Pai
On Thu, 22 May 2025 11:20:18 GMT, Jaikiran Pai wrote: >> Henry Jen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Validator to take a file, use term JAR file > > src/jdk.jartool/share/classes/sun/tools/jar/Validator.java line 185: > >>

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v12]

2025-05-22 Thread Jaikiran Pai
On Thu, 22 May 2025 01:29:12 GMT, Henry Jen wrote: >> This PR check the jar file to ensure entries are consistent from the central >> directory and local file header. Also check there is no duplicate entry >> names that could override the desired content by accident. > > Henry Jen has updated t

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v2]

2025-05-22 Thread Per Minborg
On Thu, 22 May 2025 08:23:26 GMT, Shaojin Wen wrote: > Here you can use putShort/putInt/putLong to replace > putShortUnaligned/putIntUnaligned/putLongUnaligned The segment might be unaligned. For example, if it was sliced off an aligned segment. - PR Comment: https://git.openjdk.

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v4]

2025-05-22 Thread Per Minborg
> This PR builds on a concept John Rose told me about some time ago. Instead of > combining memory operations of various sizes, a single large and skewed > memory operation can be made to clean up the tail of remaining bytes. > > This has the effect of simplifying and shortening the code. The nu

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v2]

2025-05-22 Thread Per Minborg
On Thu, 22 May 2025 08:55:09 GMT, Maurizio Cimadamore wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Correct typo in comment > > src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java > line

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v3]

2025-05-22 Thread Per Minborg
> This PR builds on a concept John Rose told me about some time ago. Instead of > combining memory operations of various sizes, a single large and skewed > memory operation can be made to clean up the tail of remaining bytes. > > This has the effect of simplifying and shortening the code. The nu

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps

2025-05-22 Thread Per Minborg
On Thu, 22 May 2025 08:56:13 GMT, Maurizio Cimadamore wrote: > > Performance on an M1 Mac (Sequoia 15.4.1) > > Are the "regressions" for very big sizes related to this patch? By default, only segments that are smaller than 32 bytes will use the affected code. - PR Comment: https

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v11]

2025-05-22 Thread Jaikiran Pai
On Thu, 22 May 2025 01:41:51 GMT, Henry Jen wrote: >> src/jdk.jartool/share/classes/sun/tools/jar/Main.java line 454: >> >>> 452: new FileInputStream(file { >>> 453: >>> 454: return Validator.validate(this, zf, zis); >> >> I think it might be better to chang

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v12]

2025-05-22 Thread Jaikiran Pai
On Thu, 22 May 2025 01:29:12 GMT, Henry Jen wrote: >> This PR check the jar file to ensure entries are consistent from the central >> directory and local file header. Also check there is no duplicate entry >> names that could override the desired content by accident. > > Henry Jen has updated t

Re: RFR: 8345431: Improve jar --validate to detect duplicate or invalid entries [v12]

2025-05-22 Thread Jaikiran Pai
On Thu, 22 May 2025 01:29:12 GMT, Henry Jen wrote: >> This PR check the jar file to ensure entries are consistent from the central >> directory and local file header. Also check there is no duplicate entry >> names that could override the desired content by accident. > > Henry Jen has updated t

Re: RFR: 8210549: Runtime.exec: in closeDescriptors(), use FD_CLOEXEC instead of close()

2025-05-22 Thread Thomas Stuefe
On Wed, 21 May 2025 19:10:49 GMT, Roger Riggs wrote: >> Hi, please consider the following patch. >> >> This patch replaces the existing close-file-descriptors-logic we follow >> before exec'ing a target binary: instead of explicitly closing the file >> descriptors, we mark them as CLOEXEC. Tha

RFR: 8356443: Update open/test/jdk/TEST.groups manual test groups definitions with missing manual test

2025-05-22 Thread serhiysachkov
Update open/test/jdk/TEST.groups manual test groups definitions with missing manual test - Commit messages: - 8356443: Update open/test/jdk/TEST.groups manual test groups definitions with missing manual test Changes: https://git.openjdk.org/jdk/pull/25360/files Webrev: https://w

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v2]

2025-05-22 Thread Maurizio Cimadamore
On Thu, 22 May 2025 08:14:35 GMT, Per Minborg wrote: >> This PR builds on a concept John Rose told me about some time ago. Instead >> of combining memory operations of various sizes, a single large and skewed >> memory operation can be made to clean up the tail of remaining bytes. >> >> This h

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps

2025-05-22 Thread Maurizio Cimadamore
On Thu, 22 May 2025 07:36:51 GMT, Per Minborg wrote: > Performance on an M1 Mac (Sequoia 15.4.1) Are the "regressions" for very big sizes related to this patch? - PR Comment: https://git.openjdk.org/jdk/pull/25383#issuecomment-2900432766

Integrated: 8354323: Safeguard SwitchBootstraps.typeSwitch when used outside the compiler

2025-05-22 Thread Aggelos Biboudis
On Wed, 7 May 2025 11:57:02 GMT, Aggelos Biboudis wrote: > While the compiler does not allow invalid queries to flow into > `SwitchBootstraps:typeSwitch`, a library user could do that and `typeSwitch` > does not prevent such usage pattern errors resulting in erroneous evaluation. > > For exam

Withdrawn: 8356893: Use "stdin.encoding" for reading System.in with InputStreamReader/Scanner

2025-05-22 Thread Volkan Yazici
On Wed, 21 May 2025 20:56:31 GMT, Volkan Yazici wrote: > There are several locations in the JDK source where `System.in` and > `FileDescriptor.in` is read with `InputStreamReader` and `Scanner` using the > default charset. As recommended by the recently merged > [JDK-8356420](https://bugs.open

Re: RFR: 8357462: Amend open/test/jdk//java/foreign/TestMatrix.java test scenario to run as manual [v2]

2025-05-22 Thread serhiysachkov
> Amend open/test/jdk//java/foreign/TestMatrix.java test scenario to run as > manual serhiysachkov has updated the pull request incrementally with one additional commit since the last revision: 8357462: copyright update - Changes: - all: https://git.openjdk.org/jdk/pull/25355/

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v2]

2025-05-22 Thread Shaojin Wen
On Thu, 22 May 2025 08:14:35 GMT, Per Minborg wrote: >> This PR builds on a concept John Rose told me about some time ago. Instead >> of combining memory operations of various sizes, a single large and skewed >> memory operation can be made to clean up the tail of remaining bytes. >> >> This h

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v2]

2025-05-22 Thread Per Minborg
> This PR builds on a concept John Rose told me about some time ago. Instead of > combining memory operations of various sizes, a single large and skewed > memory operation can be made to clean up the tail of remaining bytes. > > This has the effect of simplifying and shortening the code. The nu

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v2]

2025-05-22 Thread Shaojin Wen
On Thu, 22 May 2025 08:11:09 GMT, Per Minborg wrote: >> This PR builds on a concept John Rose told me about some time ago. Instead >> of combining memory operations of various sizes, a single large and skewed >> memory operation can be made to clean up the tail of remaining bytes. >> >> This h

Re: RFR: 8356985: Use "stdin.encoding" in Console's read*() methods [v4]

2025-05-22 Thread Volkan Yazici
On Wed, 21 May 2025 19:29:08 GMT, Naoto Sato wrote: >> `java.io.Console` uses the charset specified by the `stdout.encoding` system >> property for both input and output. While this is generally sufficient, >> since Console is intended for interactive terminal use, some platforms allow >> diff

Re: RFR: 8356893: Use "stdin.encoding" for reading System.in with InputStreamReader/Scanner

2025-05-22 Thread Volkan Yazici
On Wed, 21 May 2025 21:37:07 GMT, Roger Riggs wrote: >> There are several locations in the JDK source where `System.in` and >> `FileDescriptor.in` is read with `InputStreamReader` and `Scanner` using the >> default charset. As recommended by the recently merged >> [JDK-8356420](https://bugs.op

Re: RFR: 8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message

2025-05-22 Thread Johannes Döbler
On Thu, 22 May 2025 07:26:29 GMT, Viktor Klang wrote: >> @viktorklang-ora @liach, I think we need a contribution guide that explains >> how to set up the work in the IDE, how to perform tests, etc. > > @He-Pin Please suggest improvements to https://openjdk.org/guide/ 👍 > @viktorklang-ora @liach

Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps

2025-05-22 Thread Per Minborg
On Thu, 22 May 2025 07:34:08 GMT, Per Minborg wrote: > This PR builds on a concept John Rose told me about some time ago. Instead of > combining memory operations of various sizes, a single large and skewed > memory operation can be made to clean up the tail of remaining bytes. > > This has th

RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps

2025-05-22 Thread Per Minborg
This PR builds on a concept John Rose told me about some time ago. Instead of combining memory operations of various sizes, a single large and skewed memory operation can be made to clean up the tail of remaining bytes. This has the effect of simplifying and shortening the code while improving

Re: RFR: 8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message

2025-05-22 Thread Viktor Klang
On Thu, 22 May 2025 02:09:08 GMT, He-Pin(kerr) wrote: >> @He-Pin Just pinging you here, in case the notification from my most recent >> comments got lost in transit. > > @viktorklang-ora @liach, I think we need a contribution guide that explains > how to set up the work in the IDE, how to perfo

Re: RFR: 8352642: Set zipinfo-time=false when constructing zipfs FileSystem in com.sun.tools.javac.file.JavacFileManager$ArchiveContainer for better performance

2025-05-22 Thread Viktor Klang
On Mon, 24 Mar 2025 22:33:56 GMT, Jason Zaugg wrote: >> Good catch, thanks! Ordinarily, I would say a test is required, but I can't >> think up a viable test to verify the effect of this change in a test, so we >> probably need to do it without a test. > >> Ordinarily, I would say a test is req

Integrated: 8352642: Set zipinfo-time=false when constructing zipfs FileSystem in com.sun.tools.javac.file.JavacFileManager$ArchiveContainer for better performance

2025-05-22 Thread Jason Zaugg
On Sun, 23 Mar 2025 12:38:04 GMT, Jason Zaugg wrote: > zipfs has a (undocumented) property "zipinfo-time" which was introduced in > https://bugs.openjdk.org/browse/JDK-8150496 to help improve performance of > the ZipFileSystem. When a ZipFileSystem is created with this property's value > set t

Re: RFR: 8356995: Provide default methods min(T, T) and max(T, T) in Comparator interface [v2]

2025-05-22 Thread Tagir F . Valeev
On Wed, 21 May 2025 11:55:16 GMT, Raffaello Giulietti wrote: >> Tagir F. Valeev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Return first argument in case of tie (to be consistent with >> BinaryOperator); junit tests > > test/jdk/ja

  1   2   >