On Wed, 14 May 2025 14:23:31 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> I found a few other places in the code that can be cleaned up after the
> conversion to UTF-8.
src/java.desktop/share/classes/java/awt/MenuShortcut.java line 49:
> 47: * For example, a menu shortcut for "Ctrl+cyrillic ef" is created by
> 48: * <p>
> 49: * <code>MenuShortcut ms = new
> MenuShortcut(KeyEvent.getExtendedKeyCodeForChar('ф'), false);</code>
This is javadoc inJava SE specification. As is the Action case below.
I can't think of any actual harm from this change, so OK, but I am not seeing
why it is needed.
test/jdk/java/awt/font/TextLayout/RotFontBoundsTest.java line 63:
> 61:
> 62: private static final String INSTRUCTIONS =
> 63: "A string \u201C" + TEXT + "\u201D is drawn at eight
> different "
I really don't like these tests being changed. It isn't part of the JDK build.
People compile these in all sorts of locales.
Please revert all the changes in the client tests.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25228#discussion_r2103439338
PR Review Comment: https://git.openjdk.org/jdk/pull/25228#discussion_r2103431874
