[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6973: Implement PassThroughTransformOperator to optimize select queries(#6972)

siddharthteotia commented on a change in pull request #6973: URL: https://github.com/apache/incubator-pinot/pull/6973#discussion_r640037165 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/PassThroughTransformOperator.java ## @@ -0,0 +1,52 @@ +/*

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

chenboat commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r640038408 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -595,6 +6

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

chenboat commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r640039251 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -1214,4 +

[GitHub] [incubator-pinot] mcvsubbu commented on pull request #6976: Fix deep store directory structure

mcvsubbu commented on pull request #6976: URL: https://github.com/apache/incubator-pinot/pull/6976#issuecomment-849038087 Marking this with backward-incompat and release-notes labels in case the @chenboat 's commit made it to the prior release. @chenboat please remove the labels if your c

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6969: Fix partial comparison for realtime table and allow keep cluster on failure

mcvsubbu commented on a change in pull request #6969: URL: https://github.com/apache/incubator-pinot/pull/6969#discussion_r640043943 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/SqlResultComparator.java ## @@ -113,9 +126,147 @@ public stati

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

chenboat commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r640048924 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -1214,4 +

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

chenboat commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r640048924 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -1214,4 +

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6977: Enhance debug endpoint for table debugging.

codecov-commenter edited a comment on pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#issuecomment-848396506 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6977?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6985: Replace gcp hardcoded values with generic annotations

codecov-commenter commented on pull request #6985: URL: https://github.com/apache/incubator-pinot/pull/6985#issuecomment-849063649 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6985?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] GSharayu commented on a change in pull request #6973: Implement PassThroughTransformOperator to optimize select queries(#6972)

GSharayu commented on a change in pull request #6973: URL: https://github.com/apache/incubator-pinot/pull/6973#discussion_r640091769 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/PassThroughTransformOperator.java ## @@ -0,0 +1,52 @@ +/** + * L

[GitHub] [incubator-pinot] GSharayu opened a new pull request #6986: Implement PassThroughTransformOperator to optimize select queries followup (#6972)

GSharayu opened a new pull request #6986: URL: https://github.com/apache/incubator-pinot/pull/6986 For general select queries e.g SELECT * FROM Foo . LIMIT N e.g SELECT col1, col2 . FROM Foo LIMIT N the columns are identifier expressions and not some transfo

[GitHub] [incubator-pinot] SabrinaZhaozyf opened a new pull request #6987: testing pr

SabrinaZhaozyf opened a new pull request #6987: URL: https://github.com/apache/incubator-pinot/pull/6987 ## Description ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **backwa

[GitHub] [incubator-pinot] SabrinaZhaozyf closed pull request #6987: testing pr

SabrinaZhaozyf closed pull request #6987: URL: https://github.com/apache/incubator-pinot/pull/6987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [incubator-pinot] kriti-sc commented on a change in pull request #6873: feature/#6766 JSON and Startree index information in API

kriti-sc commented on a change in pull request #6873: URL: https://github.com/apache/incubator-pinot/pull/6873#discussion_r640118402 ## File path: pinot-server/src/test/java/org/apache/pinot/server/api/TablesResourceTest.java ## @@ -273,6 +273,7 @@ public void testOfflineTable

[GitHub] [incubator-pinot] kriti-sc commented on a change in pull request #6873: feature/#6766 JSON and Startree index information in API

kriti-sc commented on a change in pull request #6873: URL: https://github.com/apache/incubator-pinot/pull/6873#discussion_r640118402 ## File path: pinot-server/src/test/java/org/apache/pinot/server/api/TablesResourceTest.java ## @@ -273,6 +273,7 @@ public void testOfflineTable

[GitHub] [incubator-pinot] kriti-sc commented on a change in pull request #6873: feature/#6766 JSON and Startree index information in API

kriti-sc commented on a change in pull request #6873: URL: https://github.com/apache/incubator-pinot/pull/6873#discussion_r640132726 ## File path: pinot-server/src/main/java/org/apache/pinot/server/api/resources/SegmentMetadataFetcher.java ## @@ -128,8 +139,50 @@ public static

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6873: feature/#6766 JSON and Startree index information in API

codecov-commenter edited a comment on pull request #6873: URL: https://github.com/apache/incubator-pinot/pull/6873#issuecomment-840887487 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6873?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] laxmanchekka opened a new issue #6988: Realtime to Offline segment conversion task fails to progress with data gaps

laxmanchekka opened a new issue #6988: URL: https://github.com/apache/incubator-pinot/issues/6988 Realtime to Offline segment conversion task fails to progress when there are larger data gaps in REALTIME table. Noticed when the data gap is larger than the bucketTimePeriod. -- This

[GitHub] [incubator-pinot] laxmanchekka commented on issue #6988: Realtime to Offline segment conversion task fails to progress with data gaps

laxmanchekka commented on issue #6988: URL: https://github.com/apache/incubator-pinot/issues/6988#issuecomment-849166907 @Jackie-Jiang @npawar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [incubator-pinot] laxmanchekka opened a new issue #6989: Realtime to Offline segment conversion: Provision for rolling offline segments based on segment size

laxmanchekka opened a new issue #6989: URL: https://github.com/apache/incubator-pinot/issues/6989 REALTIME tables segment size can be controlled using `realtime.segment.flush.threshold.segment.size` (say "100M") We don't have any similar configuration for OFFLINE tables which can be used

[GitHub] [incubator-pinot] laxmanchekka commented on issue #6989: Realtime to Offline segment conversion: Provision for rolling offline segments based on segment size

laxmanchekka commented on issue #6989: URL: https://github.com/apache/incubator-pinot/issues/6989#issuecomment-849169088 @Jackie-Jiang @npawar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [incubator-pinot] siddharthteotia merged pull request #6986: Implement PassThroughTransformOperator to optimize select queries followup (#6972)

siddharthteotia merged pull request #6986: URL: https://github.com/apache/incubator-pinot/pull/6986 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [incubator-pinot] kriti-sc commented on pull request #6873: feature/#6766 JSON and Startree index information in API

kriti-sc commented on pull request #6873: URL: https://github.com/apache/incubator-pinot/pull/6873#issuecomment-849171984 @Jackie-Jiang the tests are passing, this PR is ready to be merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-pinot] GSharayu opened a new pull request #6990: Fix the race condition in realtime text index refresh thread (#6858)

GSharayu opened a new pull request #6990: URL: https://github.com/apache/incubator-pinot/pull/6990 The refresh thread maintains a single global queue of realtime text index readers across all consuming segments across all tables. A reader is polled, refreshed and supposed to be added

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6990: Fix the race condition in realtime text index refresh thread (#6858)

codecov-commenter commented on pull request #6990: URL: https://github.com/apache/incubator-pinot/pull/6990#issuecomment-849210085 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6990?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6873: feature/#6766 JSON and Startree index information in API

Jackie-Jiang merged pull request #6873: URL: https://github.com/apache/incubator-pinot/pull/6873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6990: Fix the race condition in realtime text index refresh thread (#6858)

codecov-commenter edited a comment on pull request #6990: URL: https://github.com/apache/incubator-pinot/pull/6990#issuecomment-849210085 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6990?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6977: Enhance debug endpoint for table debugging.

codecov-commenter edited a comment on pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#issuecomment-848396506 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6977?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] wuwenw opened a new pull request #6991: Introduce in-Segment Trim for GroupBy OrderBy Query

wuwenw opened a new pull request #6991: URL: https://github.com/apache/incubator-pinot/pull/6991 ## Description One of the major bottlenecks for the current GroupBy OrderBy query on high cardinality columns is the merge phase. Essentially every segment brings a large number of inter

[GitHub] [incubator-pinot] npawar opened a new issue #6992: End-to-end integration test for Kinesis connector

npawar opened a new issue #6992: URL: https://github.com/apache/incubator-pinot/issues/6992 We added Kinesis integration https://github.com/apache/incubator-pinot/pull/6661 We need an integration test which can start Kinesis locally, and then test the whole realtime consumption end to e

[GitHub] [incubator-pinot] npawar commented on issue #6992: End-to-end integration test for Kinesis connector

npawar commented on issue #6992: URL: https://github.com/apache/incubator-pinot/issues/6992#issuecomment-849242998 https://github.com/apache/incubator-pinot/issues/5648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-pinot] npawar commented on pull request #6661: Add Kinesis Stream Ingestion Plugin

npawar commented on pull request #6661: URL: https://github.com/apache/incubator-pinot/pull/6661#issuecomment-849243455 > If there is a way to start kinesis locally and run some integration tests that will be awesome. Can be a separate PR. Last when @KKcorps was trying this out, he h

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6661: Add Kinesis Stream Ingestion Plugin

codecov-commenter commented on pull request #6661: URL: https://github.com/apache/incubator-pinot/pull/6661#issuecomment-849265905 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6661?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6991: Introduce in-Segment Trim for GroupBy OrderBy Query

Jackie-Jiang commented on a change in pull request #6991: URL: https://github.com/apache/incubator-pinot/pull/6991#discussion_r640240892 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/IntermediateResultsBlock.java ## @@ -117,6 +119,19 @@ public In

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6661: Add Kinesis Stream Ingestion Plugin

codecov-commenter edited a comment on pull request #6661: URL: https://github.com/apache/incubator-pinot/pull/6661#issuecomment-849265905 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6661?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6991: Introduce in-Segment Trim for GroupBy OrderBy Query

siddharthteotia commented on a change in pull request #6991: URL: https://github.com/apache/incubator-pinot/pull/6991#discussion_r640251385 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java ## @@ -61,7 +61,11 @@ public stat

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6980: Unify the minion plug-in package regex path

Jackie-Jiang merged pull request #6980: URL: https://github.com/apache/incubator-pinot/pull/6980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6991: Introduce in-Segment Trim for GroupBy OrderBy Query

Jackie-Jiang commented on a change in pull request #6991: URL: https://github.com/apache/incubator-pinot/pull/6991#discussion_r640285940 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java ## @@ -61,7 +61,11 @@ public static

[GitHub] [incubator-pinot] jackjlli opened a new pull request #6993: Add annotation for deprecated fields in TableConfigBuilder

jackjlli opened a new pull request #6993: URL: https://github.com/apache/incubator-pinot/pull/6993 ## Description This PR adds annotation for deprecated fields segmentPushType and segmentPushFrequency in `TableConfigBuilder` class. ## Upgrade Notes Does this PR prevent a zero d

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

Jackie-Jiang commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640297369 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/debug/TableDebugInfo.java ## @@ -102,21 +113,71 @@ public int g

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6993: Add annotation for deprecated fields in TableConfigBuilder

codecov-commenter commented on pull request #6993: URL: https://github.com/apache/incubator-pinot/pull/6993#issuecomment-849367065 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6993?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6927: Normalize LHS and RHS numerical types for >, >=, <, and <= operators.

siddharthteotia commented on a change in pull request #6927: URL: https://github.com/apache/incubator-pinot/pull/6927#discussion_r640770793 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java ## @@ -80,22 +83,29 @@

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6927: Normalize LHS and RHS numerical types for >, >=, <, and <= operators.

siddharthteotia commented on a change in pull request #6927: URL: https://github.com/apache/incubator-pinot/pull/6927#discussion_r640771794 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java ## @@ -271,7 +242,211 @

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6927: Normalize LHS and RHS numerical types for >, >=, <, and <= operators.

siddharthteotia commented on a change in pull request #6927: URL: https://github.com/apache/incubator-pinot/pull/6927#discussion_r640777126 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java ## @@ -271,7 +242,211 @

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6927: Normalize LHS and RHS numerical types for >, >=, <, and <= operators.

siddharthteotia commented on a change in pull request #6927: URL: https://github.com/apache/incubator-pinot/pull/6927#discussion_r640789829 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java ## @@ -271,7 +242,211 @

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640790441 ## File path: pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentServerDebugInfo.java ## @@ -0,0 +1,62 @@ +/** + * L

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640791087 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableDebugResource.java ## @@ -156,38 +177,94 @@ priva

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640791864 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -228,4 +240,20 @@ public String get

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640796662 ## File path: pinot-server/src/main/java/org/apache/pinot/server/api/resources/ServerResourceUtils.java ## @@ -0,0 +1,58 @@ +/** + * Licensed

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6932: Add constants and metadata properties for MergeRollupTask:

jtao15 commented on a change in pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932#discussion_r640801157 ## File path: pinot-core/src/main/java/org/apache/pinot/core/minion/rollup/MergeRollupSegmentConverter.java ## @@ -45,16 +49,16 @@ private Tabl

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6927: Normalize LHS and RHS numerical types for >, >=, <, and <= operators.

amrishlal commented on a change in pull request #6927: URL: https://github.com/apache/incubator-pinot/pull/6927#discussion_r640840045 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java ## @@ -80,22 +83,29 @@ public

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6927: Normalize LHS and RHS numerical types for >, >=, <, and <= operators.

amrishlal commented on a change in pull request #6927: URL: https://github.com/apache/incubator-pinot/pull/6927#discussion_r640840142 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java ## @@ -271,7 +242,211 @@ priv

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6927: Normalize LHS and RHS numerical types for >, >=, <, and <= operators.

amrishlal commented on a change in pull request #6927: URL: https://github.com/apache/incubator-pinot/pull/6927#discussion_r640850582 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java ## @@ -271,7 +242,211 @@ priv

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6927: Normalize LHS and RHS numerical types for >, >=, <, and <= operators.

amrishlal commented on a change in pull request #6927: URL: https://github.com/apache/incubator-pinot/pull/6927#discussion_r640852691 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/NumericalFilterOptimizer.java ## @@ -271,7 +242,211 @@ priv

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

Jackie-Jiang commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640859147 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableDebugResource.java ## @@ -156,38 +177,94 @@ priv

[GitHub] [incubator-pinot] oker1 opened a new pull request #6994: Realtime to offline save space

oker1 opened a new pull request #6994: URL: https://github.com/apache/incubator-pinot/pull/6994 ## Description We saw high disk usage when using RealtimeToOfflineSegmentsTask, and as I looked into the code I've found that it keeps lots of temporary files around until the whole task

[GitHub] [incubator-pinot] oker1 opened a new issue #6995: RealtimeToOfflineSegmentsTask uses too much disk space relative to segments size

oker1 opened a new issue #6995: URL: https://github.com/apache/incubator-pinot/issues/6995 Proposed change: https://github.com/apache/incubator-pinot/pull/6994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mcvsubbu commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640807315 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/debug/TableDebugInfo.java ## @@ -102,21 +113,71 @@ public int getNu

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640869225 ## File path: pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentServerDebugInfo.java ## @@ -0,0 +1,62 @@ +/** + * L

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640869225 ## File path: pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentServerDebugInfo.java ## @@ -0,0 +1,62 @@ +/** + * L

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mcvsubbu commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640869998 ## File path: pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentServerDebugInfo.java ## @@ -0,0 +1,62 @@ +/** + * Lice

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640870146 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/debug/TableDebugInfo.java ## @@ -102,21 +113,71 @@ public int ge

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6991: Introduce in-Segment Trim for GroupBy OrderBy Query

codecov-commenter commented on pull request #6991: URL: https://github.com/apache/incubator-pinot/pull/6991#issuecomment-849847415 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6991?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6993: Add annotation for deprecated fields in TableConfigBuilder

codecov-commenter edited a comment on pull request #6993: URL: https://github.com/apache/incubator-pinot/pull/6993#issuecomment-849367065 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6993?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640870146 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/debug/TableDebugInfo.java ## @@ -102,21 +113,71 @@ public int ge

[GitHub] [incubator-pinot] jackjlli merged pull request #6993: Add annotation for deprecated fields in TableConfigBuilder

jackjlli merged pull request #6993: URL: https://github.com/apache/incubator-pinot/pull/6993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640874473 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableDebugResource.java ## @@ -63,6 +79,8 @@ @Api(tag

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6991: Introduce in-Segment Trim for GroupBy OrderBy Query

codecov-commenter edited a comment on pull request #6991: URL: https://github.com/apache/incubator-pinot/pull/6991#issuecomment-849847415 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6991?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640879901 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/debug/TableDebugInfo.java ## @@ -102,21 +113,71 @@ public int ge

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640880513 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -59,9 +65,14 @@ protected HelixM

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640881513 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerConfig.java ## @@ -103,7 +103,11 @@

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640883715 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableDebugResource.java ## @@ -253,4 +330,46 @@ privat

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6927: Normalize LHS and RHS numerical types for >, >=, <, and <= operators.

codecov-commenter edited a comment on pull request #6927: URL: https://github.com/apache/incubator-pinot/pull/6927#issuecomment-841713694 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6927?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] jtao15 commented on issue #6979: SegmentProcessorFramework improvements for merge/rollup

jtao15 commented on issue #6979: URL: https://github.com/apache/incubator-pinot/issues/6979#issuecomment-849869980 Besides the time partition, it's good to make the resulted segment name configurable also. Listing down the requirements of the improvements: 1. Time partition - Partiti

[GitHub] [incubator-pinot] jtao15 edited a comment on issue #6979: SegmentProcessorFramework improvements for merge/rollup

jtao15 edited a comment on issue #6979: URL: https://github.com/apache/incubator-pinot/issues/6979#issuecomment-849869980 Besides the time partition, it's good to make the resulted segment name configurable also. Listing down the requirements of the improvements: 1. Time partition -

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6977: Enhance debug endpoint for table debugging.

codecov-commenter edited a comment on pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#issuecomment-848396506 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6977?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mayankshriv commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640928843 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableDebugResource.java ## @@ -156,38 +177,94 @@ priva

[GitHub] [incubator-pinot] yupeng9 commented on issue #6904: Complex type handling

yupeng9 commented on issue #6904: URL: https://github.com/apache/incubator-pinot/issues/6904#issuecomment-849938401 User docs is at https://docs.pinot.apache.org/basics/data-import/complex-type This will be released as part of 0.8 -- This is an automated message from the Apache Git Se

[GitHub] [incubator-pinot] yupeng9 closed issue #6904: Complex type handling

yupeng9 closed issue #6904: URL: https://github.com/apache/incubator-pinot/issues/6904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mcvsubbu commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640983000 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/debug/TableDebugInfo.java ## @@ -102,21 +113,71 @@ public int getNu

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mcvsubbu commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640988017 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerConfig.java ## @@ -103,7 +103,11 @@ //

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

mcvsubbu commented on a change in pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640988649 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -59,9 +65,14 @@ protected HelixMana

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6932: Add constants and metadata properties for MergeRollupTask:

jtao15 commented on a change in pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932#discussion_r640997717 ## File path: pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/merge_rollup/MergeRollupTaskU

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6932: Add constants and metadata properties for MergeRollupTask:

jtao15 commented on a change in pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932#discussion_r640998080 ## File path: pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/merge_rollup/MergeRollupTaskU

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6932: Add constants and metadata properties for MergeRollupTask:

jtao15 commented on a change in pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932#discussion_r640998631 ## File path: pinot-common/src/main/java/org/apache/pinot/common/minion/MergeRollupTaskMetadata.java ## @@ -0,0 +1,95 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] npawar opened a new pull request #6996: Remove constructor from base class ColumnIndexDirectory

npawar opened a new pull request #6996: URL: https://github.com/apache/incubator-pinot/pull/6996 The parameters of the constructor in the base class will not make sense for an implementation which doesn't have segmentDirectory on the local disk -- This is an automated message from the Ap

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6932: Add constants and metadata properties for MergeRollupTask:

snleee commented on a change in pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932#discussion_r641017470 ## File path: pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/merge_rollup/MergeRollupTaskU

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6932: Add constants and metadata properties for MergeRollupTask:

codecov-commenter edited a comment on pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932#issuecomment-842768635 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6932?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6994: Realtime to offline space saving

Jackie-Jiang commented on a change in pull request #6994: URL: https://github.com/apache/incubator-pinot/pull/6994#discussion_r641020167 ## File path: pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/realtime_to_offline_seg

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6932: Add constants and metadata properties for MergeRollupTask:

snleee commented on a change in pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932#discussion_r641022730 ## File path: pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/merge_rollup/MergeRollupTaskU

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6996: Remove constructor from base class ColumnIndexDirectory

codecov-commenter commented on pull request #6996: URL: https://github.com/apache/incubator-pinot/pull/6996#issuecomment-84702 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6996?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6996: Remove constructor from base class ColumnIndexDirectory

codecov-commenter edited a comment on pull request #6996: URL: https://github.com/apache/incubator-pinot/pull/6996#issuecomment-84702 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6996?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] harishks commented on issue #6487: Adding numStartreeUsed in query stats

harishks commented on issue #6487: URL: https://github.com/apache/incubator-pinot/issues/6487#issuecomment-850006774 Will be happy to pick this one up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6994: Realtime to offline space saving

codecov-commenter commented on pull request #6994: URL: https://github.com/apache/incubator-pinot/pull/6994#issuecomment-850013482 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6994?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6661: Add Kinesis Stream Ingestion Plugin

codecov-commenter edited a comment on pull request #6661: URL: https://github.com/apache/incubator-pinot/pull/6661#issuecomment-849265905 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6661?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] npawar merged pull request #6661: Add Kinesis Stream Ingestion Plugin

npawar merged pull request #6661: URL: https://github.com/apache/incubator-pinot/pull/6661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6932: Add constants and metadata properties for MergeRollupTask:

jtao15 commented on a change in pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932#discussion_r641081625 ## File path: pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/merge_rollup/MergeRollupTaskU

[GitHub] [incubator-pinot] jtao15 commented on a change in pull request #6932: Add constants and metadata properties for MergeRollupTask:

jtao15 commented on a change in pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932#discussion_r641082054 ## File path: pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/merge_rollup/MergeRollupTaskU

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6932: Add constants and metadata properties for MergeRollupTask:

snleee commented on a change in pull request #6932: URL: https://github.com/apache/incubator-pinot/pull/6932#discussion_r641084466 ## File path: pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/merge_rollup/MergeProperties.

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #6997: Add genericRow file reader and writer

Jackie-Jiang opened a new pull request #6997: URL: https://github.com/apache/incubator-pinot/pull/6997 ## Description Add file reader and writer for genericRow leveraging the ser/de classes Replace the usage of ser/de to the file reader/writer -- This is an automated message from th

<    5   6   7   8   9   10   11   12   13   14   >