mcvsubbu commented on a change in pull request #6977:
URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640988649
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java
##########
@@ -59,9 +65,14 @@
protected HelixManager _helixManager;
protected String _authToken;
+ // Fixed size LRU cache with InstanceName - SegmentName pair as key, and
segment related
+ // errors as the value.
+ protected LoadingCache<Pair<String, String>, SegmentErrorInfo> _errorCache;
Review comment:
I think you mean single instance hosting multiple tables, in which case,
the comment in line 68 should be "tableName - segmetName" pair as opposed to
"instanceName - segmentName" pair?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
