mcvsubbu commented on a change in pull request #6977:
URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r640988017
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerConfig.java
##########
@@ -103,7 +103,11 @@
//
private static final String MAX_PARALLEL_REFRESH_THREADS =
"max.parallel.refresh.threads";
+ // Size of cache that holds errors.
+ private static final String ERROR_CACHE_SIZE = "error.cache.size";
+
private final static String[] REQUIRED_KEYS = {INSTANCE_ID,
INSTANCE_DATA_DIR, READ_MODE};
+ private static final long DEFAULT_ERROR_CACHE_SIZE = 100L;
Review comment:
ok, fair point. We will change at our end, if needed. And yes, the
memory used will be relatively small, given it is a per instance cache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
