Re: [PR] Upgrade jettison version to fix CVE [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12567: URL: https://github.com/apache/pinot/pull/12567#issuecomment-1980390577 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12567?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [I] Seems text_match() function doesn't support search with '#' character [pinot]

2024-03-06 Thread via GitHub
Betternan commented on issue #12262: URL: https://github.com/apache/pinot/issues/12262#issuecomment-1980396890 @Jackie-Jiang Seems no response for this kinds of problem. But this is major case I met, do you have any idea how can I solve this problem? -- This is an automated message fr

[PR] Enhance json index to support regexp and range predicate evaluation [pinot]

2024-03-06 Thread via GitHub
saurabhd336 opened a new pull request, #12568: URL: https://github.com/apache/pinot/pull/12568 Added support for REGEXP_LIKE and RANGE predicate evaluation on a json path's values using json index -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Json extract index mv + range and regexp evaluation support with json index [pinot]

2024-03-06 Thread via GitHub
saurabhd336 commented on PR #12532: URL: https://github.com/apache/pinot/pull/12532#issuecomment-1980403389 @Jackie-Jiang I've broken it into 2 prs. Please look at https://github.com/apache/pinot/pull/12568 for the json index enhancements, once that is merged I can update this PR for the `j

Re: [PR] Allow passing database context through `database` http header [pinot]

2024-03-06 Thread via GitHub
shounakmk219 commented on code in PR #12417: URL: https://github.com/apache/pinot/pull/12417#discussion_r1514093985 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java: ## @@ -320,6 +321,11 @@ protected BrokerResponse handleRequest(

Re: [PR] Allow passing database context through `database` http header [pinot]

2024-03-06 Thread via GitHub
shounakmk219 commented on code in PR #12417: URL: https://github.com/apache/pinot/pull/12417#discussion_r1514104794 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java: ## @@ -1652,6 +1648,7 @@ private static void fixColumnName(Stri

Re: [PR] Allow passing database context through `database` http header [pinot]

2024-03-06 Thread via GitHub
shounakmk219 commented on code in PR #12417: URL: https://github.com/apache/pinot/pull/12417#discussion_r1514109569 ## pinot-common/src/main/java/org/apache/pinot/common/config/provider/TableCache.java: ## @@ -71,6 +73,8 @@ public class TableCache implements PinotConfigProvider

Re: [PR] Allow passing database context through `database` http header [pinot]

2024-03-06 Thread via GitHub
shounakmk219 commented on code in PR #12417: URL: https://github.com/apache/pinot/pull/12417#discussion_r1514117098 ## pinot-common/src/main/java/org/apache/pinot/common/utils/DatabaseUtils.java: ## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Upgrade jettison version to fix CVE [pinot]

2024-03-06 Thread via GitHub
xiangfu0 merged PR #12567: URL: https://github.com/apache/pinot/pull/12567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch master updated (2e84561985 -> 5e14029ac3)

2024-03-06 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 2e84561985 fixing CVE critical issues by resolving kerby/jline and wildfly libraries (#12566) add 5e14029ac3 upg

[PR] Bump org.codehaus.jettison:jettison from 1.4.0 to 1.5.4 [pinot]

2024-03-06 Thread via GitHub
dependabot[bot] opened a new pull request, #12569: URL: https://github.com/apache/pinot/pull/12569 Bumps [org.codehaus.jettison:jettison](https://github.com/jettison-json/jettison) from 1.4.0 to 1.5.4. Release notes Sourced from https://github.com/jettison-json/jettison/releases";

(pinot) branch dependabot/maven/org.codehaus.jettison-jettison-1.5.4 created (now 00447b8c89)

2024-03-06 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.codehaus.jettison-jettison-1.5.4 in repository https://gitbox.apache.org/repos/asf/pinot.git at 00447b8c89 Bump org.codehaus.jettison:jettison from 1.4.0 to 1.5.4

Re: [PR] Enhance json index to support regexp and range predicate evaluation [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12568: URL: https://github.com/apache/pinot/pull/12568#issuecomment-1980474531 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12568?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [I] Allow download plugins on demand at runtime [pinot]

2024-03-06 Thread via GitHub
hpvd commented on issue #12564: URL: https://github.com/apache/pinot/issues/12564#issuecomment-1980506181 yep, another reason for "going small" is security. The less unneeded code is included (own and from dependencies), the fewer security vulnerabilities are delivered or can arise later...

[PR] Fixing high severity CVEs in pinot-adls/pinot-orc/pinot-parquet [pinot]

2024-03-06 Thread via GitHub
xiangfu0 opened a new pull request, #12571: URL: https://github.com/apache/pinot/pull/12571 1. Consolidate `net.minidev:json-smart` to version 2.5.0 2. Consolidate `org.wildfly.openssl:wildfly-openssl` to version 1.1.3.Final 3. Consolidate `org.wildfly.openssl:wildfly-openssl-java` to v

Re: [PR] Fixing high severity CVEs in pinot-adls/pinot-orc/pinot-parquet [pinot]

2024-03-06 Thread via GitHub
gortiz commented on code in PR #12571: URL: https://github.com/apache/pinot/pull/12571#discussion_r1514255045 ## pinot-plugins/pinot-input-format/pinot-orc/pom.xml: ## @@ -70,5 +70,9 @@ xml-apis compile + + com.google.protobuf + protobuf-java R

Re: [PR] Fixing high severity CVEs in pinot-adls/pinot-orc/pinot-parquet [pinot]

2024-03-06 Thread via GitHub
xiangfu0 commented on code in PR #12571: URL: https://github.com/apache/pinot/pull/12571#discussion_r1514263355 ## pinot-plugins/pinot-input-format/pinot-orc/pom.xml: ## @@ -70,5 +70,9 @@ xml-apis compile + + com.google.protobuf + protobuf-java

Re: [PR] Fixing high severity CVEs in pinot-adls/pinot-orc/pinot-parquet [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12571: URL: https://github.com/apache/pinot/pull/12571#issuecomment-1980614230 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12571?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] Fixing high severity CVEs in pinot-adls/pinot-orc/pinot-parquet [pinot]

2024-03-06 Thread via GitHub
gortiz commented on code in PR #12571: URL: https://github.com/apache/pinot/pull/12571#discussion_r1514272971 ## pinot-plugins/pinot-input-format/pinot-orc/pom.xml: ## @@ -70,5 +70,9 @@ xml-apis compile + + com.google.protobuf + protobuf-java R

Re: [PR] Fixing high severity CVEs in pinot-adls/pinot-orc/pinot-parquet [pinot]

2024-03-06 Thread via GitHub
xiangfu0 merged PR #12571: URL: https://github.com/apache/pinot/pull/12571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch master updated: fixing pinot-adls high severity CVEs (#12571)

2024-03-06 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new edebbab10c fixing pinot-adls high severity CVEs

[PR] Bump antlr.version from 4.6 to 4.13.1 [pinot]

2024-03-06 Thread via GitHub
dependabot[bot] opened a new pull request, #12572: URL: https://github.com/apache/pinot/pull/12572 Bumps `antlr.version` from 4.6 to 4.13.1. Updates `org.antlr:antlr4-runtime` from 4.6 to 4.13.1 Release notes Sourced from https://github.com/antlr/antlr4/releases";>org.antlr:antlr

(pinot) branch dependabot/maven/antlr.version-4.13.1 created (now ef74c4a1e6)

2024-03-06 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/antlr.version-4.13.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at ef74c4a1e6 Bump antlr.version from 4.6 to 4.13.1 No new revisions were added by thi

Re: [PR] Enhance json index to support regexp and range predicate evaluation [pinot]

2024-03-06 Thread via GitHub
saurabhd336 commented on PR #12568: URL: https://github.com/apache/pinot/pull/12568#issuecomment-1980689303 cc: @itschrispeck and @chenboat for reviewing changes related to mutable json index moving to TreeMap since it changes the implementation of json_extract_index functions. IMO, iterat

Re: [I] Minion task for hybrid table erroring about a retry attempt exhaustion [pinot]

2024-03-06 Thread via GitHub
estebanz01 commented on issue #12547: URL: https://github.com/apache/pinot/issues/12547#issuecomment-1980859938 Sure thing. All warn information goes to the same output, right ? or it's there another specific location I can look into. -- This is an automated message from the Apache Git Se

Re: [PR] Allow passing database context through `database` http header [pinot]

2024-03-06 Thread via GitHub
shounakmk219 commented on code in PR #12417: URL: https://github.com/apache/pinot/pull/12417#discussion_r1514487635 ## pinot-common/src/main/java/org/apache/pinot/common/utils/DatabaseUtils.java: ## @@ -0,0 +1,91 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Enter segment preloading at partition level [pinot]

2024-03-06 Thread via GitHub
gortiz commented on code in PR #12451: URL: https://github.com/apache/pinot/pull/12451#discussion_r1514496150 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BaseTableUpsertMetadataManager.java: ## @@ -55,20 +39,11 @@ public abstract class BaseTableUps

Re: [I] Minion task for hybrid table erroring about a retry attempt exhaustion [pinot]

2024-03-06 Thread via GitHub
estebanz01 commented on issue #12547: URL: https://github.com/apache/pinot/issues/12547#issuecomment-1980904683 here's the full log of a fresh minion pod: minion pod log ```java SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/opt

Re: [PR] validate DropwizardMetricName equals [pinot]

2024-03-06 Thread via GitHub
sullis commented on PR #12559: URL: https://github.com/apache/pinot/pull/12559#issuecomment-1981267982 > Are the changes in `DropwizardMetricName` required to pass the `EqualsVerifier`? The changes seems unnecessary since we should never get a metric with `null` name The changes in `

[PR] add AwsSdkUtil to pinot-kinesis [pinot]

2024-03-06 Thread via GitHub
sullis opened a new pull request, #12573: URL: https://github.com/apache/pinot/pull/12573 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[PR] verify PrimaryKey equals [pinot]

2024-03-06 Thread via GitHub
sullis opened a new pull request, #12574: URL: https://github.com/apache/pinot/pull/12574 use equalsverifier library to verify 'equals' method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] validate DropwizardMetricName equals [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang merged PR #12559: URL: https://github.com/apache/pinot/pull/12559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: validate DropwizardMetricName equals (#12559)

2024-03-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 3c2b100742 validate DropwizardMetricName equals (

[PR] verify Plugin equals method [pinot]

2024-03-06 Thread via GitHub
sullis opened a new pull request, #12575: URL: https://github.com/apache/pinot/pull/12575 use the equalsverifier library to validate our 'equals' method https://jqno.nl/equalsverifier/ -- This is an automated message from the Apache Git Service. To respond to the message, pl

svn commit: r67759 - /dev/pinot/apache-pinot-1.1.0-rc0/

2024-03-06 Thread vvivekiyer
Author: vvivekiyer Date: Wed Mar 6 17:36:13 2024 New Revision: 67759 Log: Delete release-1.1.0-rc0 Removed: dev/pinot/apache-pinot-1.1.0-rc0/ - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional co

Re: [PR] Bump org.codehaus.jettison:jettison from 1.4.0 to 1.5.4 [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang closed pull request #12569: Bump org.codehaus.jettison:jettison from 1.4.0 to 1.5.4 URL: https://github.com/apache/pinot/pull/12569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Bump org.codehaus.jettison:jettison from 1.4.0 to 1.5.4 [pinot]

2024-03-06 Thread via GitHub
dependabot[bot] commented on PR #12569: URL: https://github.com/apache/pinot/pull/12569#issuecomment-1981442518 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

(pinot) branch dependabot/maven/org.codehaus.jettison-jettison-1.5.4 deleted (was 00447b8c89)

2024-03-06 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.codehaus.jettison-jettison-1.5.4 in repository https://gitbox.apache.org/repos/asf/pinot.git was 00447b8c89 Bump org.codehaus.jettison:jettison from 1.4.0 to 1.5.4

[PR] Update hadoop transitive dependencies and remove redundant exclusions [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang opened a new pull request, #12576: URL: https://github.com/apache/pinot/pull/12576 - `jline`: `3.22.0` -> `3.25.1` - `wildfly-common`: `1.5.4.Final` -> `1.7.0.Final` - `jettison`: `1.4.0` -> `1.5.4` -- This is an automated message from the Apache Git Service. To respond

Re: [PR] verify Plugin equals method [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang merged PR #12575: URL: https://github.com/apache/pinot/pull/12575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: verify Plugin equals method (#12575)

2024-03-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 038ef06e5f verify Plugin equals method (#12575) 0

(pinot) annotated tag release-1.1.0-rc0 deleted (was 5c1f08d2cc)

2024-03-06 Thread vvivekiyer
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a change to annotated tag release-1.1.0-rc0 in repository https://gitbox.apache.org/repos/asf/pinot.git *** WARNING: tag release-1.1.0-rc0 was deleted! *** tag was 5c1f08d2cc The revisions that were on th

Re: [PR] Bump antlr.version from 4.6 to 4.13.1 [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang merged PR #12572: URL: https://github.com/apache/pinot/pull/12572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/antlr.version-4.13.1 deleted (was ef74c4a1e6)

2024-03-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/antlr.version-4.13.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was ef74c4a1e6 Bump antlr.version from 4.6 to 4.13.1 The revisions that were on this branch

(pinot) branch master updated: Bump antlr.version from 4.6 to 4.13.1 (#12572)

2024-03-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 797e39cae1 Bump antlr.version from 4.6 to 4.13.1

(pinot) 01/01: exclude .mvn directory from source assembly (#12558)

2024-03-06 Thread vvivekiyer
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a commit to branch release-1.1.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git commit f2a59866bb67b2049df2d13606482717f632e8dc Author: Xiang Fu AuthorDate: Tue Mar 5 10:56:57 2024 -0800 ex

(pinot) branch release-1.1.0-rc updated (d3d3089e37 -> f2a59866bb)

2024-03-06 Thread vvivekiyer
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a change to branch release-1.1.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git discard d3d3089e37 [maven-release-plugin] prepare for next development iteration discard b10b4dd249 [maven-rele

Re: [I] Seems text_match() function doesn't support search with '#' character [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang commented on issue #12262: URL: https://github.com/apache/pinot/issues/12262#issuecomment-1981467319 I find something [here](https://solr-user.lucene.apache.narkive.com/X6ReA2cA/search-for-the-single-hash-character-never-returns-results) that might help: `text_match(tags, '[# T

Re: [PR] verify PrimaryKey equals method [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12574: URL: https://github.com/apache/pinot/pull/12574#issuecomment-1981480303 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12574?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] Enter segment preloading at partition level [pinot]

2024-03-06 Thread via GitHub
klsince commented on code in PR #12451: URL: https://github.com/apache/pinot/pull/12451#discussion_r1514938270 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BaseTableUpsertMetadataManager.java: ## @@ -55,20 +39,11 @@ public abstract class BaseTableUp

Re: [PR] add AwsSdkUtil to pinot-kinesis [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12573: URL: https://github.com/apache/pinot/pull/12573#issuecomment-1981504060 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12573?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

(pinot) annotated tag release-1.1.0-rc1 updated (c2606742bb -> 0c323caa05)

2024-03-06 Thread vvivekiyer
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a change to annotated tag release-1.1.0-rc1 in repository https://gitbox.apache.org/repos/asf/pinot.git *** WARNING: tag release-1.1.0-rc1 was modified! *** from c2606742bb (commit) to 0c323caa05 (ta

(pinot) branch release-1.1.0-rc updated: [maven-release-plugin] prepare release release-1.1.0-rc1

2024-03-06 Thread vvivekiyer
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a commit to branch release-1.1.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/release-1.1.0-rc by this push: new c2606742bb [maven-release

(pinot) branch release-1.1.0-rc updated: [maven-release-plugin] prepare for next development iteration

2024-03-06 Thread vvivekiyer
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a commit to branch release-1.1.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/release-1.1.0-rc by this push: new f95c4aaaf9 [maven-release

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-03-06 Thread via GitHub
deemoliu commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1514972783 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, String

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-03-06 Thread via GitHub
deemoliu commented on PR #12437: URL: https://github.com/apache/pinot/pull/12437#issuecomment-1981544903 > Are there equivalent/similar functions in other commonly used DBs (e.g. PostgreSQL)? We should try to match the behavior Hi @Jackie-Jiang thanks for looking into it. the followin

Re: [PR] Add Prefix, Suffix and Ngram UDFs [pinot]

2024-03-06 Thread via GitHub
deemoliu commented on PR #12392: URL: https://github.com/apache/pinot/pull/12392#issuecomment-1981564946 > Are there equivalent/similar functions in other commonly used DBs (e.g. PostgreSQL)? We should try to match the behavior i think postgresql provide a 3-gram module called `pg_trg

[PR] enable Netty native transports by default [pinot]

2024-03-06 Thread via GitHub
sullis opened a new pull request, #12577: URL: https://github.com/apache/pinot/pull/12577 enable native transports (epoll, kqueue) by default -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] enable Netty native transports in ClusterTest [pinot]

2024-03-06 Thread via GitHub
sullis commented on PR #12527: URL: https://github.com/apache/pinot/pull/12527#issuecomment-1981613259 for discussion: enable native transports by default in NettyConfig.java https://github.com/apache/pinot/pull/12577 -- This is an automated message from the Apache Git Serv

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1515059370 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, St

[PR] Upgrade hadoop-common dependency from hadoop-shaded-protobuf_3_7 to hadoop-shaded-protobuf_3_21 [pinot]

2024-03-06 Thread via GitHub
xiangfu0 opened a new pull request, #12578: URL: https://github.com/apache/pinot/pull/12578 Upgrade hadoop-common dependency from hadoop-shaded-protobuf_3_7 to hadoop-shaded-protobuf_3_21 for CVE fixing. -- This is an automated message from the Apache Git Service. To respond to the messag

[PR] reduce Java enum .values() usage in TimerContext [pinot]

2024-03-06 Thread via GitHub
sullis opened a new pull request, #12579: URL: https://github.com/apache/pinot/pull/12579 Motivation: reduce enum array allocation in TimerContext Modifications: cache ServerQueryPhase.values().length in a static variable Result: Java enum .values() method i

Re: [PR] enable Netty native transports by default [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12577: URL: https://github.com/apache/pinot/pull/12577#issuecomment-1981697202 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12577?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] Update hadoop transitive dependencies and remove redundant exclusions [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12576: URL: https://github.com/apache/pinot/pull/12576#issuecomment-1981706555 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12576?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

svn commit: r67761 - /dev/pinot/apache-pinot-1.1.0-rc1/

2024-03-06 Thread vvivekiyer
Author: vvivekiyer Date: Wed Mar 6 20:51:31 2024 New Revision: 67761 Log: Update apache-pinot-1.1.0-rc1 Added: dev/pinot/apache-pinot-1.1.0-rc1/ dev/pinot/apache-pinot-1.1.0-rc1/apache-pinot-1.1.0-bin.tar.gz (with props) dev/pinot/apache-pinot-1.1.0-rc1/apache-pinot-1.1.0-bin.tar.

[PR] Upgrade com.microsoft.azure:msal4j from 1.3.5 to 1.3.10 for CVE fixing [pinot]

2024-03-06 Thread via GitHub
xiangfu0 opened a new pull request, #12580: URL: https://github.com/apache/pinot/pull/12580 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

(pinot) 01/01: Leverage ONLINE-OFFLINE state model for realtime tables

2024-03-06 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch full-auto-same-state-model in repository https://gitbox.apache.org/repos/asf/pinot.git commit 7408de4fd0069bf5caea938b4936d9f3a1f6a556 Author: jlli_LinkedIn AuthorDate: Wed Mar 6 12:57:45 2024 -080

(pinot) branch full-auto-same-state-model created (now 7408de4fd0)

2024-03-06 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch full-auto-same-state-model in repository https://gitbox.apache.org/repos/asf/pinot.git at 7408de4fd0 Leverage ONLINE-OFFLINE state model for realtime tables This branch includes the followin

Re: [PR] reduce enum array allocation in TimerContext [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12579: URL: https://github.com/apache/pinot/pull/12579#issuecomment-1981777616 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12579?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] Upgrade hadoop-common dependency from hadoop-shaded-protobuf_3_7 to hadoop-shaded-protobuf_3_21 [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12578: URL: https://github.com/apache/pinot/pull/12578#issuecomment-1981784665 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12578?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] enable Netty native transports by default [pinot]

2024-03-06 Thread via GitHub
siddharthteotia commented on PR #12577: URL: https://github.com/apache/pinot/pull/12577#issuecomment-1981788213 Correct me if I am wrong. There is unlikely to be any negative impact for this. In fact this will only lead to may be P99 improvements at high throughput ? cc @jasperjiaguo

Re: [PR] Detect expired messages in Kafka. Log and set a guage. [pinot]

2024-03-06 Thread via GitHub
vrajat commented on PR #12157: URL: https://github.com/apache/pinot/pull/12157#issuecomment-1981792537 Debug APIs and tests are there to test that the data loss is detected. Is it OK if one of the PRs has no test to check the changes? -- This is an automated message from the Apache Git S

Re: [PR] Update hadoop transitive dependencies and remove redundant exclusions [pinot]

2024-03-06 Thread via GitHub
xiangfu0 merged PR #12576: URL: https://github.com/apache/pinot/pull/12576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch master updated (797e39cae1 -> c6cfc602b0)

2024-03-06 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 797e39cae1 Bump antlr.version from 4.6 to 4.13.1 (#12572) add c6cfc602b0 Update hadoop transitive dependencies an

Re: [PR] enable Netty native transports by default [pinot]

2024-03-06 Thread via GitHub
jasperjiaguo commented on PR #12577: URL: https://github.com/apache/pinot/pull/12577#issuecomment-1981822434 >Correct me if I am wrong. There is unlikely to be any negative impact for this. In fact this will only lead to may be P99 improvements at high throughput ? Yes we've only see

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-03-06 Thread via GitHub
deemoliu commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1515186487 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, String

Re: [PR] Add splitPartWithLimit and splitPartFromEnd UDFs [pinot]

2024-03-06 Thread via GitHub
deemoliu commented on code in PR #12437: URL: https://github.com/apache/pinot/pull/12437#discussion_r1515187581 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -597,6 +596,39 @@ public static String splitPart(String input, String

[PR] Add metric to track number of segments missed in upsert-snapshot [pinot]

2024-03-06 Thread via GitHub
tibrewalpratik17 opened a new pull request, #12581: URL: https://github.com/apache/pinot/pull/12581 label: - `observability` Adding a metric to track number of segments missed in upsert-snapshot. cc @ankitsultana -- This is an automated message from the Apache Git Service

Re: [PR] reduce enum array allocation in TimerContext [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang merged PR #12579: URL: https://github.com/apache/pinot/pull/12579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: reduce Java enum .values() usage in TimerContext (#12579)

2024-03-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new acbbd01317 reduce Java enum .values() usage in Ti

Re: [PR] Upgrade com.microsoft.azure:msal4j from 1.3.5 to 1.3.10 for CVE fixing [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12580: URL: https://github.com/apache/pinot/pull/12580#issuecomment-1981896059 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12580?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] Add metric to track number of segments missed in upsert-snapshot [pinot]

2024-03-06 Thread via GitHub
codecov-commenter commented on PR #12581: URL: https://github.com/apache/pinot/pull/12581#issuecomment-1981958898 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12581?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] Add Prefix, Suffix and Ngram UDFs [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang commented on code in PR #12392: URL: https://github.com/apache/pinot/pull/12392#discussion_r1515232533 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java: ## @@ -570,6 +572,107 @@ public static String[] split(String input, Str

Re: [PR] Upgrade hadoop-common dependency from hadoop-shaded-protobuf_3_7 to hadoop-shaded-protobuf_3_21 [pinot]

2024-03-06 Thread via GitHub
xiangfu0 merged PR #12578: URL: https://github.com/apache/pinot/pull/12578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch master updated (acbbd01317 -> a36b564391)

2024-03-06 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from acbbd01317 reduce Java enum .values() usage in TimerContext (#12579) add a36b564391 Upgrade hadoop-common depende

Re: [PR] Upgrade com.microsoft.azure:msal4j from 1.3.5 to 1.3.10 for CVE fixing [pinot]

2024-03-06 Thread via GitHub
xiangfu0 merged PR #12580: URL: https://github.com/apache/pinot/pull/12580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch master updated (a36b564391 -> af43f591b7)

2024-03-06 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from a36b564391 Upgrade hadoop-common dependency from hadoop-shaded-protobuf_3_7 to hadoop-shaded-protobuf_3_21 (#12578)

Re: [PR] Detect expired messages in Kafka. Log and set a guage. [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang commented on PR #12157: URL: https://github.com/apache/pinot/pull/12157#issuecomment-1981974328 Ideally we want a unit test to directly read the value from the gauge, instead of relying on a rest API which is kind of an integration test. Currently I saw CI test failures, but no

Re: [PR] bugfix: do not move src ByteBuffer position for LZ4 length prefixed decompress [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang commented on PR #12539: URL: https://github.com/apache/pinot/pull/12539#issuecomment-1981983862 @itschrispeck Thanks for digging into it! I feel using safe decompressor is the safe go here, and we can get consistent behavior for v2 and v4. -- This is an automated message from

Re: [PR] bugfix: do not move src ByteBuffer position for LZ4 length prefixed decompress [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang commented on PR #12539: URL: https://github.com/apache/pinot/pull/12539#issuecomment-1981984404 +1 on adding a unit test to prevent future regression -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] Revert "Bump org.apache.maven.scm:maven-scm-provider-gitexe from 1.94 to 2.0.1 (#12472)" [pinot]

2024-03-06 Thread via GitHub
xiangfu0 opened a new pull request, #12582: URL: https://github.com/apache/pinot/pull/12582 Revert "Bump org.apache.maven.scm:maven-scm-provider-gitexe from 1.94 to 2.0.1 (#12472)" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Revert "Bump org.apache.maven.scm:maven-scm-provider-gitexe from 1.94 to 2.0.1 (#12472)" [pinot]

2024-03-06 Thread via GitHub
xiangfu0 merged PR #12582: URL: https://github.com/apache/pinot/pull/12582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch master updated: Revert "Bump org.apache.maven.scm:maven-scm-provider-gitexe from 1.9.4 to 2.0.1 (#12472)" (#12582)

2024-03-06 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 0153e9ee73 Revert "Bump org.apache.maven.scm:mav

(pinot) branch full-auto-same-state-model updated (7408de4fd0 -> 6c7302caf9)

2024-03-06 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch full-auto-same-state-model in repository https://gitbox.apache.org/repos/asf/pinot.git discard 7408de4fd0 Leverage ONLINE-OFFLINE state model for realtime tables new 6c7302caf9 Leverage ONLIN

(pinot) 01/01: Leverage ONLINE-OFFLINE state model for realtime tables

2024-03-06 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch full-auto-same-state-model in repository https://gitbox.apache.org/repos/asf/pinot.git commit 6c7302caf904837f414e76f4ad77a78fdbd3e71c Author: jlli_LinkedIn AuthorDate: Wed Mar 6 12:57:45 2024 -080

Re: [PR] Supporting human-readable format when configuring broker response size [pinot]

2024-03-06 Thread via GitHub
Jackie-Jiang merged PR #12510: URL: https://github.com/apache/pinot/pull/12510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Supporting human-readable format when configuring broker response size (#12510)

2024-03-06 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 227281aa1d Supporting human-readable format when

Re: [PR] verify PrimaryKey equals method [pinot]

2024-03-06 Thread via GitHub
sullis commented on PR #12574: URL: https://github.com/apache/pinot/pull/12574#issuecomment-1982020381 ready to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [I] Rebalancing table with no segments and "reassign instances" returns IN_PROGRESS but doesn't track the job_id or NullPointerException [pinot]

2024-03-06 Thread via GitHub
jadami10 commented on issue #12316: URL: https://github.com/apache/pinot/issues/12316#issuecomment-1982035460 ya, i know you had some fixes here recently. I will let you know once we pick up 1.1 -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] Remove hadoop-mapreduce-client-core dependency from pinot-parquet [pinot]

2024-03-06 Thread via GitHub
xiangfu0 opened a new pull request, #12583: URL: https://github.com/apache/pinot/pull/12583 Remove hadoop-mapreduce-client-core dependency from pinot-parquet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

  1   2   >