sullis commented on PR #12559: URL: https://github.com/apache/pinot/pull/12559#issuecomment-1981267982
> Are the changes in `DropwizardMetricName` required to pass the `EqualsVerifier`? The changes seems unnecessary since we should never get a metric with `null` name The changes in `DropwizardMetricName` were made to pass EqualsVerifier's default verification behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
