klsince commented on code in PR #12451: URL: https://github.com/apache/pinot/pull/12451#discussion_r1514938270
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BaseTableUpsertMetadataManager.java: ########## @@ -55,20 +39,11 @@ public abstract class BaseTableUpsertMetadataManager implements TableUpsertMetad private static final Logger LOGGER = LoggerFactory.getLogger(BaseTableUpsertMetadataManager.class); protected String _tableNameWithType; - protected TableDataManager _tableDataManager; - protected HelixManager _helixManager; - protected ExecutorService _segmentPreloadExecutor; Review Comment: those were added when adding the preloading logic but was made at table level. Those got reverted in this PR to move the preloading logic to table partition level for more flexibility and more explicit/clear locking logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
