Re: [PR] msqe-case-insensitive-enabled [pinot]

2025-04-08 Thread via GitHub
ankitsultana commented on PR #14830: URL: https://github.com/apache/pinot/pull/14830#issuecomment-2788228861 @Jackie-Jiang : this change is b/w incompatible for the SPI member `TableNameBuilder` (specifically, `getTableTypeFromTableName` and a bunch of other methods). Can we please revert t

Re: [PR] msqe-case-insensitive-enabled [pinot]

2025-01-23 Thread via GitHub
yashmayya merged PR #14830: URL: https://github.com/apache/pinot/pull/14830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [PR] msqe-case-insensitive-enabled [pinot]

2025-01-22 Thread via GitHub
albertobastos commented on code in PR #14830: URL: https://github.com/apache/pinot/pull/14830#discussion_r1926469613 ## pinot-query-planner/src/main/java/org/apache/pinot/query/catalog/PinotCatalog.java: ## @@ -80,8 +82,20 @@ public Table getTable(String name) { */ @Overr

Re: [PR] msqe-case-insensitive-enabled [pinot]

2025-01-22 Thread via GitHub
yashmayya commented on code in PR #14830: URL: https://github.com/apache/pinot/pull/14830#discussion_r1926386163 ## pinot-query-planner/src/main/java/org/apache/pinot/query/catalog/PinotCatalog.java: ## @@ -80,8 +82,20 @@ public Table getTable(String name) { */ @Override

Re: [PR] msqe-case-insensitive-enabled [pinot]

2025-01-22 Thread via GitHub
albertobastos commented on code in PR #14830: URL: https://github.com/apache/pinot/pull/14830#discussion_r1925359264 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java: ## @@ -2994,25 +2994,29 @@ public void testCaseSen

Re: [PR] msqe-case-insensitive-enabled [pinot]

2025-01-22 Thread via GitHub
albertobastos commented on code in PR #14830: URL: https://github.com/apache/pinot/pull/14830#discussion_r1925355692 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java: ## @@ -2994,25 +2994,29 @@ public void testCaseSen

Re: [PR] msqe-case-insensitive-enabled [pinot]

2025-01-22 Thread via GitHub
albertobastos commented on code in PR #14830: URL: https://github.com/apache/pinot/pull/14830#discussion_r1925353431 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java: ## @@ -2994,25 +2994,29 @@ public void testCaseSen

Re: [PR] msqe-case-insensitive-enabled [pinot]

2025-01-22 Thread via GitHub
albertobastos commented on code in PR #14830: URL: https://github.com/apache/pinot/pull/14830#discussion_r1925349955 ## pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java: ## @@ -118,9 +111,15 @@ public QueryEnvironment(Config config) { String da

Re: [PR] msqe-case-insensitive-enabled [pinot]

2025-01-22 Thread via GitHub
albertobastos commented on code in PR #14830: URL: https://github.com/apache/pinot/pull/14830#discussion_r1925347842 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java: ## @@ -1347,6 +1347,15 @@ public void testConcur

Re: [PR] msqe-case-insensitive-enabled [pinot]

2025-01-22 Thread via GitHub
albertobastos commented on code in PR #14830: URL: https://github.com/apache/pinot/pull/14830#discussion_r1925336193 ## pinot-query-planner/src/main/java/org/apache/pinot/query/catalog/PinotCatalog.java: ## @@ -80,8 +80,9 @@ public Table getTable(String name) { */ @Overri

Re: [PR] msqe-case-insensitive-enabled [pinot]

2025-01-22 Thread via GitHub
yashmayya commented on code in PR #14830: URL: https://github.com/apache/pinot/pull/14830#discussion_r1925144245 ## pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java: ## @@ -118,9 +111,15 @@ public QueryEnvironment(Config config) { String databa

Re: [PR] msqe-case-insensitive-enabled [pinot]

2025-01-21 Thread via GitHub
albertobastos commented on code in PR #14830: URL: https://github.com/apache/pinot/pull/14830#discussion_r1923551806 ## pinot-query-planner/src/main/java/org/apache/pinot/query/catalog/PinotCatalog.java: ## @@ -80,8 +80,9 @@ public Table getTable(String name) { */ @Overri

Re: [PR] msqe-case-insensitive-enabled [pinot]

2025-01-21 Thread via GitHub
albertobastos commented on code in PR #14830: URL: https://github.com/apache/pinot/pull/14830#discussion_r1923551806 ## pinot-query-planner/src/main/java/org/apache/pinot/query/catalog/PinotCatalog.java: ## @@ -80,8 +80,9 @@ public Table getTable(String name) { */ @Overri

Re: [PR] msqe-case-insensitive-enabled [pinot]

2025-01-16 Thread via GitHub
codecov-commenter commented on PR #14830: URL: https://github.com/apache/pinot/pull/14830#issuecomment-2597145816 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14830?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] msqe-case-insensitive-enabled [pinot]

2025-01-16 Thread via GitHub
albertobastos opened a new pull request, #14830: URL: https://github.com/apache/pinot/pull/14830 closes https://github.com/apache/pinot/issues/14675 Backwards compatibility: When `enable.case.insensitive=true` (the default value) responses using MSQE will return the contents of