albertobastos commented on code in PR #14830:
URL: https://github.com/apache/pinot/pull/14830#discussion_r1925336193
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/catalog/PinotCatalog.java:
##########
@@ -80,8 +80,9 @@ public Table getTable(String name) {
*/
@Override
public Set<String> getTableNames() {
- return _tableCache.getTableNameMap().keySet().stream().filter(n ->
DatabaseUtils.isPartOfDatabase(n, _databaseName))
- .collect(Collectors.toSet());
+ //return _tableCache.getTableNameMap().keySet().stream().filter(n ->
DatabaseUtils.isPartOfDatabase(n, _databaseName))
+ // .collect(Collectors.toSet());
+ return _tableCache.getTableNameMap().keySet();
Review Comment:
That's an interesting thought.
I guess the proper response is to return only tables that belong to the
implicit database, but strip them from the database prefix (or, at least,
return them both in prefixed and non-prefixed form). For instance
`SimpleCalciteSchema` will lookup for the table name without its prefix, so we
cannot expect only one of the two forms.
https://github.com/apache/pinot/pull/14830/commits/97870597421d0c1cbb50634d1913701375e163c3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
