albertobastos commented on code in PR #14830:
URL: https://github.com/apache/pinot/pull/14830#discussion_r1923551806
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/catalog/PinotCatalog.java:
##########
@@ -80,8 +80,9 @@ public Table getTable(String name) {
*/
@Override
public Set<String> getTableNames() {
- return _tableCache.getTableNameMap().keySet().stream().filter(n ->
DatabaseUtils.isPartOfDatabase(n, _databaseName))
- .collect(Collectors.toSet());
+ //return _tableCache.getTableNameMap().keySet().stream().filter(n ->
DatabaseUtils.isPartOfDatabase(n, _databaseName))
+ // .collect(Collectors.toSet());
+ return _tableCache.getTableNameMap().keySet();
Review Comment:
Enabling `calcite` case-insensitive configuration led to a lot of unexpected
consequences. One of them is that, during table name resolution and validation,
it now relies in `schema.getTableNames()` to find if a table exists:
https://github.com/apache/calcite/blob/f9cc84f35aeba0effd6654da8471d4bef9eaa925/core/src/main/java/org/apache/calcite/jdbc/SimpleCalciteSchema.java#L122
As it was implemented, this method got rid of all non-prefixed tableNames
when `_databaseName != null`, and probably that was not intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
