Jackie-Jiang commented on PR #14159:
URL: https://github.com/apache/pinot/pull/14159#issuecomment-2436283408
Thanks for the contribution! Please help update pinot doc about these new
configs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Jackie-Jiang merged PR #14159:
URL: https://github.com/apache/pinot/pull/14159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
tibrewalpratik17 commented on PR #14159:
URL: https://github.com/apache/pinot/pull/14159#issuecomment-2436249618
@Jackie-Jiang does this change address all your comments? Waiting for your
approval before merging this.
--
This is an automated message from the Apache Git Service.
To respond
Jackie-Jiang commented on code in PR #14159:
URL: https://github.com/apache/pinot/pull/14159#discussion_r1805536556
##
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##
@@ -69,6 +69,8 @@ public class ControllerConf extends PinotConfiguration {
Jackie-Jiang commented on code in PR #14159:
URL: https://github.com/apache/pinot/pull/14159#discussion_r1805542164
##
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##
@@ -321,6 +324,7 @@ private static long getRandomInitialDelayInSeconds() {
shounakmk219 commented on code in PR #14159:
URL: https://github.com/apache/pinot/pull/14159#discussion_r1795034033
##
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java:
##
@@ -252,10 +253,13 @@ public void init(PinotConfiguration pinotConfigu
Jackie-Jiang commented on code in PR #14159:
URL: https://github.com/apache/pinot/pull/14159#discussion_r1792597704
##
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java:
##
@@ -252,10 +253,13 @@ public void init(PinotConfiguration pinotConfigu
