Jackie-Jiang commented on code in PR #14159: URL: https://github.com/apache/pinot/pull/14159#discussion_r1805542164
########## pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java: ########## @@ -321,6 +324,7 @@ private static long getRandomInitialDelayInSeconds() { AutoRebalanceStrategy.class.getName(); private static final int DEFAULT_LEAD_CONTROLLER_RESOURCE_REBALANCE_DELAY_MS = 300_000; // 5 minutes private static final String DEFAULT_DIM_TABLE_MAX_SIZE = "200M"; + private static final int EMPTY_THREAD_POOL = 0; Review Comment: Suggest using `-1` to represent unspecified. Default to empty thread pool can be a little bit confusing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org