Jackie-Jiang commented on code in PR #14159:
URL: https://github.com/apache/pinot/pull/14159#discussion_r1792597704
##########
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java:
##########
@@ -252,10 +253,13 @@ public void init(PinotConfiguration pinotConfiguration)
// ControllerStarter::start()}
_helixResourceManager = createHelixResourceManager();
// This executor service is used to do async tasks from multiget util or
table rebalancing.
+ _numThreadPool = _config.getControllerNumThreadPool();
_executorService =
- Executors.newCachedThreadPool(new
ThreadFactoryBuilder().setNameFormat("async-task-thread-%d").build());
+ Executors.newFixedThreadPool(_numThreadPool, new
ThreadFactoryBuilder()
+ .setNameFormat("async-task-thread-%d").build());
_tenantRebalanceExecutorService =
Review Comment:
Good point! Should we make it a different configurable then? Basically
keeping 2 thread pools, but allow them to be configured separately?
To a second thought, should be consider moving all rebalance tasks to a
different thread pool? Rebalance is in general long running tasks which doesn't
require much CPU
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
