Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2087036696 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,276 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2086941117 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,276 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2087034298 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,280 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2087037492 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,276 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

yashmayya commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2086296902 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,280 @@ private static void handleErrorIn

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

yashmayya commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2085993960 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,276 @@ private static void handleErrorIn

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2085595949 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,276 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2085026933 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancerTest.java: ## @@ -1438,4 +1464,1011 @@ public void testIsExternalView

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2084759396 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,276 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2085025521 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancerTest.java: ## @@ -1438,4 +1464,1011 @@ public void testIsExternalView

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2085024994 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancerTest.java: ## @@ -1438,4 +1464,1011 @@ public void testIsExternalView

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2085024597 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancerTest.java: ## @@ -1438,4 +1464,1011 @@ public void testIsExternalView

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2085023573 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancerClusterStatelessTest.java: ## @@ -105,568 +105,672 @@ public void set

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2085024296 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/PartialUpsertTableRebalanceIntegrationTest.java: ## @@ -163,6 +163,74 @@ public void testRe

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2084769589 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,276 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2084759396 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,276 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2084759396 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,276 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2083767580 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,276 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2083767580 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,276 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2083768379 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,276 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2083768586 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,276 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2083767580 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,276 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

yashmayya commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2083511042 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,276 @@ private static void handleErrorIn

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2080683879 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,336 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2080686074 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,336 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2080689742 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,336 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2080689596 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -625,6 +625,13 @@ public RebalanceResult rebalance(

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2080686074 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,336 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2080680182 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,336 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2080212649 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1595,13 +1875,41 @@ private static Map> getNextNonStri

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2079974548 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,336 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2079974548 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,336 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2079976643 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,336 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

yashmayya commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2079510950 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -625,6 +625,13 @@ public RebalanceResult rebalance(

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2078549279 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,336 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2078549279 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,336 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

J-HowHuang commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2078533623 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,336 @@ private static void handleErrorI

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2078477653 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -224,6 +225,9 @@ private RebalanceResult doRebalance(Tab

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

J-HowHuang commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2078488673 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -224,6 +225,9 @@ private RebalanceResult doRebalance(T

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

J-HowHuang commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2078295696 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1434,67 +1445,336 @@ private static void handleErrorI

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2078485359 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1434,67 +1445,336 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2078480229 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1524,67 +1535,336 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2078477653 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -224,6 +225,9 @@ private RebalanceResult doRebalance(Tab

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2063997789 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1434,67 +1445,336 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2063997789 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1434,67 +1445,336 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2063997789 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1434,67 +1445,336 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2063997789 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1434,67 +1445,336 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2059622741 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1434,67 +1444,209 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2059622741 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1434,67 +1444,209 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2059084112 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1434,67 +1444,209 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2059154741 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1434,67 +1444,209 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2059154741 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1434,67 +1444,209 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2059114227 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1434,67 +1444,209 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2059113164 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1434,67 +1444,209 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

J-HowHuang commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2059110355 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1434,67 +1444,209 @@ private static void handleErrorI

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2059103904 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1434,67 +1444,209 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2059094890 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1434,67 +1444,209 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2059080890 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -479,6 +482,16 @@ private RebalanceResult doRebalance(Ta

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2059084112 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1434,67 +1444,209 @@ private static void handleErrorIns

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2059080890 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -479,6 +482,16 @@ private RebalanceResult doRebalance(Ta

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

J-HowHuang commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2058977515 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -479,6 +482,16 @@ private RebalanceResult doRebalance(

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2055214455 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -598,9 +611,12 @@ private RebalanceResult doRebalance(Ta

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2055075416 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -479,6 +482,16 @@ private RebalanceResult doRebalance(Ta

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

Jackie-Jiang commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2054996050 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -479,6 +482,16 @@ private RebalanceResult doRebalanc

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

codecov-commenter commented on PR #15617: URL: https://github.com/apache/pinot/pull/15617#issuecomment-2822368891 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15617?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u