gortiz commented on PR #15737:
URL: https://github.com/apache/pinot/pull/15737#issuecomment-2903936035
I've been fooled by the name of the folder being used. We are not storing
the old jar in `src/resources/` but just `resources`, so the old jar shouldn't
be added to the classpath.
T
gortiz commented on PR #15737:
URL: https://github.com/apache/pinot/pull/15737#issuecomment-2903518096
I wasn't aware of this change. I think it is pretty cool, but I'm not sure
about the actual execution.
The file pinot-segment-spi-japicmp-baseline.jar *should not* be stored in
reso
siddharthteotia merged PR #15737:
URL: https://github.com/apache/pinot/pull/15737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pi
codecov-commenter commented on PR #15737:
URL: https://github.com/apache/pinot/pull/15737#issuecomment-2860397675
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15737?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
matvj250 commented on code in PR #15737:
URL: https://github.com/apache/pinot/pull/15737#discussion_r2078396849
##
pinot-segment-spi/pom.xml:
##
@@ -34,6 +34,69 @@
${basedir}/..
+
+
+
+com.github.siom79.japicmp
+japicmp-maven-plugin
+
UOETianleZhang commented on code in PR #15737:
URL: https://github.com/apache/pinot/pull/15737#discussion_r2078388061
##
pinot-segment-spi/pom.xml:
##
@@ -34,6 +34,69 @@
${basedir}/..
+
+
+
+com.github.siom79.japicmp
+japicmp-maven-plugin
+
matvj250 opened a new pull request, #15737:
URL: https://github.com/apache/pinot/pull/15737
Very similar to this PR: https://github.com/apache/pinot/pull/15684
Implementing japicmp in the pinot-segment-spi module to fail builds (i.e.
running mvn clean) when incompatible SPI changes ar
