gortiz commented on PR #15737: URL: https://github.com/apache/pinot/pull/15737#issuecomment-2903518096
I wasn't aware of this change. I think it is pretty cool, but I'm not sure about the actual execution. The file pinot-segment-spi-japicmp-baseline.jar *should not* be stored in resources. By storing it there, the classes it includes are added to the classpath twice (one with the correct code, another with the old version). This can produce tons of errors that can be very difficult to detect. We could either not enable this feature until the next release, store the old jar in a folder not managed by Maven or create a new artifact for the old version, but the current solution is the most dangerous I can imagine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
