UOETianleZhang commented on code in PR #15737:
URL: https://github.com/apache/pinot/pull/15737#discussion_r2078388061
##########
pinot-segment-spi/pom.xml:
##########
@@ -34,6 +34,69 @@
<pinot.root>${basedir}/..</pinot.root>
</properties>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.github.siom79.japicmp</groupId>
+ <artifactId>japicmp-maven-plugin</artifactId>
+ <version>0.23.1</version>
+ <configuration>
+ <oldVersion>
+ <file>
+
<path>${basedir}/resources/pinot-segment-spi-japicmp-baseline.jar</path>
+ </file>
+ </oldVersion>
+ <!-- If oldVersion were left blank, 1.3.0 would be the baseline
version for japicmp's comparing. However, we already
Review Comment:
Could you move the comment so that it is before `oldVersion`, and let the
intents aligned? Similar change can apply to pinot-spi module (sorry it might
be missed from pervious code review)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
