Re: [PR] Hash Function for UUID Primary Keys [pinot]

Jackie-Jiang merged PR #12538: URL: https://github.com/apache/pinot/pull/12538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Hash Function for UUID Primary Keys [pinot]

Jackie-Jiang commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1569332741 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -36,6 +40,31 @@ public static byte[] hashMD5(byte[] bytes) { r

Re: [PR] Hash Function for UUID Primary Keys [pinot]

Jackie-Jiang commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1569325802 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -44,8 +73,31 @@ public static Object hashPrimaryKey(PrimaryKey prim

Re: [PR] Hash Function for UUID Primary Keys [pinot]

ankitsultana commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1566736270 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -44,8 +73,31 @@ public static Object hashPrimaryKey(PrimaryKey prim

Re: [PR] Hash Function for UUID Primary Keys [pinot]

ankitsultana commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1552663602 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -36,6 +40,31 @@ public static byte[] hashMD5(byte[] bytes) { r

Re: [PR] Hash Function for UUID Primary Keys [pinot]

ankitsultana commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1552662396 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -44,8 +73,31 @@ public static Object hashPrimaryKey(PrimaryKey prim

Re: [PR] Hash Function for UUID Primary Keys [pinot]

Jackie-Jiang commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1552656087 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -36,6 +40,31 @@ public static byte[] hashMD5(byte[] bytes) { r

Re: [PR] Hash Function for UUID Primary Keys [pinot]

Jackie-Jiang commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1552655005 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -44,8 +73,31 @@ public static Object hashPrimaryKey(PrimaryKey prim

Re: [PR] Hash Function for UUID Primary Keys [pinot]

ankitsultana commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1552648810 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -36,6 +40,31 @@ public static byte[] hashMD5(byte[] bytes) { r

Re: [PR] Hash Function for UUID Primary Keys [pinot]

ankitsultana commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1552648018 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -36,6 +40,31 @@ public static byte[] hashMD5(byte[] bytes) { r

Re: [PR] Hash Function for UUID Primary Keys [pinot]

ankitsultana commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1552646696 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -44,8 +73,31 @@ public static Object hashPrimaryKey(PrimaryKey prim

Re: [PR] Hash Function for UUID Primary Keys [pinot]

ankitsultana closed pull request #12538: Hash Function for UUID Primary Keys URL: https://github.com/apache/pinot/pull/12538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Hash Function for UUID Primary Keys [pinot]

Jackie-Jiang commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1552634492 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -44,8 +73,31 @@ public static Object hashPrimaryKey(PrimaryKey prim

Re: [PR] Hash Function for UUID Primary Keys [pinot]

chenboat commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1552633674 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -36,6 +40,31 @@ public static byte[] hashMD5(byte[] bytes) { retur

Re: [PR] Hash Function for UUID Primary Keys [pinot]

chenboat commented on PR #12538: URL: https://github.com/apache/pinot/pull/12538#issuecomment-2038501668 Can you be more specific on the PR title and description section on what is the hash function used? It is not clear currently. -- This is an automated message from the Apache Git Servi

Re: [PR] Hash Function for UUID Primary Keys [pinot]

satishd commented on PR #12538: URL: https://github.com/apache/pinot/pull/12538#issuecomment-2032592795 >@satishd I guess you mean collision between two primary keys where one is UUID conformant and the other is not? Right. >Unless we prepend the length of the string in the UUI

Re: [PR] Hash Function for UUID Primary Keys [pinot]

satishd commented on code in PR #12538: URL: https://github.com/apache/pinot/pull/12538#discussion_r1547180230 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java: ## @@ -44,8 +73,31 @@ public static Object hashPrimaryKey(PrimaryKey primaryKe