Jackie-Jiang commented on code in PR #12538:
URL: https://github.com/apache/pinot/pull/12538#discussion_r1569332741
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java:
##########
@@ -36,6 +40,31 @@ public static byte[] hashMD5(byte[] bytes) {
return Hashing.md5().hashBytes(bytes).asBytes();
}
+ /**
+ * Returns a byte array that is a concatenation of the binary representation
of each of the passed UUID values. This
+ * is done by getting a String from each value by calling {@link
Object#toString()}, which is then used to create a
+ * {@link UUID} object. The 16 bytes of each UUID are appended to a buffer
which is then returned in the result.
+ * If any of the values is not a valid UUID, then we return the result of
{@link #concatenate}.
+ */
+ public static byte[] hashUUID(Object[] values) {
+ byte[] result = new byte[values.length * 16];
+ ByteBuffer byteBuffer =
ByteBuffer.wrap(result).order(ByteOrder.BIG_ENDIAN);
+ for (Object value : values) {
+ if (value == null) {
+ return concatenate(values);
Review Comment:
Just realized that we can directly use `PrimaryKey.asBytes()` which
compresses the data better
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java:
##########
@@ -36,6 +40,31 @@ public static byte[] hashMD5(byte[] bytes) {
return Hashing.md5().hashBytes(bytes).asBytes();
}
+ /**
+ * Returns a byte array that is a concatenation of the binary representation
of each of the passed UUID values. This
+ * is done by getting a String from each value by calling {@link
Object#toString()}, which is then used to create a
+ * {@link UUID} object. The 16 bytes of each UUID are appended to a buffer
which is then returned in the result.
+ * If any of the values is not a valid UUID, then we return the result of
{@link #concatenate}.
+ */
+ public static byte[] hashUUID(Object[] values) {
Review Comment:
For clarification, we are not really hashing the values, but compress it
instead right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
