Jackie-Jiang commented on code in PR #12538:
URL: https://github.com/apache/pinot/pull/12538#discussion_r1569325802
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/HashUtils.java:
##########
@@ -44,8 +73,31 @@ public static Object hashPrimaryKey(PrimaryKey primaryKey,
HashFunction hashFunc
return new ByteArray(HashUtils.hashMD5(primaryKey.asBytes()));
case MURMUR3:
return new ByteArray(HashUtils.hashMurmur3(primaryKey.asBytes()));
+ case UUID:
+ return new ByteArray(HashUtils.hashUUID(primaryKey.getValues()));
default:
throw new IllegalArgumentException(String.format("Unrecognized hash
function %s", hashFunction));
}
}
+
+ /**
+ * Concatenates the string representation of all values into a single byte
array. Each element is prepended with its
+ * 4-byte length to ensure no collisions can happen. (sacrifice space
efficiency for correctness)
+ */
+ private static byte[] concatenate(Object[] values) {
+ byte[][] allValueBytes = new byte[values.length][];
+ int totalLen = 0;
+ for (int j = 0; j < allValueBytes.length; j++) {
+ allValueBytes[j] = values[j] == null ?
"null".getBytes(StandardCharsets.UTF_8)
Review Comment:
I checked the code, and `PrimaryKey` should never contain `null` (it will
contain default null value instead). We can just let it throw when encountering
`null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
