Re: [PR] Add exception for resource limit exceeded in MultiStageOperator [pinot]

2025-06-12 Thread via GitHub
gortiz merged PR #16077: URL: https://github.com/apache/pinot/pull/16077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

Re: [PR] Add exception for resource limit exceeded in MultiStageOperator [pinot]

2025-06-12 Thread via GitHub
gortiz commented on PR #16077: URL: https://github.com/apache/pinot/pull/16077#issuecomment-2969203642 We are going to receive a ServerResourceLimitExceededError, which is the same we return when we reach max number of rows in a join, for example. This may not be perfect, but customers will

Re: [PR] Add exception for resource limit exceeded in MultiStageOperator [pinot]

2025-06-12 Thread via GitHub
vrajat commented on code in PR #16077: URL: https://github.com/apache/pinot/pull/16077#discussion_r2142392974 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultiStageOperator.java: ## @@ -78,6 +79,8 @@ protected void sampleAndCheckInterruption() {

Re: [PR] Add exception for resource limit exceeded in MultiStageOperator [pinot]

2025-06-12 Thread via GitHub
vrajat commented on code in PR #16077: URL: https://github.com/apache/pinot/pull/16077#discussion_r2142387657 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultiStageOperator.java: ## @@ -78,6 +79,8 @@ protected void sampleAndCheckInterruption() {

Re: [PR] Add exception for resource limit exceeded in MultiStageOperator [pinot]

2025-06-12 Thread via GitHub
vrajat commented on code in PR #16077: URL: https://github.com/apache/pinot/pull/16077#discussion_r2142392974 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultiStageOperator.java: ## @@ -78,6 +79,8 @@ protected void sampleAndCheckInterruption() {

[PR] Add exception for resource limit exceeded in MultiStageOperator [pinot]

2025-06-11 Thread via GitHub
gortiz opened a new pull request, #16077: URL: https://github.com/apache/pinot/pull/16077 While working on https://github.com/apache/pinot/pull/16075, I've reused the `sampleAndCheckInterruption` method to also check for timeouts during execution. When I did that, I found it strange that th