vrajat commented on code in PR #16077:
URL: https://github.com/apache/pinot/pull/16077#discussion_r2142392974


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultiStageOperator.java:
##########
@@ -78,6 +79,8 @@ protected void sampleAndCheckInterruption() {
     Tracing.ThreadAccountantOps.sampleMSE();
     if (Tracing.ThreadAccountantOps.isInterrupted()) {
       earlyTerminate();
+      throw 
QueryErrorCode.SERVER_RESOURCE_LIMIT_EXCEEDED.asException("Resource limit 
exceeded for operator: "

Review Comment:
   Also as history - when I initially worked on this code, I assumed 
`earlyTerminate` threw `EarlyTerminationException`. I was overwhelmed with the 
new code to not verify that. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to