gortiz commented on PR #16077: URL: https://github.com/apache/pinot/pull/16077#issuecomment-2969203642
We are going to receive a ServerResourceLimitExceededError, which is the same we return when we reach max number of rows in a join, for example. This may not be perfect, but customers will have a better feedback than receiving a cancellation exception. I was thinking about adding a new error code, but TBH I think ServerResourceLimitExceededError is a good one and probably sending an error code specific for OOM query killing is too low level and implementation dependent, while sending the same ServerResourceLimitExceededError we send when joins are too large is a good compromise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
