swaminathanmanish merged PR #14451:
URL: https://github.com/apache/pinot/pull/14451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@
vrajat commented on code in PR #14451:
URL: https://github.com/apache/pinot/pull/14451#discussion_r1865604773
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##
@@ -1046,6 +1064,276 @@ public boolean needReloadSegments()
return need
KKcorps commented on code in PR #14451:
URL: https://github.com/apache/pinot/pull/14451#discussion_r1865194105
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##
@@ -1046,6 +1064,261 @@ public boolean needReloadSegments()
return nee
swaminathanmanish commented on code in PR #14451:
URL: https://github.com/apache/pinot/pull/14451#discussion_r1864869862
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableStaleSegmentResponse.java:
##
@@ -0,0 +1,67 @@
+/**
+ * Licensed to the Apach
swaminathanmanish commented on PR #14451:
URL: https://github.com/apache/pinot/pull/14451#issuecomment-2509678253
> The core feature in this PR is a function
`BaseTableDataManager.getSegmentsForRefresh` which finds all the segments of a
table that requires a refresh. It accepts a Table Conf
vrajat commented on PR #14451:
URL: https://github.com/apache/pinot/pull/14451#issuecomment-2506102938
Two more outstanding items:
* Add a test where server returns an error. Is there a way to mock that ?
* Add tests for startree index
--
This is an automated message from the Apache
vrajat commented on code in PR #14451:
URL: https://github.com/apache/pinot/pull/14451#discussion_r1862165234
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##
@@ -891,6 +892,31 @@ public String getTableReloadMetadat
vrajat commented on code in PR #14451:
URL: https://github.com/apache/pinot/pull/14451#discussion_r1862161067
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/TableDataManager.java:
##
@@ -323,4 +323,12 @@ default void onConsumingToDropped(String
vrajat commented on code in PR #14451:
URL: https://github.com/apache/pinot/pull/14451#discussion_r1861554378
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/TableDataManager.java:
##
@@ -323,4 +323,12 @@ default void onConsumingToDropped(String
vrajat commented on code in PR #14451:
URL: https://github.com/apache/pinot/pull/14451#discussion_r1861536819
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/TableDataManager.java:
##
@@ -323,4 +323,12 @@ default void onConsumingToDropped(String
swaminathanmanish commented on code in PR #14451:
URL: https://github.com/apache/pinot/pull/14451#discussion_r1861544111
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/TableDataManager.java:
##
@@ -323,4 +323,12 @@ default void onConsumingToDrop
vrajat commented on code in PR #14451:
URL: https://github.com/apache/pinot/pull/14451#discussion_r1861534450
##
pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java:
##
@@ -397,6 +398,35 @@ public ValidDocIdsBitmapResponse
getValidDo
swaminathanmanish commented on code in PR #14451:
URL: https://github.com/apache/pinot/pull/14451#discussion_r1860973442
##
pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java:
##
@@ -397,6 +398,35 @@ public ValidDocIdsBitmapResponse
vrajat commented on code in PR #14451:
URL: https://github.com/apache/pinot/pull/14451#discussion_r1855827237
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##
@@ -891,6 +892,31 @@ public String getTableReloadMetadat
vrajat commented on code in PR #14451:
URL: https://github.com/apache/pinot/pull/14451#discussion_r1855820871
##
pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java:
##
@@ -397,6 +398,39 @@ public ValidDocIdsBitmapResponse
getValidDo
vrajat commented on code in PR #14451:
URL: https://github.com/apache/pinot/pull/14451#discussion_r1855815497
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##
@@ -1046,6 +1064,261 @@ public boolean needReloadSegments()
return need
swaminathanmanish commented on code in PR #14451:
URL: https://github.com/apache/pinot/pull/14451#discussion_r1855428433
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/NeedRefreshResponse.java:
##
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache
vrajat commented on code in PR #14451:
URL: https://github.com/apache/pinot/pull/14451#discussion_r1854163236
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##
@@ -1046,6 +1064,261 @@ public boolean needReloadSegments()
return need
vrajat commented on code in PR #14451:
URL: https://github.com/apache/pinot/pull/14451#discussion_r1854163236
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##
@@ -1046,6 +1064,261 @@ public boolean needReloadSegments()
return need
vrajat commented on code in PR #14451:
URL: https://github.com/apache/pinot/pull/14451#discussion_r1854166400
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##
@@ -1046,6 +1064,261 @@ public boolean needReloadSegments()
return need
KKcorps commented on code in PR #14451:
URL: https://github.com/apache/pinot/pull/14451#discussion_r1853916253
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##
@@ -1046,6 +1064,261 @@ public boolean needReloadSegments()
return nee
KKcorps commented on code in PR #14451:
URL: https://github.com/apache/pinot/pull/14451#discussion_r1853913780
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##
@@ -1046,6 +1064,261 @@ public boolean needReloadSegments()
return nee
KKcorps commented on code in PR #14451:
URL: https://github.com/apache/pinot/pull/14451#discussion_r1853838884
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##
@@ -1046,6 +1064,261 @@ public boolean needReloadSegments()
return nee
23 matches
Mail list logo
