vrajat commented on code in PR #14451: URL: https://github.com/apache/pinot/pull/14451#discussion_r1861536819
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/TableDataManager.java: ########## @@ -323,4 +323,12 @@ default void onConsumingToDropped(String segmentNameStr) { */ default void onConsumingToOnline(String segmentNameStr) { } + + /** + * Return list of segment names that need to be refreshed along with reason. + * @param tableConfig Table Config of the table + * @param schema Schema of the table + * @return List of {@link NeedRefreshResponse} with segment names and reason for refresh + */ + List<NeedRefreshResponse> getSegmentsForRefresh(TableConfig tableConfig, Schema schema); Review Comment: `getDivergedSegments` or `getStaleSegments` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org